Enable & fix inspections: Single character string argument in String.indexOf() call (#2823)

Reports single character strings being used as an argument in String.indexOf() and String.lastIndexOf() calls.

A quick-fix is suggested to replace such string literals with equivalent character literals, gaining some performance enhancement.

Example:

```
  return s.indexOf("x");
```

After the quick-fix is applied:

```
  return s.indexOf('x');
```

Author: Bennett-Lynch

.idea/inspectionProfiles/AWS_Java_SDK_2_0.xml

@@ -62,7 +62,7 @@ private Predicate<String> isUnused(String content) {
     }
 
     private boolean isNotReferenced(String contentWithoutImports, String importToCheck) {
-        String symbol = importToCheck.substring(importToCheck.lastIndexOf(".") + 1);
+        String symbol = importToCheck.substring(importToCheck.lastIndexOf('.') + 1);
         return !Pattern.compile(String.format("\\b%s\\b", symbol)).matcher(contentWithoutImports).find();
     }
 

codegen-lite/src/main/java/software/amazon/awssdk/codegen/lite/emitters/UnusedImportRemover.java

@@ -62,7 +62,7 @@ private Predicate<String> isUnused(String content) {
     }
 
     private boolean isNotReferenced(String contentWithoutImports, String importToCheck) {
-        String symbol = importToCheck.substring(importToCheck.lastIndexOf(".") + 1);
+        String symbol = importToCheck.substring(importToCheck.lastIndexOf('.') + 1);
         return !Pattern.compile(String.format("\\b%s\\b", symbol)).matcher(contentWithoutImports).find();
     }
 

codegen/src/main/java/software/amazon/awssdk/codegen/emitters/UnusedImportRemover.java

@@ -72,8 +72,8 @@ public static String stripHtmlTags(String documentation) {
         }
 
         if (documentation.startsWith("<")) {
-            int startTagIndex = documentation.indexOf(">");
-            int closingTagIndex = documentation.lastIndexOf("<");
+            int startTagIndex = documentation.indexOf('>');
+            int closingTagIndex = documentation.lastIndexOf('<');
             if (closingTagIndex > startTagIndex) {
                 documentation = stripHtmlTags(documentation.substring(startTagIndex + 1, closingTagIndex));
             } else {

codegen/src/main/java/software/amazon/awssdk/codegen/internal/DocumentationUtils.java

@@ -125,7 +125,7 @@ public String getTemplateImplType() {
     }
 
     public String getSimpleType() {
-        int startIndex = memberType.lastIndexOf(".");
+        int startIndex = memberType.lastIndexOf('.');
         return memberType.substring(startIndex + 1);
     }
 }

codegen/src/main/java/software/amazon/awssdk/codegen/model/intermediate/ListModel.java

@@ -64,7 +64,7 @@ public void setVariableType(String variableType) {
 
     public String getSimpleType() {
         if (variableType.contains(".")) {
-            return variableType.substring(variableType.lastIndexOf(".") + 1);
+            return variableType.substring(variableType.lastIndexOf('.') + 1);
         }
         return variableType;
     }

codegen/src/main/java/software/amazon/awssdk/codegen/model/intermediate/VariableModel.java

@@ -98,8 +98,8 @@ public static TypeVariableName createBoundedTypeVariableName(String parameterNam
     }
 
     public static ClassName classNameFromFqcn(String fqcn) {
-        String basePath = fqcn.substring(0, fqcn.lastIndexOf("."));
-        String className = fqcn.substring(fqcn.lastIndexOf(".") + 1);
+        String basePath = fqcn.substring(0, fqcn.lastIndexOf('.'));
+        String className = fqcn.substring(fqcn.lastIndexOf('.') + 1);
         return ClassName.get(basePath, className);
     }
 

codegen/src/main/java/software/amazon/awssdk/codegen/poet/PoetUtils.java

@@ -389,7 +389,7 @@ private String protocolEnumName(software.amazon.awssdk.codegen.model.intermediat
 
     private ClassName baseExceptionClassName(IntermediateModel model) {
         String exceptionPath = model.getSdkModeledExceptionBaseFqcn()
-                                    .substring(0, model.getSdkModeledExceptionBaseFqcn().lastIndexOf("."));
+                                    .substring(0, model.getSdkModeledExceptionBaseFqcn().lastIndexOf('.'));
 
         return ClassName.get(exceptionPath, model.getSdkModeledExceptionBaseClassName());
     }

codegen/src/main/java/software/amazon/awssdk/codegen/poet/client/specs/JsonProtocolSpec.java

@@ -124,7 +124,7 @@ private String parseErrorCodeFromContents(JsonNode jsonContents) {
             return null;
         }
         String code = errorCodeField.text();
-        int separator = code.lastIndexOf("#");
+        int separator = code.lastIndexOf('#');
         return code.substring(separator + 1);
     }
 }

core/protocols/aws-json-protocol/src/main/java/software/amazon/awssdk/protocols/json/internal/unmarshall/JsonErrorCodeParser.java

@@ -62,13 +62,13 @@ static String addStaticQueryParametersToRequest(SdkHttpFullRequest.Builder reque
 
         String resourcePath = uriResourcePath;
 
-        int index = resourcePath.indexOf("?");
+        int index = resourcePath.indexOf('?');
         if (index != -1) {
             String queryString = resourcePath.substring(index + 1);
             resourcePath = resourcePath.substring(0, index);
 
             for (String s : queryString.split("[;&]")) {
-                index = s.indexOf("=");
+                index = s.indexOf('=');
                 if (index != -1) {
                     request.putRawQueryParameter(s.substring(0, index), s.substring(index + 1));
                 } else {

core/protocols/protocol-core/src/main/java/software/amazon/awssdk/protocols/core/ProtocolUtils.java

@@ -66,7 +66,7 @@ private long parseContentLengthFromRange(String range) {
         String end = range.substring(range.indexOf('-') + 1);
 
         if (end.contains("/")) {
-            end = end.substring(0, end.indexOf("/"));
+            end = end.substring(0, end.indexOf('/'));
         }
 
         return Long.parseLong(end) - Long.parseLong(start) + 1;

services/glacier/src/main/java/software/amazon/awssdk/services/glacier/internal/GlacierExecutionInterceptor.java

@@ -252,7 +252,7 @@ private String removePrefix(String s) {
             return null;
         }
 
-        int lastIndex = s.lastIndexOf("/");
+        int lastIndex = s.lastIndexOf('/');
         if (lastIndex > 0) {
             return s.substring(lastIndex + 1);
         }

services/route53/src/main/java/software/amazon/awssdk/services/route53/internal/Route53IdInterceptor.java

@@ -41,6 +41,6 @@ private String getActualPath(LoggedRequest actual) {
     }
 
     private String removeTrailingSlash(String str) {
-        return (str.endsWith("/")) ? str.substring(0, str.lastIndexOf("/")) : str;
+        return (str.endsWith("/")) ? str.substring(0, str.lastIndexOf('/')) : str;
     }
 }