Remove buffer copy since it's no longer needed

Author: zoewangg

pom.xml

@@ -112,7 +112,7 @@
         <rxjava.version>2.2.21</rxjava.version>
         <commons-codec.verion>1.10</commons-codec.verion>
         <jmh.version>1.29</jmh.version>
-        <awscrt.version>0.13.5</awscrt.version>
+        <awscrt.version>0.13.11</awscrt.version>
 
         <!--Test dependencies -->
         <junit.version>4.13.1</junit.version>

services-custom/s3-transfer-manager/src/main/java/software/amazon/awssdk/transfer/s3/internal/CrtResponseDataConsumerAdapter.java

@@ -25,7 +25,6 @@
 import software.amazon.awssdk.crt.http.HttpHeader;
 import software.amazon.awssdk.http.SdkHttpResponse;
 import software.amazon.awssdk.services.s3.model.GetObjectResponse;
-import software.amazon.awssdk.utils.BinaryUtils;
 import software.amazon.awssdk.utils.Logger;
 
 /**
@@ -81,10 +80,7 @@ public void onResponse(GetObjectOutput output) {
     @Override
     public void onResponseData(ByteBuffer byteBuffer) {
         log.trace(() -> "Received data of size " + byteBuffer.remaining());
-
-        // Need to make a copy because the incoming byteBuffer might get released soon
-        ByteBuffer newByteBuffer = ByteBuffer.wrap(BinaryUtils.copyAllBytesFrom(byteBuffer));
-        publisher.deliverData(newByteBuffer);
+        publisher.deliverData(byteBuffer);
     }
 
     @Override

services-custom/s3-transfer-manager/src/test/java/software/amazon/awssdk/transfer/s3/internal/CrtResponseDataConsumerAdapterTest.java

@@ -54,17 +54,4 @@ public void onResponse_noSdkHttpResponse_shouldCreateEmptySdkHttpResponse() {
         assertThat(captor.getValue().responseMetadata().requestId()).isEqualTo("UNKNOWN");
         assertThat(captor.getValue().sdkHttpResponse()).isNotNull();
     }
-
-    @Test
-    public void onResponseData_shouldCopyByteBuffer() {
-        ArgumentCaptor<ByteBuffer> captor = ArgumentCaptor.forClass(ByteBuffer.class);
-        byte[] expectedBytes = "helloworld".getBytes(StandardCharsets.UTF_8);
-        ByteBuffer byteBuffer = ByteBuffer.wrap(expectedBytes);
-        adapter.onResponseData(byteBuffer);
-
-        verify(publisher).deliverData(captor.capture());
-        ByteBuffer actualByteBuffer = captor.getValue();
-        assertThat(actualByteBuffer).isNotSameAs(byteBuffer);
-        assertThat(actualByteBuffer.array()).isEqualTo(expectedBytes);
-    }
 }