Skip to content

Commit 8128c99

Browse files
committed
Add sample code link to README and fix MissingSdkAnnotationCheck to check interface
1 parent 849d607 commit 8128c99

File tree

5 files changed

+20
-5
lines changed

5 files changed

+20
-5
lines changed

README.md

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ artifact source.
1111

1212
* [SDK Homepage][sdk-website]
1313
* [1.11 to 2.0 Changelog](docs/LaunchChangelog.md)
14+
* [Sample Code](#sample-code)
1415
* [API Docs][docs-api]
1516
* [Developer Guide][docs-guide] ([source][docs-guide-source])
1617
* [Issues][sdk-issues]
@@ -111,13 +112,18 @@ See the [Set up the AWS SDK for Java][docs-setup] section of the developer guide
111112

112113
## Building From Source
113114

114-
Once you check out the code from GitHub, you can build it using Maven. To disable the GPG-signing
115-
in the build, use:
115+
Once you check out the code from GitHub, you can build it using Maven.
116116

117117
```sh
118-
mvn clean install -Dgpg.skip=true
118+
mvn clean install
119119
```
120120

121+
## Sample Code
122+
You can find sample code for v2 in the following places:
123+
124+
* [aws-doc-sdk-examples] repo.
125+
* Integration tests in this repo. They are located in the `it` directory under each service module, eg: [s3-integration-tests]
126+
121127
## Giving Feedback
122128
We need your help in making this SDK great. Please participate in the community and contribute to this effort by submitting issues, participating in discussion forums and submitting pull requests through the following channels.
123129

@@ -145,3 +151,5 @@ We need your help in making this SDK great. Please participate in the community
145151
[support-center]: https://console.aws.amazon.com/support/
146152
[console]: https://console.aws.amazon.com
147153
[bom]: http://search.maven.org/#search%7Cgav%7C1%7Cg%3A%22software.amazon.awssdk%22%20AND%20a%3A%22bom%22
154+
[aws-doc-sdk-examples]: https://github.com/awsdocs/aws-doc-sdk-examples/tree/master/javav2
155+
[s3-integration-tests]: https://github.com/aws/aws-sdk-java-v2/tree/master/services/s3/src/it/java/software/amazon/awssdk/services/s3

build-tools/src/main/java/software/amazon/awssdk/buildtools/checkstyle/MissingSdkAnnotationCheck.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,13 @@ public int[] getAcceptableTokens() {
4343
@Override
4444
public int[] getRequiredTokens() {
4545
return new int[] {
46-
TokenTypes.CLASS_DEF
46+
TokenTypes.CLASS_DEF,
47+
TokenTypes.INTERFACE_DEF
4748
};
4849
}
4950

5051
@Override
51-
public void visitToken(final DetailAST ast) {
52+
public void visitToken(DetailAST ast) {
5253
if (!ScopeUtils.isOuterMostType(ast) || SDK_ANNOTATIONS.stream().anyMatch(a -> AnnotationUtility.containsAnnotation
5354
(ast, a))) {
5455
return;

core/aws-core/src/main/java/software/amazon/awssdk/awscore/eventstream/EventStreamResponseHandler.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,10 @@
2121
import org.reactivestreams.Publisher;
2222
import org.reactivestreams.Subscriber;
2323
import org.reactivestreams.Subscription;
24+
import software.amazon.awssdk.annotations.SdkProtectedApi;
2425
import software.amazon.awssdk.core.async.SdkPublisher;
2526

27+
@SdkProtectedApi
2628
public interface EventStreamResponseHandler<ResponseT, EventT> {
2729

2830
/**

core/protocols/aws-json-protocol/src/main/java/software/amazon/awssdk/protocols/json/internal/dom/SdkJsonNode.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,12 @@
1717

1818
import java.util.List;
1919
import java.util.Map;
20+
import software.amazon.awssdk.annotations.SdkInternalApi;
2021

2122
/**
2223
* DOM interface for reading a JSON document.
2324
*/
25+
@SdkInternalApi
2426
public interface SdkJsonNode {
2527

2628
/**

core/sdk-core/src/main/java/software/amazon/awssdk/core/internal/http/TransformingAsyncResponseHandler.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,15 @@
1616
package software.amazon.awssdk.core.internal.http;
1717

1818
import java.util.concurrent.CompletableFuture;
19+
import software.amazon.awssdk.annotations.SdkInternalApi;
1920
import software.amazon.awssdk.http.async.SdkAsyncHttpResponseHandler;
2021

2122
/**
2223
* A response handler that returns a transformed response.
2324
*
2425
* @param <ResultT> The type of the result.
2526
*/
27+
@SdkInternalApi
2628
public interface TransformingAsyncResponseHandler<ResultT> extends SdkAsyncHttpResponseHandler {
2729
/**
2830
* Return the future holding the transformed response.

0 commit comments

Comments
 (0)