Skip to content

Commit 5d0207d

Browse files
author
AWS
committed
Amazon CodeGuru Reviewer Update: Added failure state and adjusted timeout in waiter
1 parent c727e98 commit 5d0207d

File tree

3 files changed

+27
-4
lines changed

3 files changed

+27
-4
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"type": "feature",
3+
"category": "Amazon CodeGuru Reviewer",
4+
"contributor": "",
5+
"description": "Added failure state and adjusted timeout in waiter"
6+
}

services/codegurureviewer/src/main/resources/codegen-resources/service-2.json

+7-2
Original file line numberDiff line numberDiff line change
@@ -895,6 +895,11 @@
895895
}
896896
}
897897
},
898+
"ListRecommendationsMaxResults":{
899+
"type":"integer",
900+
"max":300,
901+
"min":1
902+
},
898903
"ListRecommendationsRequest":{
899904
"type":"structure",
900905
"required":["CodeReviewArn"],
@@ -906,7 +911,7 @@
906911
"locationName":"NextToken"
907912
},
908913
"MaxResults":{
909-
"shape":"MaxResults",
914+
"shape":"ListRecommendationsMaxResults",
910915
"documentation":"<p> The maximum number of results that are returned per call. The default is 100. </p>",
911916
"location":"querystring",
912917
"locationName":"MaxResults"
@@ -1666,7 +1671,7 @@
16661671
},
16671672
"Text":{
16681673
"type":"string",
1669-
"max":2048,
1674+
"max":5000,
16701675
"min":1
16711676
},
16721677
"ThirdPartySourceRepository":{

services/codegurureviewer/src/main/resources/codegen-resources/waiters-2.json

+14-2
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,20 @@
77
"description": "Wait until a repository association is complete.",
88
"operation": "DescribeRepositoryAssociation",
99
"delay": 10,
10-
"maxAttempts": 20,
10+
"maxAttempts": 30,
1111
"acceptors": [
1212
{
1313
"state": "success",
1414
"matcher": "path",
1515
"argument": "RepositoryAssociation.State",
1616
"expected": "Associated"
1717
},
18+
{
19+
"state": "failure",
20+
"matcher": "path",
21+
"argument": "RepositoryAssociation.State",
22+
"expected": "Failed"
23+
},
1824
{
1925
"state": "retry",
2026
"matcher": "path",
@@ -27,14 +33,20 @@
2733
"description": "Wait until a code review is complete.",
2834
"operation": "DescribeCodeReview",
2935
"delay": 10,
30-
"maxAttempts": 60,
36+
"maxAttempts": 180,
3137
"acceptors": [
3238
{
3339
"state": "success",
3440
"matcher": "path",
3541
"argument": "CodeReview.State",
3642
"expected": "Completed"
3743
},
44+
{
45+
"state": "failure",
46+
"matcher": "path",
47+
"argument": "CodeReview.State",
48+
"expected": "Failed"
49+
},
3850
{
3951
"state": "retry",
4052
"matcher": "path",

0 commit comments

Comments
 (0)