Fixed an issue where streaming writes could be misordered.

This fixes a cause of "S3: Data read has a different checksum than expected": #953

Author: millems

.changes/next-release/bugfix-AmazonS3-8e7768a.json

@@ -0,0 +1,5 @@
+{
+    "type": "bugfix",
+    "category": "Amazon S3",
+    "description": "Fixed an issue that could cause \"Data read has a different checksum than expected\" errors."
+}

.changes/next-release/bugfix-NettyNIOHTTPClient-8326112.json

@@ -0,0 +1,5 @@
+{
+    "type": "bugfix",
+    "category": "Netty NIO HTTP Client",
+    "description": "Fixed an issue where, under rare circumstances, streaming request bytes could be misordered."
+}

http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/internal/utils/OrderedWriteChannelHandlerContext.java

@@ -18,7 +18,6 @@
 import io.netty.channel.ChannelFuture;
 import io.netty.channel.ChannelHandlerContext;
 import io.netty.channel.ChannelPromise;
-import io.netty.util.AttributeKey;
 import java.util.function.Consumer;
 import software.amazon.awssdk.annotations.SdkInternalApi;
 
@@ -30,18 +29,11 @@
  */
 @SdkInternalApi
 public class OrderedWriteChannelHandlerContext extends DelegatingChannelHandlerContext {
-    private static final AttributeKey<Void> ORDERED =
-        NettyUtils.getOrCreateAttributeKey("aws.http.nio.netty.async.OrderedWriteChannelHandlerContext.ORDERED");
-
     private OrderedWriteChannelHandlerContext(ChannelHandlerContext delegate) {
         super(delegate);
-        delegate.channel().attr(ORDERED).set(null);
     }
 
     public static ChannelHandlerContext wrap(ChannelHandlerContext ctx) {
-        if (ctx.channel().hasAttr(ORDERED)) {
-            return ctx;
-        }
         return new OrderedWriteChannelHandlerContext(ctx);
     }