Skip to content

Commit 47a21ef

Browse files
committed
Fix flaky ddb integ test by setting strong read consistency
1 parent 69b1f42 commit 47a21ef

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

services/dynamodb/src/it/java/software/amazon/awssdk/services/dynamodb/PaginatorIntegrationTest.java

+8-6
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ public void batchGetItem_allProcessed_shouldNotHaveNextPage() {
107107

108108
@Test
109109
public void test_MultipleIteration_On_Responses_Iterable() {
110-
ScanRequest request = ScanRequest.builder().tableName(TABLE_NAME).limit(2).build();
110+
ScanRequest request = scanRequest(2);
111111
ScanIterable scanResponses = dynamo.scanPaginator(request);
112112

113113
int count = 0;
@@ -128,7 +128,7 @@ public void test_MultipleIteration_On_Responses_Iterable() {
128128

129129
@Test
130130
public void test_MultipleIteration_On_PaginatedMember_Iterable() {
131-
ScanRequest request = ScanRequest.builder().tableName(TABLE_NAME).limit(2).build();
131+
ScanRequest request = scanRequest(2);
132132
SdkIterable<Map<String, AttributeValue>> items = dynamo.scanPaginator(request).items();
133133

134134
int count = 0;
@@ -150,7 +150,7 @@ public void test_MultipleIteration_On_PaginatedMember_Iterable() {
150150
@Test
151151
public void test_MultipleIteration_On_Responses_Stream() {
152152
int results_per_page = 2;
153-
ScanRequest request = ScanRequest.builder().tableName(TABLE_NAME).limit(results_per_page).build();
153+
ScanRequest request = scanRequest(results_per_page);
154154
ScanIterable scanResponses = dynamo.scanPaginator(request);
155155

156156
// Iterate once
@@ -169,8 +169,7 @@ public void test_MultipleIteration_On_Responses_Stream() {
169169

170170
@Test
171171
public void test_MultipleIteration_On_PaginatedMember_Stream() {
172-
int results_per_page = 2;
173-
ScanRequest request = ScanRequest.builder().tableName(TABLE_NAME).limit(results_per_page).build();
172+
ScanRequest request = scanRequest(2);
174173
SdkIterable<Map<String, AttributeValue>> items = dynamo.scanPaginator(request).items();
175174

176175
// Iterate once
@@ -195,7 +194,7 @@ public void iteration_On_SameStream_ThrowsError() {
195194

196195
@Test
197196
public void mix_Iterator_And_Stream_Calls() {
198-
ScanRequest request = ScanRequest.builder().tableName(TABLE_NAME).limit(2).build();
197+
ScanRequest request = scanRequest(2);
199198
ScanIterable scanResponses = dynamo.scanPaginator(request);
200199

201200
assertEquals(ITEM_COUNT, scanResponses.stream().flatMap(r -> r.items().stream())
@@ -226,4 +225,7 @@ private static void putTestData() {
226225
}
227226
}
228227

228+
private ScanRequest scanRequest(int limit) {
229+
return ScanRequest.builder().tableName(TABLE_NAME).consistentRead(true).limit(limit).build();
230+
}
229231
}

0 commit comments

Comments
 (0)