Skip to content

Commit 45fe067

Browse files
committed
Fix s3 access point integ tests - creating a new AP for every request and deleting resources afterwards
1 parent 9f40c03 commit 45fe067

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

services/s3/src/it/java/software/amazon/awssdk/services/s3/AccessPointsIntegrationTest.java

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,21 @@
1818
import static software.amazon.awssdk.testutils.service.S3BucketUtils.temporaryBucketName;
1919

2020
import java.util.StringJoiner;
21+
import org.junit.AfterClass;
2122
import org.junit.BeforeClass;
2223
import org.junit.Test;
2324
import software.amazon.awssdk.core.sync.RequestBody;
2425
import software.amazon.awssdk.regions.Region;
2526
import software.amazon.awssdk.services.s3.model.GetObjectRequest;
2627
import software.amazon.awssdk.services.s3.model.PutObjectRequest;
2728
import software.amazon.awssdk.services.s3control.S3ControlClient;
28-
import software.amazon.awssdk.services.s3control.model.S3ControlException;
2929
import software.amazon.awssdk.services.sts.StsClient;
3030

3131
public class AccessPointsIntegrationTest extends S3IntegrationTestBase {
3232

33-
private static final String BUCKET = temporaryBucketName(AclIntegrationTest.class);
33+
private static final String BUCKET = temporaryBucketName(AccessPointsIntegrationTest.class);
3434

35-
private static final String AP_NAME = "java-sdk";
35+
private static final String AP_NAME = "java-sdk-" + System.currentTimeMillis();
3636

3737
private static final String KEY = "some-key";
3838

@@ -57,14 +57,15 @@ public static void setupFixture() {
5757
.build();
5858

5959
accountId = sts.getCallerIdentity().account();
60+
s3control.createAccessPoint(r -> r.accountId(accountId)
61+
.bucket(BUCKET)
62+
.name(AP_NAME));
63+
}
6064

61-
try {
62-
s3control.createAccessPoint(r -> r.accountId(accountId)
63-
.bucket(BUCKET)
64-
.name(AP_NAME));
65-
} catch (S3ControlException e) {
66-
// Do nothing as the access point is already created
67-
}
65+
@AfterClass
66+
public static void tearDown() {
67+
deleteBucketAndAllContents(BUCKET);
68+
s3control.deleteAccessPoint(b -> b.accountId(accountId).name(AP_NAME));
6869
}
6970

7071
@Test

0 commit comments

Comments
 (0)