Skip to content

Commit 3af3758

Browse files
authored
Fix javadocs warnings in the sdk-core package (#3992)
1 parent 7d302ee commit 3af3758

File tree

8 files changed

+29
-20
lines changed

8 files changed

+29
-20
lines changed
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"category": "AWS SDK for Java v2",
3+
"contributor": "sugmanue",
4+
"type": "documentation",
5+
"description": "Fix javadoc warnings in the sdk-core package."
6+
}

core/sdk-core/src/main/java/software/amazon/awssdk/core/SdkNumber.java

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,20 +27,23 @@
2727
* An in-memory representation of Number being given to a service or being returned by a service.
2828
* This is a SDK representation of a Number. This allows conversion to any desired numeric type by providing constructors
2929
* as below
30-
* @see #fromBigDecimal(BigDecimal) to create from a BigDecimal.
31-
* @see #fromBigInteger(BigInteger) to create from a BigInteger.
32-
* @see #fromDouble(double) to create from a double
33-
* @see #fromFloat(float) to create from a float.
34-
* @see #fromLong(long) to create from a long.
35-
* @see #fromShort(short) to create from a short.
36-
* @see #fromInteger(int) to create from an integer.
37-
* @see #fromString(String) to create from a Stringl,
38-
* Thus by doing this, this class is able to preserve arbitrary precison of any given number.
30+
* <ul>
31+
* <li>{@link #fromBigDecimal(BigDecimal)} to create from a BigDecimal.</li>
32+
* <li>{@link #fromBigInteger(BigInteger)} to create from a BigInteger.</li>
33+
* <li>{@link #fromDouble(double)} to create from a double</li>
34+
* <li>{@link #fromFloat(float)} to create from a float.</li>
35+
* <li>{@link #fromLong(long)} to create from a long.</li>
36+
* <li>{@link #fromShort(short)} to create from a short.</li>
37+
* <li>{@link #fromInteger(int)} to create from an integer.</li>
38+
* <li>{@link #fromString(String)} to create from a String</li>
39+
* </ul>
3940
*
41+
* Thus, by doing this, this class is able to preserve arbitrary precision of any given number.
42+
* <p>
4043
* If {@link SdkNumber} is expected in a particular number format then its corresponding getter methods can be used.
44+
* <p>
4145
* Example for a {@link SdkNumber} created with {@link BigDecimal} the
42-
* @see #fromBigDecimal(BigDecimal) can be used.
43-
46+
* {@link #fromBigDecimal(BigDecimal)} can be used.
4447
*/
4548
@SdkPublicApi
4649
@Immutable

core/sdk-core/src/main/java/software/amazon/awssdk/core/async/AsyncRequestBody.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,8 @@ static BlockingInputStreamAsyncRequestBody forBlockingInputStream(Long contentLe
208208
* Creates a {@link BlockingOutputStreamAsyncRequestBody} to use for writing to the downstream service as if it's an output
209209
* stream. Retries are not supported for this request body.
210210
*
211-
* <p>The caller is responsible for calling {@link OutputStream#close()} on the {@link #outputStream()} when writing is
212-
* complete.
211+
* <p>The caller is responsible for calling {@link OutputStream#close()} on the
212+
* {@link BlockingOutputStreamAsyncRequestBody#outputStream()} when writing is complete.
213213
*
214214
* <p><b>Example Usage</b>
215215
* <p>

core/sdk-core/src/main/java/software/amazon/awssdk/core/internal/http/pipeline/stages/ApiCallAttemptTimeoutTrackingStage.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,8 @@ public ApiCallAttemptTimeoutTrackingStage(HttpClientDependencies dependencies,
5656

5757
/**
5858
* Start and end api call attempt timer around the execution of the api call attempt. It's important
59-
* that the client execution task is canceled before the InterruptedException is handled by
60-
* {@link ApiCallTimeoutTrackingStage#wrapped#execute(SdkHttpFullRequest)} so the interrupt status doesn't leak out to the
61-
* callers code.
59+
* that the client execution task is canceled before the InterruptedException is handled by the wrapped
60+
* {@link RequestPipeline#execute} call so the interrupt status doesn't leak out to the callers code.
6261
*/
6362
@Override
6463
public Response<OutputT> execute(SdkHttpFullRequest request, RequestExecutionContext context) throws Exception {

core/sdk-core/src/main/java/software/amazon/awssdk/core/internal/io/AwsChunkedEncodingInputStream.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
* which is added at the head of each chunk.<br>
3333
* The default chunk size cannot be customized, since we need to calculate
3434
* the expected encoded stream length before reading the wrapped stream.<br>
35-
* This class will use the mark() & reset() of the wrapped InputStream if they
35+
* This class will use the mark() &amp; reset() of the wrapped InputStream if they
3636
* are supported, otherwise it will create a buffer for bytes read from
3737
* the wrapped stream.
3838
*/

core/sdk-core/src/main/java/software/amazon/awssdk/core/internal/retry/RateLimitingTokenBucket.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public RateLimitingTokenBucket() {
7373
*
7474
* _TokenBucketRefill()
7575
* # Next see if we have enough capacity for the requested amount.
76-
* if amount <= current_capacity
76+
* if amount &lt;= current_capacity
7777
* current_capacity = current_capacity - amount
7878
* else
7979
* sleep((amount - current_capacity) / fill_rate)
@@ -108,7 +108,7 @@ public boolean acquire(double amount) {
108108
*
109109
* _TokenBucketRefill()
110110
* # Next see if we have enough capacity for the requested amount.
111-
* if amount <= current_capacity
111+
* if amount &lt;= current_capacity
112112
* current_capacity = current_capacity - amount
113113
* else
114114
* sleep((amount - current_capacity) / fill_rate)

core/sdk-core/src/main/java/software/amazon/awssdk/core/retry/backoff/BackoffStrategy.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public interface BackoffStrategy {
2727

2828
/**
2929
* Max permitted retry times. To prevent exponentialDelay from overflow, there must be 2 ^ retriesAttempted
30-
* <= 2 ^ 31 - 1, which means retriesAttempted <= 30, so that is the ceil for retriesAttempted.
30+
* &lt;= 2 ^ 31 - 1, which means retriesAttempted &lt;= 30, so that is the ceil for retriesAttempted.
3131
*/
3232
int RETRIES_ATTEMPTED_CEILING = (int) Math.floor(Math.log(Integer.MAX_VALUE) / Math.log(2));
3333

core/sdk-core/src/main/java/software/amazon/awssdk/core/traits/Trait.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
package software.amazon.awssdk.core.traits;
1717

1818
import software.amazon.awssdk.annotations.SdkProtectedApi;
19+
import software.amazon.awssdk.core.SdkField;
1920

2021
/**
2122
* Marker interface for traits that contain additional metadata about {@link SdkField}s.

0 commit comments

Comments
 (0)