Remove CrtResource.waitForNoResources() from integration tests because it increases test time and makes tests flaky especially when tests are running in parallel. We still verify it in wiremock tests and stability tests

Author: zoewangg

services/s3/src/it/java/software/amazon/awssdk/services/SelectObjectContentIntegrationTest.java

@@ -77,7 +77,7 @@ public static void teardown() {
         } finally {
             s3AsyncClients().forEach(SdkAutoCloseable::close);
             s3.close();
-            CrtResource.waitForNoResources();
+
         }
     }
 

services/s3/src/it/java/software/amazon/awssdk/services/s3/crt/ChecksumIntegrationTest.java

@@ -66,7 +66,7 @@ public static void teardown() throws IOException {
         S3IntegrationTestBase.deleteBucketAndAllContents(TEST_BUCKET);
         Files.delete(testFile.toPath());
         s3Crt.close();
-        CrtResource.waitForNoResources();
+
     }
 
     @Test

services/s3/src/it/java/software/amazon/awssdk/services/s3/crt/CrtExceptionTransformationIntegrationTest.java

@@ -61,7 +61,7 @@ public static void setupFixture() throws Exception {
     public static void tearDownFixture() {
         S3IntegrationTestBase.deleteBucketAndAllContents(BUCKET);
         s3Crt.close();
-        CrtResource.waitForNoResources();
+
     }
 
     @Test

services/s3/src/it/java/software/amazon/awssdk/services/s3/crt/S3CrossRegionCrtIntegrationTest.java

@@ -84,7 +84,7 @@ public static void cleanup() {
         crtClient.close();
         S3IntegrationTestBase.deleteBucketAndAllContents(BUCKET);
         executorService.shutdown();
-        CrtResource.waitForNoResources();
+
     }
 
     @Test

services/s3/src/it/java/software/amazon/awssdk/services/s3/crt/S3CrtClientPutObjectIntegrationTest.java

@@ -74,7 +74,7 @@ public static void teardown() throws IOException {
         S3IntegrationTestBase.deleteBucketAndAllContents(TEST_BUCKET);
         Files.delete(testFile.toPath());
         s3Crt.close();
-        CrtResource.waitForNoResources();
+
     }
 
     @Test

services/s3/src/it/java/software/amazon/awssdk/services/s3/crt/S3CrtGetObjectIntegrationTest.java

@@ -66,7 +66,6 @@ public static void cleanup() {
         crtClient.close();
         S3IntegrationTestBase.deleteBucketAndAllContents(BUCKET);
         executorService.shutdown();
-        CrtResource.waitForNoResources();
     }
 
     @Test

services/s3/src/it/java/software/amazon/awssdk/services/s3/crthttpclient/S3WithCrtHttpClientsIntegrationTests.java

@@ -58,7 +58,7 @@ public static void teardown() throws IOException {
         S3IntegrationTestBase.deleteBucketAndAllContents(TEST_BUCKET);
         Files.delete(testFile.toPath());
         s3WithCrtHttpClient.close();
-        CrtResource.waitForNoResources();
+
     }
 
     @Test

services/s3/src/it/java/software/amazon/awssdk/services/s3/multipart/S3ClientMultiPartCopyIntegrationTest.java

@@ -38,6 +38,7 @@
 import software.amazon.awssdk.core.ResponseBytes;
 import software.amazon.awssdk.core.async.AsyncRequestBody;
 import software.amazon.awssdk.core.sync.ResponseTransformer;
+import software.amazon.awssdk.crt.CrtResource;
 import software.amazon.awssdk.services.s3.S3AsyncClient;
 import software.amazon.awssdk.services.s3.S3IntegrationTestBase;
 import software.amazon.awssdk.services.s3.internal.crt.S3CrtAsyncClient;
@@ -80,6 +81,7 @@ public static void teardown() throws Exception {
         s3CrtAsyncClient.close();
         s3MpuClient.close();
         deleteBucketAndAllContents(BUCKET);
+
     }
 
     public static Stream<S3AsyncClient> s3AsyncClient() {

services/s3/src/it/java/software/amazon/awssdk/services/s3/s3express/S3ExpressIntegrationTest.java

@@ -57,6 +57,7 @@
 import software.amazon.awssdk.core.rules.testing.model.Expect;
 import software.amazon.awssdk.core.sync.RequestBody;
 import software.amazon.awssdk.core.sync.ResponseTransformer;
+import software.amazon.awssdk.crt.CrtResource;
 import software.amazon.awssdk.endpoints.Endpoint;
 import software.amazon.awssdk.http.SdkHttpRequest;
 import software.amazon.awssdk.regions.Region;
@@ -118,6 +119,7 @@ static void teardown() {
         s3.close();
         s3Async.close();
         s3CrtAsync.close();
+
     }
 
     @BeforeEach