Skip to content

Commit 200aab1

Browse files
author
Bennett Lynch
committed
Remove unnecessary assertions
1 parent a109db6 commit 200aab1

File tree

3 files changed

+2
-4
lines changed

3 files changed

+2
-4
lines changed

core/sdk-core/src/main/java/software/amazon/awssdk/core/async/AsyncResponseTransformer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,9 +149,9 @@ static <ResponseT> AsyncResponseTransformer<ResponseT, ResponseBytes<ResponseT>>
149149
* which is an {@link SdkPublisher} that also contains a reference to the {@link SdkResponse} returned by the service.
150150
* <p>
151151
* When this transformer is used with an async client, the {@link CompletableFuture} that the client returns will be completed
152-
* once the {@link SdkResponse} is available and the response body <i>begins</i> streaming. (This behavior differs from some
152+
* once the {@link SdkResponse} is available and the response body <i>begins</i> streaming. This behavior differs from some
153153
* other transformers, like {@link #toFile(Path)} and {@link #toBytes()}, which only have their {@link CompletableFuture}
154-
* completed after the entire response body has finished streaming.)
154+
* completed after the entire response body has finished streaming.
155155
* <p>
156156
* You are responsible for subscribing to this publisher and managing the associated back-pressure. Therefore, this
157157
* transformer is only recommended for advanced use cases.

services-custom/s3-transfer-manager/src/it/java/software/amazon/awssdk/transfer/s3/S3TransferManagerDownloadIntegrationTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ public void download_toPublisher() throws Exception {
101101
.build());
102102
CompletedDownload<ResponsePublisher<GetObjectResponse>> completedDownload = download.completionFuture().join();
103103
ResponsePublisher<GetObjectResponse> responsePublisher = completedDownload.result();
104-
assertThat(responsePublisher.response().responseMetadata().requestId()).isNotNull();
105104
ByteBuffer buf = ByteBuffer.allocate(Math.toIntExact(responsePublisher.response().contentLength()));
106105
CompletableFuture<Void> drainPublisherFuture = responsePublisher.subscribe(buf::put);
107106
drainPublisherFuture.join();

services/s3/src/it/java/software/amazon/awssdk/services/s3/GetObjectAsyncIntegrationTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ public void toByteArray() throws IOException {
103103
public void toPublisher() throws IOException {
104104
ResponsePublisher<GetObjectResponse> responsePublisher =
105105
s3Async.getObject(getObjectRequest, AsyncResponseTransformer.toPublisher()).join();
106-
assertThat(responsePublisher.response().responseMetadata().requestId()).isNotNull();
107106
ByteBuffer buf = ByteBuffer.allocate(Math.toIntExact(responsePublisher.response().contentLength()));
108107
CompletableFuture<Void> drainPublisherFuture = responsePublisher.subscribe(buf::put);
109108
drainPublisherFuture.join();

0 commit comments

Comments
 (0)