Address part of the feedback

Author: zoewangg

pom.xml

@@ -98,7 +98,7 @@
         <slf4j.version>1.7.30</slf4j.version>
         <log4j.version>1.2.17</log4j.version>
         <commons.io.version>2.5</commons.io.version>
-        <equalsverifier.version>3.5</equalsverifier.version>
+        <equalsverifier.version>3.7.1</equalsverifier.version>
         <!-- Update netty-open-ssl-version accordingly whenever we update netty version-->
         <!-- https://github.com/netty/netty/blob/4.1/pom.xml search "tcnative.version" -->
         <netty.version>4.1.68.Final</netty.version>

services-custom/s3-transfer-manager/pom.xml

@@ -158,6 +158,11 @@
             <artifactId>jimfs</artifactId>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>nl.jqno.equalsverifier</groupId>
+            <artifactId>equalsverifier</artifactId>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
 
     <build>

services-custom/s3-transfer-manager/src/main/java/software/amazon/awssdk/transfer/s3/CompletedFileTransfer.java

@@ -41,7 +41,8 @@ private CompletedUploadDirectory(DefaultBuilder builder) {
     }
 
     /**
-     * Return failed uploads with error details, request metadata about each file that is failed to upload.
+     * An immutable collection of failed uploads with error details, request metadata about each file that is failed to
+     * upload.
      *
      * @return a list of failed uploads
      */
@@ -111,6 +112,10 @@ public Builder failedUploads(Collection<FailedSingleFileUpload> failedUploads) {
             return this;
         }
 
+        public Collection<FailedSingleFileUpload> getFailedUploads() {
+            return failedUploads;
+        }
+
         public void setFailedUploads(Collection<FailedSingleFileUpload> failedUploads) {
             failedUploads(failedUploads);
         }

services-custom/s3-transfer-manager/src/main/java/software/amazon/awssdk/transfer/s3/CompletedUploadDirectory.java

@@ -172,12 +172,28 @@ public Builder destination(Path destination) {
             return this;
         }
 
+        public Path getDestination() {
+            return destination;
+        }
+
+        public void setDestination(Path destination) {
+            destination(destination);
+        }
+
         @Override
         public Builder getObjectRequest(GetObjectRequest getObjectRequest) {
             this.getObjectRequest = getObjectRequest;
             return this;
         }
 
+        public GetObjectRequest getGetObjectRequest() {
+            return getObjectRequest;
+        }
+
+        public void setGetObjectRequest(GetObjectRequest getObjectRequest) {
+            getObjectRequest(getObjectRequest);
+        }
+
         @Override
         public DownloadRequest build() {
             return new DownloadRequest(this);

services-custom/s3-transfer-manager/src/main/java/software/amazon/awssdk/transfer/s3/DownloadRequest.java

@@ -113,7 +113,6 @@ private DefaultBuilder(FailedSingleFileUpload failedSingleFileUpload) {
         }
 
         private DefaultBuilder() {
-
         }
 
         @Override
@@ -122,12 +121,28 @@ public Builder exception(Throwable exception) {
             return this;
         }
 
+        public void setException(Throwable exception) {
+            exception(exception);
+        }
+
+        public Throwable getException() {
+            return exception;
+        }
+
         @Override
         public Builder request(UploadRequest request) {
             this.request = request;
             return this;
         }
 
+        public void setRequest(UploadRequest request) {
+            request(request);
+        }
+
+        public UploadRequest getRequest() {
+            return request;
+        }
+
         @Override
         public FailedSingleFileUpload build() {
             return new FailedSingleFileUpload(this);

services-custom/s3-transfer-manager/src/main/java/software/amazon/awssdk/transfer/s3/FailedSingleFileUpload.java

@@ -21,6 +21,7 @@
 import software.amazon.awssdk.annotations.SdkPublicApi;
 import software.amazon.awssdk.transfer.s3.internal.DefaultS3TransferManager;
 import software.amazon.awssdk.utils.SdkAutoCloseable;
+import software.amazon.awssdk.utils.Validate;
 
 /**
  * The S3 Transfer Manager is a library that allows users to easily and
@@ -266,6 +267,7 @@ default UploadDirectoryTransfer uploadDirectory(UploadDirectoryRequest uploadDir
      * @see UploadDirectoryOverrideConfiguration
      */
     default UploadDirectoryTransfer uploadDirectory(Consumer<UploadDirectoryRequest.Builder> requestBuilder) {
+        Validate.paramNotNull(requestBuilder, "requestBuilder");
         return uploadDirectory(UploadDirectoryRequest.builder().applyMutation(requestBuilder).build());
     }
 

services-custom/s3-transfer-manager/src/main/java/software/amazon/awssdk/transfer/s3/S3TransferManager.java

@@ -30,9 +30,9 @@
  * <p>
  * All values are optional, and not specifying them will use default values provided bt the SDK.
  *
- * <p>Use {@link #builder()} to create a set of options.</p>
+ * <p>Use {@link #builder()} to create a set of options.
+ * @see S3TransferManager.Builder#transferConfiguration(S3TransferManagerOverrideConfiguration)
  */
-
 @SdkPublicApi
 @SdkPreviewApi
 public final class S3TransferManagerOverrideConfiguration implements
@@ -102,7 +102,8 @@ public static Builder builder() {
     public interface Builder extends CopyableBuilder<Builder, S3TransferManagerOverrideConfiguration> {
 
         /**
-         * Specify the executor that will be used in {@link S3TransferManager}
+         * Specify the executor that will be used in {@link S3TransferManager} to offload
+         * execution
          *
          * @param executor the async configuration
          * @return this builder for method chaining.
@@ -159,6 +160,10 @@ public void setExecutor(Executor executor) {
             executor(executor);
         }
 
+        public Executor getExecutor() {
+            return executor;
+        }
+
         @Override
         public Builder uploadDirectoryConfiguration(UploadDirectoryOverrideConfiguration uploadDirectoryConfiguration) {
             this.uploadDirectoryConfiguration = uploadDirectoryConfiguration;
@@ -169,6 +174,10 @@ public void setUploadDirectoryConfiguration(UploadDirectoryOverrideConfiguration
             uploadDirectoryConfiguration(uploadDirectoryConfiguration);
         }
 
+        public UploadDirectoryOverrideConfiguration getUploadDirectoryConfiguration() {
+            return uploadDirectoryConfiguration;
+        }
+
         @Override
         public S3TransferManagerOverrideConfiguration build() {
             return new S3TransferManagerOverrideConfiguration(this);

services-custom/s3-transfer-manager/src/main/java/software/amazon/awssdk/transfer/s3/S3TransferManagerOverrideConfiguration.java

@@ -28,7 +28,8 @@
  * Configuration options for {@link S3TransferManager#uploadDirectory}. All values are optional, and not specifying them will
  * use the SDK default values.
  *
- * <p>Use {@link #builder()} to create a set of options.</p>
+ * <p>Use {@link #builder()} to create a set of options.
+ * @see S3TransferManager#uploadDirectory(UploadDirectoryRequest)
  */
 @SdkPublicApi
 @SdkPreviewApi
@@ -47,20 +48,23 @@ public UploadDirectoryOverrideConfiguration(DefaultBuilder builder) {
 
     /**
      * @return whether to follow symbolic links
+     * @see Builder#followSymbolicLinks(Boolean)
      */
     public Optional<Boolean> followSymbolicLinks() {
         return Optional.ofNullable(followSymbolicLinks);
     }
 
     /**
      * @return the maximum number of directory levels to traverse
+     * @see Builder#maxDepth(Integer)
      */
     public Optional<Integer> maxDepth() {
         return Optional.ofNullable(maxDepth);
     }
 
     /**
      * @return whether to recursively upload all files under the specified directory
+     * @see Builder#recursive(Boolean)
      */
     public Optional<Boolean> recursive() {
         return Optional.ofNullable(recursive);
@@ -171,6 +175,10 @@ public Builder recursive(Boolean recursive) {
             return this;
         }
 
+        public Boolean getRecursive() {
+            return recursive;
+        }
+
         public void setRecursive(Boolean recursive) {
             recursive(recursive);
         }
@@ -185,6 +193,10 @@ public void setFollowSymbolicLinks(Boolean followSymbolicLinks) {
             followSymbolicLinks(followSymbolicLinks);
         }
 
+        public Boolean getFollowSymbolicLinks() {
+            return followSymbolicLinks;
+        }
+
         @Override
         public Builder maxDepth(Integer maxDepth) {
             this.maxDepth = maxDepth;
@@ -195,6 +207,10 @@ public void setMaxDepth(Integer maxDepth) {
             maxDepth(maxDepth);
         }
 
+        public Integer getMaxDepth() {
+            return maxDepth;
+        }
+
         @Override
         public UploadDirectoryOverrideConfiguration build() {
             return new UploadDirectoryOverrideConfiguration(this);

services-custom/s3-transfer-manager/src/main/java/software/amazon/awssdk/transfer/s3/UploadDirectoryOverrideConfiguration.java

@@ -115,6 +115,9 @@ public boolean equals(Object o) {
         if (!Objects.equals(prefix, that.prefix)) {
             return false;
         }
+        if (!Objects.equals(delimiter, that.delimiter)) {
+            return false;
+        }
         return Objects.equals(overrideConfiguration, that.overrideConfiguration);
     }
 
@@ -123,6 +126,7 @@ public int hashCode() {
         int result = sourceDirectory.hashCode();
         result = 31 * result + bucket.hashCode();
         result = 31 * result + (prefix != null ? prefix.hashCode() : 0);
+        result = 31 * result + (delimiter != null ? delimiter.hashCode() : 0);
         result = 31 * result + (overrideConfiguration != null ? overrideConfiguration.hashCode() : 0);
         return result;
     }
@@ -223,30 +227,70 @@ public Builder sourceDirectory(Path sourceDirectory) {
             return this;
         }
 
+        public void setSourceDirectory(Path sourceDirectory) {
+            sourceDirectory(sourceDirectory);
+        }
+
+        public Path getSourceDirectory() {
+            return sourceDirectory;
+        }
+
         @Override
         public Builder bucket(String bucket) {
             this.bucket = bucket;
             return this;
         }
 
+        public void setBucket(String bucket) {
+            bucket(bucket);
+        }
+
+        public String getBucket() {
+            return bucket;
+        }
+
         @Override
         public Builder prefix(String prefix) {
             this.prefix = prefix;
             return this;
         }
 
+        public void setPrefix(String prefix) {
+            prefix(prefix);
+        }
+
+        public String getPrefix() {
+            return prefix;
+        }
+
         @Override
         public Builder delimiter(String delimiter) {
             this.delimiter = delimiter;
             return this;
         }
 
+        public void setDelimiter(String delimiter) {
+            delimiter(delimiter);
+        }
+
+        public String getDelimiter() {
+            return delimiter;
+        }
+
         @Override
         public Builder overrideConfiguration(UploadDirectoryOverrideConfiguration configuration) {
             this.configuration = configuration;
             return this;
         }
 
+        public void setOverrideConfiguration(UploadDirectoryOverrideConfiguration configuration) {
+            overrideConfiguration(configuration);
+        }
+
+        public UploadDirectoryOverrideConfiguration getOverrideConfiguration() {
+            return configuration;
+        }
+
         @Override
         public UploadDirectoryRequest build() {
             return new UploadDirectoryRequest(this);

services-custom/s3-transfer-manager/src/main/java/software/amazon/awssdk/transfer/s3/UploadDirectoryRequest.java

@@ -179,12 +179,28 @@ public Builder source(Path source) {
             return this;
         }
 
+        public Path getSource() {
+            return source;
+        }
+
+        public void setSource(Path source) {
+            source(source);
+        }
+
         @Override
         public Builder putObjectRequest(PutObjectRequest putObjectRequest) {
             this.putObjectRequest = putObjectRequest;
             return this;
         }
 
+        public PutObjectRequest getPutObjectRequest() {
+            return putObjectRequest;
+        }
+
+        public void setPutObjectRequest(PutObjectRequest putObjectRequest) {
+            putObjectRequest(putObjectRequest);
+        }
+
         @Override
         public UploadRequest build() {
             return new UploadRequest(this);