Skip to content

Commit 1a8d2e7

Browse files
committed
Minor fixes related to #615
- Add comment about check of autoconstruct containers - Remove unused import
1 parent 142980f commit 1a8d2e7

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

codegen/src/main/java/software/amazon/awssdk/codegen/poet/paginators/PaginatorsClassSpec.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,8 @@ protected CodeBlock hasNextPageMethodBody() {
178178
}
179179
// If there is no more_results token, then output_token will be a single value
180180
return CodeBlock.builder()
181+
// Auto construct containers are treated as null so terminate
182+
// pagination for those cases as well.
181183
.add("return $1N.$2L != null && !$3T.class.isInstance($1N.$2L) && !$4T.class.isInstance($1N.$2L)",
182184
PREVIOUS_PAGE_METHOD_ARGUMENT,
183185
fluentGetterMethodsForOutputToken().get(0),
@@ -367,4 +369,4 @@ private String getConditionalStatementforIteratorLambda(String resultKey) {
367369

368370
return conditionStatement.toString();
369371
}
370-
}
372+
}

test/dynamodbmapper-v1/src/it/java/software/amazon/awssdk/services/dynamodb/mapper/GenerateCreateTableRequestIntegrationTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import java.util.Set;
2727
import org.junit.AfterClass;
2828
import org.junit.BeforeClass;
29-
import org.junit.Ignore;
3029
import org.junit.Test;
3130
import software.amazon.awssdk.services.dynamodb.ImmutableObjectUtils;
3231
import software.amazon.awssdk.services.dynamodb.TableUtils;

0 commit comments

Comments
 (0)