Not throwing FutureCancelledException if it doesn't have executionId.

Author: zoewangg

http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/internal/FutureCancelHandler.java

@@ -51,8 +51,8 @@ public void exceptionCaught(ChannelHandlerContext ctx, Throwable e) {
 
         if (channelExecutionId == null) {
             RequestContext requestContext = ctx.channel().attr(REQUEST_CONTEXT_KEY).get();
-            LOG.debug(ctx.channel(), () -> String.format("Received a cancellation exception on a channel that doesn't have an "
-                                                         + "execution Id attached yet. Exception's execution ID is %d. "
+            LOG.warn(ctx.channel(), () -> String.format("Received a cancellation exception on a channel that doesn't have an "
+                                                         + "execution Id attached. Exception's execution ID is %d. "
                                                          + "Exception is being ignored. Closing the channel",
                                                          executionId(ctx)));
             ctx.close();

http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/internal/NettyRequestExecutor.java

@@ -42,6 +42,7 @@
 import io.netty.handler.codec.http.HttpVersion;
 import io.netty.handler.timeout.ReadTimeoutHandler;
 import io.netty.handler.timeout.WriteTimeoutHandler;
+import io.netty.util.Attribute;
 import io.netty.util.concurrent.Future;
 import io.netty.util.concurrent.GenericFutureListener;
 import io.netty.util.concurrent.Promise;
@@ -130,8 +131,9 @@ private CompletableFuture<Void> createExecutionFuture(Promise<Channel> channelPr
                 Channel ch = channelPromise.getNow();
                 try {
                     ch.eventLoop().submit(() -> {
-                        if (ch.attr(IN_USE).get()) {
-                            ch.pipeline().fireExceptionCaught(new FutureCancelledException(executionId, t));
+                        Attribute<Long> executionIdKey = ch.attr(EXECUTION_ID_KEY);
+                        if (ch.attr(IN_USE) != null && ch.attr(IN_USE).get() && executionIdKey != null) {
+                            ch.pipeline().fireExceptionCaught(new FutureCancelledException(this.executionId, t));
                         } else {
                             ch.close().addListener(closeFuture -> context.channelPool().release(ch));
                         }

http-clients/netty-nio-client/src/test/java/software/amazon/awssdk/http/nio/netty/internal/FutureCancelHandlerTest.java

@@ -25,6 +25,7 @@
 
 import io.netty.channel.Channel;
 import io.netty.channel.ChannelHandlerContext;
+import io.netty.channel.DefaultChannelId;
 import io.netty.channel.EventLoopGroup;
 import io.netty.util.DefaultAttributeMap;
 import java.io.IOException;
@@ -77,6 +78,7 @@ public void methodSetup() {
         when(ctx.channel()).thenReturn(channel);
         when(channel.attr(EXECUTION_ID_KEY)).thenReturn(attrMap.attr(EXECUTION_ID_KEY));
         when(channel.attr(REQUEST_CONTEXT_KEY)).thenReturn(attrMap.attr(REQUEST_CONTEXT_KEY));
+        when(channel.id()).thenReturn(DefaultChannelId.newInstance());
     }
 
     @Test