Skip to content

Commit 16cd5c3

Browse files
authored
Mark StsCredentialsProvider and StsCredentialsProvider.Builder as public. (#4045)
This fixes an issue where their members weren't appearing in the javadoc of subclasses, even though their members could be called.
1 parent 03fe2df commit 16cd5c3

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

services/sts/src/main/java/software/amazon/awssdk/services/sts/auth/StsCredentialsProvider.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import java.util.Optional;
2121
import java.util.function.Function;
2222
import software.amazon.awssdk.annotations.NotThreadSafe;
23-
import software.amazon.awssdk.annotations.SdkInternalApi;
23+
import software.amazon.awssdk.annotations.SdkPublicApi;
2424
import software.amazon.awssdk.annotations.ThreadSafe;
2525
import software.amazon.awssdk.auth.credentials.AwsCredentials;
2626
import software.amazon.awssdk.auth.credentials.AwsCredentialsProvider;
@@ -46,8 +46,8 @@
4646
* Users of this provider must {@link #close()} it when they are finished using it.
4747
*/
4848
@ThreadSafe
49-
@SdkInternalApi
50-
abstract class StsCredentialsProvider implements AwsCredentialsProvider, SdkAutoCloseable {
49+
@SdkPublicApi
50+
public abstract class StsCredentialsProvider implements AwsCredentialsProvider, SdkAutoCloseable {
5151

5252
private static final Duration DEFAULT_STALE_TIME = Duration.ofMinutes(1);
5353
private static final Duration DEFAULT_PREFETCH_TIME = Duration.ofMinutes(5);
@@ -66,7 +66,7 @@ abstract class StsCredentialsProvider implements AwsCredentialsProvider, SdkAuto
6666
private final Duration prefetchTime;
6767
private final Boolean asyncCredentialUpdateEnabled;
6868

69-
protected StsCredentialsProvider(BaseBuilder<?, ?> builder, String asyncThreadName) {
69+
StsCredentialsProvider(BaseBuilder<?, ?> builder, String asyncThreadName) {
7070
this.stsClient = Validate.notNull(builder.stsClient, "STS client must not be null.");
7171

7272
this.staleTime = Optional.ofNullable(builder.staleTime).orElse(DEFAULT_STALE_TIME);
@@ -123,13 +123,14 @@ public Duration prefetchTime() {
123123
/**
124124
* Implemented by a child class to call STS and get a new set of credentials to be used by this provider.
125125
*/
126-
protected abstract Credentials getUpdatedCredentials(StsClient stsClient);
126+
abstract Credentials getUpdatedCredentials(StsClient stsClient);
127127

128128
/**
129129
* Extended by child class's builders to share configuration across credential providers.
130130
*/
131131
@NotThreadSafe
132-
protected abstract static class BaseBuilder<B extends BaseBuilder<B, T>, T extends ToCopyableBuilder<B, T>>
132+
@SdkPublicApi
133+
public abstract static class BaseBuilder<B extends BaseBuilder<B, T>, T extends ToCopyableBuilder<B, T>>
133134
implements CopyableBuilder<B, T> {
134135
private final Function<B, T> providerConstructor;
135136

@@ -138,11 +139,11 @@ protected abstract static class BaseBuilder<B extends BaseBuilder<B, T>, T exten
138139
private Duration staleTime;
139140
private Duration prefetchTime;
140141

141-
protected BaseBuilder(Function<B, T> providerConstructor) {
142+
BaseBuilder(Function<B, T> providerConstructor) {
142143
this.providerConstructor = providerConstructor;
143144
}
144145

145-
public BaseBuilder(Function<B, T> providerConstructor, StsCredentialsProvider provider) {
146+
BaseBuilder(Function<B, T> providerConstructor, StsCredentialsProvider provider) {
146147
this.providerConstructor = providerConstructor;
147148
this.asyncCredentialUpdateEnabled = provider.asyncCredentialUpdateEnabled;
148149
this.stsClient = provider.stsClient;

0 commit comments

Comments
 (0)