Reduce DEBUG logging when running tests

DefaultErrorResponseHandlerTest uses LogCaptor and sets the level of the
root logger to DEBUG but never resets it; this has the effect of making
all subsequent tests be at DEBUG as well. When combined with tests that
also happens to use WireMock, which spits out a ton of debug messages,
this results in lots of unnecessary debug log statements.

This also adds a jetty-logging.properties test resource to core so that
even when we need to temporarily set the root logger to DEBUG, we don't
log anything from Jetty/WireMock.

Finally, fix some test logging configs that were too verbose.

Fixes #396

Author: dagnir

core/src/test/java/software/amazon/awssdk/core/http/DefaultErrorResponseHandlerTest.java

@@ -23,13 +23,16 @@
 import static software.amazon.awssdk.core.http.HttpResponseHandler.X_AMZN_REQUEST_ID_HEADER;
 import static software.amazon.awssdk.core.internal.http.timers.ClientExecutionAndRequestTimerTestUtils.executionContext;
 
+import java.io.IOException;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.function.Consumer;
 import org.apache.commons.lang.RandomStringUtils;
 import org.apache.log4j.Level;
 import org.apache.log4j.spi.LoggingEvent;
+import org.junit.AfterClass;
 import org.junit.Before;
+import org.junit.BeforeClass;
 import org.junit.Test;
 import software.amazon.awssdk.core.Request;
 import software.amazon.awssdk.core.util.LogCaptor;
@@ -39,12 +42,22 @@
 public class DefaultErrorResponseHandlerTest extends WireMockTestBase {
 
     private static final String RESOURCE = "/some-path";
+    private static LogCaptor logCaptor;
     private final AmazonHttpClient client = HttpTestUtils.testAmazonHttpClient();
     private final DefaultErrorResponseHandler sut = new DefaultErrorResponseHandler(new ArrayList<>());
-    private LogCaptor logCaptor = new LogCaptor.DefaultLogCaptor(Level.DEBUG);
+
+    @BeforeClass
+    public static void setup() {
+        logCaptor = new LogCaptor.DefaultLogCaptor(Level.DEBUG);
+    }
+
+    @AfterClass
+    public static void teardown() throws Exception {
+        logCaptor.close();
+    }
 
     @Before
-    public void setUp() {
+    public void methodSetup() {
         logCaptor.clear();
     }
 

core/src/test/resources/jetty-logging.properties

@@ -0,0 +1,3 @@
+# Set up logging implementation
+org.eclipse.jetty.util.log.class=org.eclipse.jetty.util.log.StdErrLog
+org.eclipse.jetty.LEVEL=INFO

services/glacier/src/test/resources/log4j.properties

@@ -1,34 +1,28 @@
-#
-# Copyright 2010-2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
-#
-# Licensed under the Apache License, Version 2.0 (the "License").
-# You may not use this file except in compliance with the License.
-# A copy of the License is located at
-#
-#  http://aws.amazon.com/apache2.0
-#
-# or in the "license" file accompanying this file. This file is distributed
-# on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
-# express or implied. See the License for the specific language governing
-# permissions and limitations under the License.
-#
-
-log4j.rootLogger=DEBUG, A1
-log4j.appender.A1=org.apache.log4j.ConsoleAppender
-log4j.appender.A1.layout=org.apache.log4j.PatternLayout
-
-# Print the date in ISO 8601 format
-log4j.appender.A1.layout.ConversionPattern=%d [%t] %-5p %c - %m%n
-
-# Adjust to see more / less logging
-log4j.logger.com.amazonaws.ec2=DEBUG
-
-# HttpClient 3 Wire Logging
-log4j.logger.httpclient.wire=WARN
-
-# HttpClient 4 Wire Logging
-log4j.logger.org.apache.http.wire=WARN
-
-log4j.logger.com.amazonaws=DEBUG
-
-
+#
+# Copyright 2010-2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License").
+# You may not use this file except in compliance with the License.
+# A copy of the License is located at
+#
+#  http://aws.amazon.com/apache2.0
+#
+# or in the "license" file accompanying this file. This file is distributed
+# on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+# express or implied. See the License for the specific language governing
+# permissions and limitations under the License.
+#
+
+log4j.rootLogger=WARN, A1
+log4j.appender.A1=org.apache.log4j.ConsoleAppender
+log4j.appender.A1.layout=org.apache.log4j.PatternLayout
+
+# Print the date in ISO 8601 format
+log4j.appender.A1.layout.ConversionPattern=%d [%t] %-5p %c - %m%n
+
+# Adjust to see more / less logging
+#log4j.logger.httpclient.wire=TRACE
+log4j.logger.com.amazonaws=DEBUG
+
+# HttpClient 4 Wire Logging
+log4j.logger.org.apache.http.wire=DEBUG