Skip to content

Commit 0878ffb

Browse files
alexw91millems
authored andcommitted
Don't leak Native CrtResources if error occurs during close
1 parent 326c0e0 commit 0878ffb

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

http-clients/aws-crt-client/src/main/java/software/amazon/awssdk/http/crt/AwsCrtAsyncHttpClient.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
import software.amazon.awssdk.http.async.SdkAsyncHttpClient;
4646
import software.amazon.awssdk.http.crt.internal.AwsCrtAsyncHttpStreamAdapter;
4747
import software.amazon.awssdk.utils.AttributeMap;
48+
import software.amazon.awssdk.utils.IoUtils;
4849
import software.amazon.awssdk.utils.Logger;
4950
import software.amazon.awssdk.utils.Validate;
5051
import software.amazon.awssdk.utils.http.SdkHttpUtils;
@@ -250,12 +251,12 @@ public CompletableFuture<Void> execute(AsyncExecuteRequest asyncRequest) {
250251
public void close() {
251252
isClosed.set(true);
252253
for (HttpConnectionPoolManager connPool : connectionPools.values()) {
253-
connPool.close();
254+
IoUtils.closeQuietly(connPool, log.logger());
254255
}
255256

256257
while (ownedSubResources.size() > 0) {
257258
CrtResource r = ownedSubResources.pop();
258-
r.close();
259+
IoUtils.closeQuietly(r, log.logger());
259260
}
260261
}
261262

0 commit comments

Comments
 (0)