Skip to content

Fallback to Logger parameters incorrect #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lloydpick opened this issue Dec 4, 2020 · 3 comments
Closed

Fallback to Logger parameters incorrect #7

lloydpick opened this issue Dec 4, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@lloydpick
Copy link

The logger fallback implementation seems to fail when using a non STDOUT or STDERR location in cold boot outside of the handler. I believe this is because the orig_initialize misses that the first 3 parameters are normal, but the remaining are named.

orig_initialize(logdev, shift_age, shift_size, level, progname,
formatter, datetime_format, binmode, shift_period_suffix)

https://github.com/ruby/logger/blob/afe0da71087d721de7107f6bee7631b8b71a2471/lib/logger.rb#L380-L382

You end up with an error like the one described in this issue - airbrake/airbrake-ruby#630

Raising this here, as I know this occurs within the Lambda environment on Ruby 2.7.

@edhzsz edhzsz added the bug Something isn't working label Dec 4, 2020
@edhzsz
Copy link
Contributor

edhzsz commented Dec 4, 2020

Hi Lloyd, thank you so much for reporting this issue.

@edhzsz edhzsz mentioned this issue Dec 7, 2020
@lloydpick
Copy link
Author

As I've just seen that there's a PR for this now 👍, once that is merged is there a rough timeframe to when the Lambda service itself will receive this fix? Obviously this repo will have it, and that can be used locally, or if I build an image and use that, but the straight lambda service. Would it be weeks, months?

@edhzsz
Copy link
Contributor

edhzsz commented Dec 9, 2020

Yes, the PR is still missing an approval, but I expect it to get it soon and release a new version of this library.
The update to the Lambda managed runtime will follow the normal deployment cadence of the Lambda Runtimes. I cannot give you an ETA for that, but I believe it is safe to measure it in weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants