Skip to content

Commit b970c2d

Browse files
committed
use a random id for client id to prevent conflicts between tests
1 parent 34734fb commit b970c2d

7 files changed

+26
-13
lines changed

test-integration/IntegrationTests/IntegrationTestAutoReconnectResubscribe.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@
3030
from TestToolLibrary.skip import Python2VersionLowerThan
3131
from TestToolLibrary.skip import Python3VersionLowerThan
3232

33+
CLIENT_ID_PUB = "integrationTestMQTT_ClientPub" + "".join(random.choice(string.ascii_lowercase) for i in range(4))
34+
CLIENT_ID_SUB = "integrationTestMQTT_ClientSub" + "".join(random.choice(string.ascii_lowercase) for i in range(4))
3335

3436
# Callback unit
3537
class callbackUnit:
@@ -148,9 +150,9 @@ def threadBRuntime(self, pyCoreClient, callback):
148150

149151
# Init Python core and connect
150152
myMQTTClientManager = MQTTClientManager.MQTTClientManager()
151-
clientPub = myMQTTClientManager.create_connected_mqtt_core("integrationTestMQTT_ClientPub", host, rootCA,
153+
clientPub = myMQTTClientManager.create_connected_mqtt_core(CLIENT_ID_PUB, host, rootCA,
152154
certificate, privateKey, mode=mode)
153-
clientSub = myMQTTClientManager.create_connected_mqtt_core("integrationTestMQTT_ClientSub", host, rootCA,
155+
clientSub = myMQTTClientManager.create_connected_mqtt_core(CLIENT_ID_SUB, host, rootCA,
154156
certificate, privateKey, mode=mode)
155157

156158
if clientPub is None or clientSub is None:

test-integration/IntegrationTests/IntegrationTestConfigurablePublishMessageQueueing.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@
3838
from TestToolLibrary.skip import Python2VersionLowerThan
3939
from TestToolLibrary.skip import Python3VersionLowerThan
4040

41+
CLIENT_ID_PUB = "integrationTestMQTT_ClientPub" + "".join(random.choice(string.ascii_lowercase) for i in range(4))
42+
CLIENT_ID_SUB = "integrationTestMQTT_ClientSub" + "".join(random.choice(string.ascii_lowercase) for i in range(4))
4143

4244
# Class that implements the publishing thread: Thread A, with network failure
4345
# This thread will publish 3 messages first, and then keep publishing
@@ -287,9 +289,9 @@ def performConfigurableOfflinePublishQueueTest(clientPub, clientSub):
287289

288290
# Init Python core and connect
289291
myMQTTClientManager = MQTTClientManager.MQTTClientManager()
290-
clientPub = myMQTTClientManager.create_connected_mqtt_core("integrationTestMQTT_ClientPub", host, rootCA,
292+
clientPub = myMQTTClientManager.create_connected_mqtt_core(CLIENT_ID_PUB, host, rootCA,
291293
certificate, privateKey, mode=mode)
292-
clientSub = myMQTTClientManager.create_connected_mqtt_core("integrationTestMQTT_ClientSub", host, rootCA,
294+
clientSub = myMQTTClientManager.create_connected_mqtt_core(CLIENT_ID_SUB, host, rootCA,
293295
certificate, privateKey, mode=mode)
294296

295297
if clientPub is None or clientSub is None:

test-integration/IntegrationTests/IntegrationTestJobsClient.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
import json
3838

3939
IOT_JOBS_MQTT_RESPONSE_WAIT_SECONDS = 5
40+
CLIENT_ID = "integrationTestMQTT_Client" + "".join(random.choice(string.ascii_lowercase) for i in range(4))
4041

4142
class JobsMessageProcessor(object):
4243
def __init__(self, awsIoTMQTTThingJobsClient, clientToken):
@@ -168,7 +169,7 @@ def _test_send_response_confirm(self, sendResult):
168169

169170
# Init Python core and connect
170171
myMQTTClientManager = MQTTClientManager.MQTTClientManager()
171-
client = myMQTTClientManager.create_connected_mqtt_client(mode, "integrationTestJobs_Client", host, (rootCA, certificate, privateKey))
172+
client = myMQTTClientManager.create_connected_mqtt_client(mode, CLIENT_ID, host, (rootCA, certificate, privateKey))
172173

173174
clientId = 'AWSPythonkSDKTestThingClient'
174175
thingName = 'AWSPythonkSDKTestThing'

test-integration/IntegrationTests/IntegrationTestMQTTConnection.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@
3030
API_TYPE_SYNC = "sync"
3131
API_TYPE_ASYNC = "async"
3232

33+
CLIENT_ID_PUB = "integrationTestMQTT_ClientPub" + "".join(random.choice(string.ascii_lowercase) for i in range(4))
34+
CLIENT_ID_SUB = "integrationTestMQTT_ClientSub" + "".join(random.choice(string.ascii_lowercase) for i in range(4))
35+
36+
3337

3438
# Callback unit for subscribe
3539
class callbackUnit:
@@ -95,9 +99,9 @@ def _performPublish(self, pyCoreClient, topic, qos, payload):
9599

96100
# Init Python core and connect
97101
myMQTTClientManager = MQTTClientManager.MQTTClientManager()
98-
clientPub = myMQTTClientManager.create_connected_mqtt_core("integrationTestMQTT_ClientPub", host, rootCA,
102+
clientPub = myMQTTClientManager.create_connected_mqtt_core(CLIENT_ID_PUB, host, rootCA,
99103
certificate, privateKey, mode=mode)
100-
clientSub = myMQTTClientManager.create_connected_mqtt_core("integrationTestMQTT_ClientSub", host, rootCA,
104+
clientSub = myMQTTClientManager.create_connected_mqtt_core(CLIENT_ID_SUB, host, rootCA,
101105
certificate, privateKey, mode=mode)
102106

103107
if clientPub is None or clientSub is None:

test-integration/IntegrationTests/IntegrationTestOfflineQueueingForSubscribeUnsubscribe.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ def get_random_string(length):
5151
ROOT_CA = "./test-integration/Credentials/rootCA.crt"
5252
CERT = "./test-integration/Credentials/certificate.pem.crt"
5353
KEY = "./test-integration/Credentials/privateKey.pem.key"
54-
CLIENT_PUB_ID = "PySdkIntegTest_OfflineSubUnsub_pub"
55-
CLIENT_SUB_UNSUB_ID = "PySdkIntegTest_OfflineSubUnsub_subunsub"
54+
CLIENT_PUB_ID = "PySdkIntegTest_OfflineSubUnsub_pub" + get_random_string(4)
55+
CLIENT_SUB_UNSUB_ID = "PySdkIntegTest_OfflineSubUnsub_subunsub" + get_random_string(4)
5656
KEEP_ALIVE_SEC = 1
5757
EVENT_WAIT_TIME_OUT_SEC = 5
5858

test-integration/IntegrationTests/IntegrationTestProgressiveBackoff.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,8 @@
4343
from TestToolLibrary.skip import Python2VersionLowerThan
4444
from TestToolLibrary.skip import Python3VersionLowerThan
4545

46+
CLIENT_ID_PUB = "integrationTestMQTT_ClientPub" + "".join(random.choice(string.ascii_lowercase) for i in range(4))
47+
CLIENT_ID_SUB = "integrationTestMQTT_ClientSub" + "".join(random.choice(string.ascii_lowercase) for i in range(4))
4648

4749
# Class that implements all the related threads in the test in a controllable manner
4850
class threadPool:
@@ -234,9 +236,9 @@ def verifyBackoffTime(answerList, resultList):
234236

235237
# Init Python core and connect
236238
myMQTTClientManager = MQTTClientManager.MQTTClientManager()
237-
clientPub = myMQTTClientManager.create_connected_mqtt_core("integrationTestMQTT_ClientPub", host, rootCA,
239+
clientPub = myMQTTClientManager.create_connected_mqtt_core(CLIENT_ID_PUB, host, rootCA,
238240
certificate, privateKey, mode=mode)
239-
clientSub = myMQTTClientManager.create_connected_mqtt_core("integrationTestMQTT_ClientSub", host, rootCA,
241+
clientSub = myMQTTClientManager.create_connected_mqtt_core(CLIENT_ID_SUB, host, rootCA,
240242
certificate, privateKey, mode=mode)
241243

242244
if clientPub is None or clientSub is None:

test-integration/IntegrationTests/IntegrationTestShadow.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@
3939

4040
# Global configuration
4141
TPS = 1 # Update speed, Spectre does not tolerate high TPS shadow operations...
42+
CLIENT_ID_PUB = "integrationTestMQTT_ClientPub" + "".join(random.choice(string.ascii_lowercase) for i in range(4))
43+
CLIENT_ID_SUB = "integrationTestMQTT_ClientSub" + "".join(random.choice(string.ascii_lowercase) for i in range(4))
4244

4345

4446
# Class that manages the generation and chopping of the random string
@@ -163,9 +165,9 @@ def randomString(lengthOfString):
163165

164166
# Init Python core and connect
165167
myMQTTClientManager = MQTTClientManager.MQTTClientManager()
166-
clientPub = myMQTTClientManager.create_connected_mqtt_core("integrationTestMQTT_ClientPub", host, rootCA,
168+
clientPub = myMQTTClientManager.create_connected_mqtt_core(CLIENT_ID_PUB, host, rootCA,
167169
certificate, privateKey, mode=mode)
168-
clientSub = myMQTTClientManager.create_connected_mqtt_core("integrationTestMQTT_ClientSub", host, rootCA,
170+
clientSub = myMQTTClientManager.create_connected_mqtt_core(CLIENT_ID_SUB, host, rootCA,
169171
certificate, privateKey, mode=mode)
170172

171173
if clientPub is None or clientSub is None:

0 commit comments

Comments
 (0)