Skip to content

Delta doesn't contain client_token #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apetitdev opened this issue Jun 23, 2022 · 3 comments
Closed

Delta doesn't contain client_token #328

apetitdev opened this issue Jun 23, 2022 · 3 comments
Labels
bug This issue is a bug. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 2 days.

Comments

@apetitdev
Copy link

Describe the bug

If we follow AWS documentation about /delta response state document
https://docs.aws.amazon.com/iot/latest/developerguide/device-shadow-document.html#device-shadow-example-response-json-delta
the client token should be in the response.

this is pretty important to know if an update was successfully made or not in one of your device.

I have made a PR already to make AWS team aware of it
#258

But half year after still no changes, I know you guys are probably quite busy at doing great job but this is a fairly simple change and sound pretty important to me.
We have thousands of connected devices and it will help a lot.

Thank you again for you good job..

Expected Behavior

https://docs.aws.amazon.com/iot/latest/developerguide/device-shadow-document.html#device-shadow-example-response-json-delta
the client token should be in the response.

Current Behavior

https://docs.aws.amazon.com/iot/latest/developerguide/device-shadow-document.html#device-shadow-example-response-json-delta
the client token isn't in the response.

Reproduction Steps

Any delta on any plateform

Possible Solution

https://github.com/aws/aws-iot-device-sdk-python-v2/pull/258/files

Additional Information/Context

No response

SDK version used

1.11.2

Environment details (OS name and version, etc.)

ubuntu 20.04

@apetitdev apetitdev added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jun 23, 2022
@TwistedTwigleg
Copy link
Contributor

TwistedTwigleg commented Jun 23, 2022

Thank you for creating this issue!

Client Token support was added to the Shadow model in this commit, which should be in version 1.11.2: #310. Are you not seeing a ClientToken in your shadow updates?

@jmklix jmklix added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 2 days. and removed needs-triage This issue or PR still needs to be triaged. labels Jun 23, 2022
@apetitdev
Copy link
Author

@TwistedTwigleg apologies I was still on older version. The last version works fine shadowDeltaUpdatedEvent class has client_token.
Thank you!

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 2 days.
Projects
None yet
Development

No branches or pull requests

3 participants