Skip to content

Caching CMM max age should be required to be greater than 0 #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mattsb42-aws opened this issue Apr 17, 2019 · 1 comment
Closed

Caching CMM max age should be required to be greater than 0 #147

mattsb42-aws opened this issue Apr 17, 2019 · 1 comment
Labels
bug

Comments

@mattsb42-aws
Copy link
Member

mattsb42-aws commented Apr 17, 2019 •
edited
Loading

The caching CMM should require that max_age is greater than 0.

If initialized with a max_age value that is not greater than 0, we should raise a ValueError with an appropriate error message similar to the checks we already apply:

https://github.com/aws/aws-encryption-sdk-python/blob/master/src/aws_encryption_sdk/materials_managers/caching.py#L98-L109
@caitlin-tibbetts caitlin-tibbetts mentioned this issue Jul 19, 2019
Merged
@mattsb42-aws
Copy link
Member Author

This is published in v1.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattsb42-aws