Skip to content

Commit d2b79c9

Browse files
fix cb
1 parent 7cb5864 commit d2b79c9

File tree

2 files changed

+22
-19
lines changed

2 files changed

+22
-19
lines changed

src/aws_encryption_sdk/materials_managers/mpl/cmm.py

+6-3
Original file line numberDiff line numberDiff line change
@@ -78,18 +78,21 @@ def get_encryption_materials(
7878
def _native_to_mpl_get_encryption_materials(
7979
request: EncryptionMaterialsRequest
8080
) -> 'MPL_GetEncryptionMaterialsInput':
81-
commitment_policy = CryptoMaterialsManagerFromMPL._native_to_mpl_commmitment_policy(
81+
commitment_policy = CryptoMaterialsManagerFromMPL._native_to_mpl_commitment_policy(
8282
request.commitment_policy
8383
)
8484
output: MPL_GetEncryptionMaterialsInput = MPL_GetEncryptionMaterialsInput(
8585
encryption_context=request.encryption_context,
8686
commitment_policy=commitment_policy,
87+
algorithm_suite_id=CryptoMaterialsManagerFromMPL._native_algorithm_id_to_mpl_algorithm_id(
88+
request.algorithm.algorithm_id
89+
),
8790
max_plaintext_length=request.plaintext_length,
8891
)
8992
return output
9093

9194
@staticmethod
92-
def _native_to_mpl_commmitment_policy(
95+
def _native_to_mpl_commitment_policy(
9396
native_commitment_policy: CommitmentPolicy
9497
) -> 'MPL_CommitmentPolicyESDK':
9598
if native_commitment_policy == CommitmentPolicy.FORBID_ENCRYPT_ALLOW_DECRYPT:
@@ -138,7 +141,7 @@ def _create_mpl_decrypt_materials_input_from_request(
138141
algorithm_suite_id=CryptoMaterialsManagerFromMPL._native_algorithm_id_to_mpl_algorithm_id(
139142
request.algorithm.algorithm_id
140143
),
141-
commitment_policy=CryptoMaterialsManagerFromMPL._native_to_mpl_commmitment_policy(
144+
commitment_policy=CryptoMaterialsManagerFromMPL._native_to_mpl_commitment_policy(
142145
request.commitment_policy
143146
),
144147
encrypted_data_keys=list_edks,

test/mpl/unit/test_material_managers_mpl_cmm.py

+16-16
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ def test_GIVEN_valid_request_WHEN_get_encryption_materials_THEN_return_Encryptio
9797

9898

9999
@patch("aws_encryption_sdk.materials_managers.mpl.cmm.CryptoMaterialsManagerFromMPL"
100-
"._native_to_mpl_commmitment_policy")
100+
"._native_to_mpl_commitment_policy")
101101
def test_GIVEN_mpl_cmm_raises_MPLException_WHEN_get_encryption_materials_THEN_raise_ESDKException(
102102
_
103103
):
@@ -112,7 +112,7 @@ def test_GIVEN_mpl_cmm_raises_MPLException_WHEN_get_encryption_materials_THEN_ra
112112

113113

114114
@patch("aws_encryption_sdk.materials_managers.mpl.cmm.CryptoMaterialsManagerFromMPL"
115-
"._native_to_mpl_commmitment_policy")
115+
"._native_to_mpl_commitment_policy")
116116
def test_GIVEN_valid_mpl_commitment_policy_WHEN_native_to_mpl_get_encryption_materials_THEN_returns_MPL_GetEncryptionMaterialsInput( # noqa: E501
117117
mock_mpl_commitment_policy
118118
):
@@ -132,50 +132,50 @@ def test_GIVEN_valid_mpl_commitment_policy_WHEN_native_to_mpl_get_encryption_mat
132132
assert output.max_plaintext_length == mock_encryption_materials_request.plaintext_length
133133

134134

135-
def test_GIVEN_CommitmentPolicy_FORBID_ENCRYPT_ALLOW_DECRYPT_WHEN_native_to_mpl_commmitment_policy_THEN_returns_MPL_CommitmentPolicyESDK_FORBID_ENCRYPT_ALLOW_DECRYPT(): # noqa: E501
135+
def test_GIVEN_CommitmentPolicy_FORBID_ENCRYPT_ALLOW_DECRYPT_WHEN_native_to_mpl_commitment_policy_THEN_returns_MPL_CommitmentPolicyESDK_FORBID_ENCRYPT_ALLOW_DECRYPT(): # noqa: E501
136136
# Given: native FORBID_ENCRYPT_ALLOW_DECRYPT
137137
native_commitment_policy = CommitmentPolicy.FORBID_ENCRYPT_ALLOW_DECRYPT
138138

139-
# When: _native_to_mpl_commmitment_policy
140-
output = CryptoMaterialsManagerFromMPL._native_to_mpl_commmitment_policy(native_commitment_policy)
139+
# When: _native_to_mpl_commitment_policy
140+
output = CryptoMaterialsManagerFromMPL._native_to_mpl_commitment_policy(native_commitment_policy)
141141

142142
# Then: Returns MPL FORBID_ENCRYPT_ALLOW_DECRYPT
143143
assert isinstance(output, MPL_CommitmentPolicyESDK)
144144
assert output.value == "FORBID_ENCRYPT_ALLOW_DECRYPT"
145145

146146

147-
def test_GIVEN_CommitmentPolicy_REQUIRE_ENCRYPT_ALLOW_DECRYPT_WHEN_native_to_mpl_commmitment_policy_THEN_returns_MPL_CommitmentPolicyESDK_REQUIRE_ENCRYPT_ALLOW_DECRYPT(): # noqa: E501
147+
def test_GIVEN_CommitmentPolicy_REQUIRE_ENCRYPT_ALLOW_DECRYPT_WHEN_native_to_mpl_commitment_policy_THEN_returns_MPL_CommitmentPolicyESDK_REQUIRE_ENCRYPT_ALLOW_DECRYPT(): # noqa: E501
148148
# Given: native REQUIRE_ENCRYPT_ALLOW_DECRYPT
149149
native_commitment_policy = CommitmentPolicy.REQUIRE_ENCRYPT_ALLOW_DECRYPT
150150

151-
# When: _native_to_mpl_commmitment_policy
152-
output = CryptoMaterialsManagerFromMPL._native_to_mpl_commmitment_policy(native_commitment_policy)
151+
# When: _native_to_mpl_commitment_policy
152+
output = CryptoMaterialsManagerFromMPL._native_to_mpl_commitment_policy(native_commitment_policy)
153153

154154
# Then: Returns MPL REQUIRE_ENCRYPT_ALLOW_DECRYPT
155155
assert isinstance(output, MPL_CommitmentPolicyESDK)
156156
assert output.value == "REQUIRE_ENCRYPT_ALLOW_DECRYPT"
157157

158158

159-
def test_GIVEN_CommitmentPolicy_REQUIRE_ENCRYPT_REQUIRE_DECRYPT_WHEN_native_to_mpl_commmitment_policy_THEN_returns_MPL_CommitmentPolicyESDK_REQUIRE_ENCRYPT_REQUIRE_DECRYPT(): # noqa: E501
159+
def test_GIVEN_CommitmentPolicy_REQUIRE_ENCRYPT_REQUIRE_DECRYPT_WHEN_native_to_mpl_commitment_policy_THEN_returns_MPL_CommitmentPolicyESDK_REQUIRE_ENCRYPT_REQUIRE_DECRYPT(): # noqa: E501
160160
# Given: native REQUIRE_ENCRYPT_REQUIRE_DECRYPT
161161
native_commitment_policy = CommitmentPolicy.REQUIRE_ENCRYPT_REQUIRE_DECRYPT
162162

163-
# When: _native_to_mpl_commmitment_policy
164-
output = CryptoMaterialsManagerFromMPL._native_to_mpl_commmitment_policy(native_commitment_policy)
163+
# When: _native_to_mpl_commitment_policy
164+
output = CryptoMaterialsManagerFromMPL._native_to_mpl_commitment_policy(native_commitment_policy)
165165

166166
# Then: Returns MPL REQUIRE_ENCRYPT_REQUIRE_DECRYPT
167167
assert isinstance(output, MPL_CommitmentPolicyESDK)
168168
assert output.value == "REQUIRE_ENCRYPT_REQUIRE_DECRYPT"
169169

170170

171-
def test_GIVEN_CommitmentPolicy_unrecognized_WHEN_native_to_mpl_commmitment_policy_THEN_raise_ValueError():
171+
def test_GIVEN_CommitmentPolicy_unrecognized_WHEN_native_to_mpl_commitment_policy_THEN_raise_ValueError():
172172
# Given: invalid native commitment policy
173173
native_commitment_policy = "not a commitment policy"
174174

175175
# Then: Raises ValueError
176176
with pytest.raises(ValueError):
177-
# When: _native_to_mpl_commmitment_policy
178-
CryptoMaterialsManagerFromMPL._native_to_mpl_commmitment_policy(native_commitment_policy)
177+
# When: _native_to_mpl_commitment_policy
178+
CryptoMaterialsManagerFromMPL._native_to_mpl_commitment_policy(native_commitment_policy)
179179

180180

181181
@patch.object(mock_mpl_cmm, "decrypt_materials")
@@ -239,7 +239,7 @@ def test_GIVEN_valid_native_algorithm_id_WHEN_native_algorithm_id_to_mpl_algorit
239239
@patch("aws_encryption_sdk.materials_managers.mpl.cmm.CryptoMaterialsManagerFromMPL"
240240
"._native_algorithm_id_to_mpl_algorithm_id")
241241
@patch("aws_encryption_sdk.materials_managers.mpl.cmm.CryptoMaterialsManagerFromMPL"
242-
"._native_to_mpl_commmitment_policy")
242+
"._native_to_mpl_commitment_policy")
243243
def test_GIVEN_valid_request_WHEN_create_mpl_decrypt_materials_input_from_request_THEN_returns_MPL_MPL_DecryptMaterialsInput( # noqa: E501
244244
mock_mpl_commitment_policy,
245245
mock_mpl_algorithm_id,
@@ -248,7 +248,7 @@ def test_GIVEN_valid_request_WHEN_create_mpl_decrypt_materials_input_from_reques
248248
mock_algorithm_id = "0x1234" # Some fake algorithm ID that fits the format
249249
mock_mpl_algorithm_id.return_value = mock_algorithm_id
250250

251-
# Given: _native_to_mpl_commmitment_policy returns some MPL commitment policy
251+
# Given: _native_to_mpl_commitment_policy returns some MPL commitment policy
252252
mock_commitment_policy = MagicMock(__class__=MPL_CommitmentPolicyESDK)
253253
mock_mpl_commitment_policy.return_value = mock_commitment_policy
254254

0 commit comments

Comments
 (0)