Skip to content

Commit 8c9d4b1

Browse files
committed
fix: unit tests for _native_algorithm_id_to_mpl_algorithm_id
1 parent 324f683 commit 8c9d4b1

File tree

2 files changed

+19
-4
lines changed

2 files changed

+19
-4
lines changed

src/aws_encryption_sdk/materials_managers/mpl/cmm.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,9 @@ def _native_to_mpl_get_encryption_materials(
8787
}
8888

8989
if request.algorithm is not None:
90-
output_kwargs["algorithm_suite_id"] = CryptoMaterialsManagerFromMPL._native_algorithm_id_to_mpl_algorithm_id(
91-
request.algorithm.algorithm_id
90+
output_kwargs["algorithm_suite_id"] = \
91+
CryptoMaterialsManagerFromMPL._native_algorithm_id_to_mpl_algorithm_id(
92+
request.algorithm.algorithm_id
9293
)
9394

9495
return MPL_GetEncryptionMaterialsInput(**output_kwargs)

test/mpl/unit/test_material_managers_mpl_cmm.py

+16-2
Original file line numberDiff line numberDiff line change
@@ -96,11 +96,18 @@ def test_GIVEN_valid_request_WHEN_get_encryption_materials_THEN_return_Encryptio
9696
mock_mpl_cmm.get_encryption_materials.assert_called_once_with(mock_get_encryption_materials_input)
9797

9898

99+
@patch("aws_encryption_sdk.materials_managers.mpl.cmm.CryptoMaterialsManagerFromMPL"
100+
"._native_algorithm_id_to_mpl_algorithm_id")
99101
@patch("aws_encryption_sdk.materials_managers.mpl.cmm.CryptoMaterialsManagerFromMPL"
100102
"._native_to_mpl_commitment_policy")
101103
def test_GIVEN_mpl_cmm_raises_MPLException_WHEN_get_encryption_materials_THEN_raise_ESDKException(
102-
_
104+
_,
105+
mock_mpl_algorithm_id,
103106
):
107+
# Given: _native_algorithm_id_to_mpl_algorithm_id returns a valid MPL algorithm ID
108+
mock_algorithm_id = "0x1234" # Some fake algorithm ID that fits the format
109+
mock_mpl_algorithm_id.return_value = mock_algorithm_id
110+
104111
# Then: Raises AWSEncryptionSDKClientError
105112
with pytest.raises(AWSEncryptionSDKClientError):
106113
# Given: mpl_cmm.get_encryption_materials raises MPL exception
@@ -111,11 +118,18 @@ def test_GIVEN_mpl_cmm_raises_MPLException_WHEN_get_encryption_materials_THEN_ra
111118
cmm.get_encryption_materials(mock_encryption_materials_request)
112119

113120

121+
@patch("aws_encryption_sdk.materials_managers.mpl.cmm.CryptoMaterialsManagerFromMPL"
122+
"._native_algorithm_id_to_mpl_algorithm_id")
114123
@patch("aws_encryption_sdk.materials_managers.mpl.cmm.CryptoMaterialsManagerFromMPL"
115124
"._native_to_mpl_commitment_policy")
116125
def test_GIVEN_valid_mpl_commitment_policy_WHEN_native_to_mpl_get_encryption_materials_THEN_returns_MPL_GetEncryptionMaterialsInput( # noqa: E501
117-
mock_mpl_commitment_policy
126+
mock_mpl_commitment_policy,
127+
mock_mpl_algorithm_id,
118128
):
129+
# Given: _native_algorithm_id_to_mpl_algorithm_id returns a valid MPL algorithm ID
130+
mock_algorithm_id = "0x1234" # Some fake algorithm ID that fits the format
131+
mock_mpl_algorithm_id.return_value = mock_algorithm_id
132+
119133
# Given: commitment policy is some MPL ESDK commitment policy
120134
mock_commitment_policy = MagicMock(__class__=MPL_CommitmentPolicyESDK)
121135
mock_mpl_commitment_policy.return_value = mock_commitment_policy

0 commit comments

Comments
 (0)