From 6ffab0351682c434f9127bdd811ab797f0814d84 Mon Sep 17 00:00:00 2001 From: Ryan Emery Date: Wed, 6 Nov 2019 14:44:23 -0800 Subject: [PATCH] fix: Import declaration conflicts with local declaration resolves #232 Typescript 3.7 does a better job identifying declaration conflicts and so identifies the conflict between the type and the class import of the same name. e.g. `WebCryptoEncryptionMaterial` is defined as a type and imported. When #148 was written the reference to the return type should have gone directly to the needed Material (WebCrypto or Node). --- .../src/browser_cryptographic_materials_manager.ts | 3 --- .../src/node_cryptographic_materials_manager.ts | 3 --- 2 files changed, 6 deletions(-) diff --git a/modules/material-management-browser/src/browser_cryptographic_materials_manager.ts b/modules/material-management-browser/src/browser_cryptographic_materials_manager.ts index 6f56c2165..ec7677b67 100644 --- a/modules/material-management-browser/src/browser_cryptographic_materials_manager.ts +++ b/modules/material-management-browser/src/browser_cryptographic_materials_manager.ts @@ -16,7 +16,6 @@ import { WebCryptoMaterialsManager, EncryptionRequest, // eslint-disable-line no-unused-vars DecryptionRequest, EncryptionContext, // eslint-disable-line no-unused-vars - EncryptionMaterial, DecryptionMaterial, // eslint-disable-line no-unused-vars WebCryptoAlgorithmSuite, WebCryptoEncryptionMaterial, WebCryptoDecryptionMaterial, SignatureKey, needs, readOnlyProperty, VerificationKey, AlgorithmSuiteIdentifier, immutableBaseClass, @@ -29,8 +28,6 @@ import { fromBase64, toBase64 } from '@aws-sdk/util-base64-browser' export type WebCryptoEncryptionRequest = EncryptionRequest export type WebCryptoDecryptionRequest = DecryptionRequest -export type WebCryptoEncryptionMaterial = EncryptionMaterial -export type WebCryptoDecryptionMaterial = DecryptionMaterial export type WebCryptoGetEncryptionMaterials = GetEncryptionMaterials export type WebCryptoGetDecryptMaterials = GetDecryptMaterials diff --git a/modules/material-management-node/src/node_cryptographic_materials_manager.ts b/modules/material-management-node/src/node_cryptographic_materials_manager.ts index 9d79fc7b5..984705c4c 100644 --- a/modules/material-management-node/src/node_cryptographic_materials_manager.ts +++ b/modules/material-management-node/src/node_cryptographic_materials_manager.ts @@ -15,7 +15,6 @@ import { NodeMaterialsManager, EncryptionRequest, DecryptionRequest, EncryptionContext, // eslint-disable-line no-unused-vars - EncryptionMaterial, DecryptionMaterial, // eslint-disable-line no-unused-vars NodeAlgorithmSuite, NodeEncryptionMaterial, NodeDecryptionMaterial, SignatureKey, needs, VerificationKey, AlgorithmSuiteIdentifier, immutableClass, readOnlyProperty, KeyringNode, @@ -28,8 +27,6 @@ import { createECDH } from 'crypto' export type NodeEncryptionRequest = EncryptionRequest export type NodeDecryptionRequest = DecryptionRequest -export type NodeEncryptionMaterial = EncryptionMaterial -export type NodeDecryptionMaterial = DecryptionMaterial export type NodeGetEncryptionMaterials = GetEncryptionMaterials export type NodeGetDecryptMaterials = GetDecryptMaterials