fix: updating readElement to match underlying data structure #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The readElement function was previously not taking advantage of the underlying data structure, which is a sequence of elements, each of which is a sequence of fields. This resulted in several superfluous calls to built-in functions (e.g. Array.prototype.splice). This commit adds an additional parameter to readElement, which is the number of fields per element, and adapts the code accordingly. The return of readElement is now an array of arrays, which simplifies its manipulation by the two caller functions.
seebees
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readElement function was previously not taking advantage of
the underlying data structure, which is a sequence of elements,
each of which is a sequence of fields. This resulted in several
superfluous calls to built-in functions (e.g. Array.prototype.splice).
This commit adds an additional parameter to readElement, which is
the number of fields per element, and adapts the code accordingly.
The return of readElement is now an array of arrays, which simplifies
its manipulation by the two caller functions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: