Skip to content

Support for AWS SDK 3 KMS client #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PhilLavoie opened this issue May 17, 2022 · 6 comments
Closed

Support for AWS SDK 3 KMS client #916

PhilLavoie opened this issue May 17, 2022 · 6 comments

Comments

@PhilLavoie
Copy link

Problem:

The current KmsKeyringNode keyring implementation only supports the old style AWS SDK 2 client, or it isn't clear how to make it work with the client from v3. I'm assuming it's the same for the browser implementation.

Solution:

Either distribute a @aws-crypto/kms-keyring-v3 that we can use with the existing buildClient() function, or make it easy and document how to implement KmsKeyringXXX with a v3 client. As it stands currently, the KmsKeyringNode prevents this by its type declaration:

declare const KmsKeyringNode_base: import("@aws-crypto/kms-keyring").KmsKeyRingConstructible<NodeAlgorithmSuite, KMS>;
export declare class KmsKeyringNode extends KmsKeyringNode_base {
    constructor({ clientProvider, keyIds, generatorKeyId, grantTokens, discovery, }?: KmsKeyringNodeInput);
}

Where KMS refers to the v2 client.

Thanks!

@dbartholomae
Copy link

This would also be helpful to be able to use this with AWS SSO, since SDK v2 did not have full support for that yet.

@seebees
Copy link
Contributor

seebees commented Nov 1, 2022

This will be fixed with #1043
It does not remove the v2 dependency, that will require a major version change

@brianfrantz
Copy link

Is there an ETA on pushing this out? (Looks like the PR is ready to go?)

I'm blocked as it isn't picking up my SSO config. @dbartholomae Do you know of any workarounds to getting SSO to work?

@dbartholomae
Copy link

@brianfrantz For me, SSO works with the newest version. I assume that it was backported to the AWS SDK client version 2 at some point.

@brianfrantz
Copy link

Thanks - you gave me hope to keep looking. Turns out I was missing AWS_SDK_LOAD_CONFIG=1 in my environment. Looks like it works now.

@texastony
Copy link
Contributor

@PhilLavoie & @dbartholomae
We have released AWS SKD V3 support in ESDK-JS 3.2.0.
Note: The ESDK-JS still lists the AWS SDK V2 as a dependency.
We will release a new major version that removes this V2 dependency
as a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants