-
Notifications
You must be signed in to change notification settings - Fork 63
Support for AWS SDK 3 KMS client #916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This would also be helpful to be able to use this with AWS SSO, since SDK v2 did not have full support for that yet. |
This will be fixed with #1043 |
Is there an ETA on pushing this out? (Looks like the PR is ready to go?) I'm blocked as it isn't picking up my SSO config. @dbartholomae Do you know of any workarounds to getting SSO to work? |
@brianfrantz For me, SSO works with the newest version. I assume that it was backported to the AWS SDK client version 2 at some point. |
Thanks - you gave me hope to keep looking. Turns out I was missing |
@PhilLavoie & @dbartholomae |
Problem:
The current KmsKeyringNode keyring implementation only supports the old style AWS SDK 2 client, or it isn't clear how to make it work with the client from v3. I'm assuming it's the same for the browser implementation.
Solution:
Either distribute a @aws-crypto/kms-keyring-v3 that we can use with the existing
buildClient()
function, or make it easy and document how to implementKmsKeyringXXX
with a v3 client. As it stands currently, the KmsKeyringNode prevents this by its type declaration:Where
KMS
refers to the v2 client.Thanks!
The text was updated successfully, but these errors were encountered: