Skip to content

Commit dab43a0

Browse files
authored
fix: integration-browser error condition (#308)
`spawnSync` does not throw when getting a error exit code. `status` needs to be investigated. Also, `@trust/keyto` was removed from dependencies. This error was not noticed because of the above problem.
1 parent e20e178 commit dab43a0

File tree

3 files changed

+1038
-413
lines changed

3 files changed

+1038
-413
lines changed

modules/integration-browser/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
"@aws-sdk/karma-credential-loader": "1.0.0-alpha.6",
2020
"@aws-sdk/util-base64-browser": "1.0.0-beta.2",
2121
"@aws-sdk/util-utf8-browser": "1.0.0-beta.2",
22+
"@trust/keyto": "^1.0.1",
2223
"@types/got": "^9.6.9",
2324
"@types/stream-to-promise": "^2.2.0",
2425
"@types/yargs": "^15.0.3",

modules/integration-browser/src/cli.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -99,10 +99,12 @@ if (!existsSync(fixtures)) {
9999
}
100100

101101
if (karma) {
102-
spawnSync('npm', ['run', 'karma'], {
102+
const { status } = spawnSync('npm', ['run', 'karma'], {
103103
cwd: __dirname,
104104
stdio: 'inherit'
105105
})
106+
/* Forward the status to the parent. */
107+
process.exit(status || 0)
106108
}
107109
})(cli.argv)
108110
.catch(err => {

0 commit comments

Comments
 (0)