lint and tests

Author: seebees

modules/branch-keystore-node/src/branch_keystore.ts

@@ -319,7 +319,7 @@ export class BranchKeyStoreNode implements IBranchKeyStoreNode {
       'MUST supply a string branch key id'
     )
     needs(
-      branchKeyVersion && typeof branchKeyVersion === 'string,
+      branchKeyVersion && typeof branchKeyVersion === 'string',
       'MUST supply a string branch key version'
     )
 

modules/branch-keystore-node/src/dynamodb_key_storage.ts

@@ -60,7 +60,7 @@ export class DynamoDBKeyStorage implements IBranchKeyStorage {
       typeof logicalKeyStoreName === 'string',
       'Logical Key Store name must be a string'
     )
-needs(logicalKeyStoreName, 'Logical Key Store name required')
+    needs(logicalKeyStoreName, 'Logical Key Store name required')
     /* Precondition: DDB client must be a DynamoDBClient */
     needs(
       ddbClient instanceof DynamoDBClient,
@@ -155,9 +155,9 @@ needs(logicalKeyStoreName, 'Logical Key Store name required')
     //= aws-encryption-sdk-specification/framework/key-store/dynamodb-key-storage.md#getencryptedbranchkeyversion
     //# The returned EncryptedHierarchicalKey MUST have the same identifier as the input.
     needs(
-       encrypted.branchKeyId == branchKeyId,
-       'Unexpected branch key id. Expected ${branchKeyId}, found ${encrypted.branchKeyId}'
-   )
+      encrypted.branchKeyId == branchKeyId,
+      'Unexpected branch key id. Expected ${branchKeyId}, found ${encrypted.branchKeyId}'
+    )
 
     //= aws-encryption-sdk-specification/framework/key-store/dynamodb-key-storage.md#getencryptedbranchkeyversion
     //# The returned EncryptedHierarchicalKey MUST have the same version as the input.

modules/branch-keystore-node/test/branch_keystore.test.ts

@@ -480,7 +480,7 @@ describe('Test Branch keystore', () => {
             logicalKeyStoreName: '',
             kmsConfiguration: KMS_CONFIGURATION,
           })
-      ).to.throw('Logical Keystore name required')
+      ).to.throw('Logical Key Store name required')
     })
 
     describe('Test proper init', () => {
@@ -696,7 +696,7 @@ describe('Test Branch keystore', () => {
     void (await expect(
       keyStore.getActiveBranchKey('Robbie')
     ).to.be.rejectedWith(
-      `A branch key record with ${PARTITION_KEY}=Robbie and ${SORT_KEY}=${BRANCH_KEY_ACTIVE_TYPE} was not found in DynamoDB`
+      `A branch key record with ${PARTITION_KEY}=Robbie and ${SORT_KEY}=${BRANCH_KEY_ACTIVE_TYPE} was not found in the DynamoDB table ${DDB_TABLE_NAME}.`
     ))
   })
 

modules/branch-keystore-node/test/branch_keystore_helpers.test.ts

@@ -40,9 +40,7 @@ import {
   SORT_KEY,
 } from '../src/constants'
 import { DynamoDBKeyStorage } from '../src/dynamodb_key_storage'
-import {
-  EncryptedHierarchicalKey,
-} from '../src/types'
+import { EncryptedHierarchicalKey } from '../src/types'
 
 const VALID_CUSTOM_ENCRYPTION_CONTEXT_KV_PAIRS = {
   'aws-crypto-ec:key1': 'value 1',
@@ -116,7 +114,7 @@ describe('Test keystore helpers', () => {
           BRANCH_KEY_ACTIVE_TYPE
         )
       ).to.rejectedWith(
-        `A branch key record with ${PARTITION_KEY}=${nonexistentBranchKeyId} and ${SORT_KEY}=${BRANCH_KEY_ACTIVE_TYPE} was not found in DynamoDB`
+        `A branch key record with ${PARTITION_KEY}=${nonexistentBranchKeyId} and ${SORT_KEY}=${BRANCH_KEY_ACTIVE_TYPE} was not found in the DynamoDB table ${DDB_TABLE_NAME}.`
       ))
 
       void (await expect(
@@ -126,7 +124,7 @@ describe('Test keystore helpers', () => {
           VERSION_BRANCH_KEY[TYPE_FIELD]
         )
       ).to.be.rejectedWith(
-        `A branch key record with ${PARTITION_KEY}=${nonexistentBranchKeyId} and ${SORT_KEY}=${VERSION_BRANCH_KEY[TYPE_FIELD]} was not found in DynamoDB`
+        `A branch key record with ${PARTITION_KEY}=${nonexistentBranchKeyId} and ${SORT_KEY}=${VERSION_BRANCH_KEY[TYPE_FIELD]} was not found in the DynamoDB table ${DDB_TABLE_NAME}.`
       ))
     })
 
@@ -137,7 +135,7 @@ describe('Test keystore helpers', () => {
       void (await expect(
         getBranchKeyItem(BRANCH_KEY_STORAGE, BRANCH_KEY_ID, nonexistentType)
       ).to.be.rejectedWith(
-        `A branch key record with ${PARTITION_KEY}=${BRANCH_KEY_ID} and ${SORT_KEY}=${nonexistentType} was not found in DynamoDB`
+        `A branch key record with ${PARTITION_KEY}=${BRANCH_KEY_ID} and ${SORT_KEY}=${nonexistentType} was not found in the DynamoDB table ${DDB_TABLE_NAME}.`
       ))
     })
   })

modules/kdf-ctr-mode-node/src/kdfctr.ts

@@ -37,7 +37,6 @@ export function kdfCounterMode({
   purpose,
   expectedLength,
 }: KdfCtrInput): Buffer {
-
   /* Precondition: the ikm must be 32, 48, 66 bytes long */
   needs(
     SUPPORTED_IKM_LENGTHS.includes(ikm.length),