lint

Author: seebees

modules/branch-keystore-node/src/branch_keystore.ts

@@ -393,7 +393,7 @@ export class BranchKeyStoreNode implements IBranchKeyStoreNode {
       //# by calling [GetKeyStorageInfo](./key-store/key-storage.md#getkeystorageinfo).
       keystoreTableName: this.storage.getKeyStorageInfo().name,
       logicalKeyStoreName: this.logicalKeyStoreName,
-      grantTokens: !!this.grantTokens ? this.grantTokens.slice() : [],
+      grantTokens: this.grantTokens ? this.grantTokens.slice() : [],
       kmsConfiguration: this.kmsConfiguration._config,
     }
   }

modules/branch-keystore-node/test/branch_keystore.test.ts

@@ -102,7 +102,9 @@ describe('Test Branch keystore', () => {
               logicalKeyStoreName: LOGICAL_KEYSTORE_NAME,
               kmsConfiguration: kmsConfiguration as any,
             })
-        ).to.throw(/Unexpected config shape|Config must be a `discovery` or an object./)
+        ).to.throw(
+          /Unexpected config shape|Config must be a `discovery` or an object./
+        )
       }
     })
 
@@ -193,7 +195,7 @@ describe('Test Branch keystore', () => {
         return new BranchKeyStoreNode({
           storage: { ddbTableName: DDB_TABLE_NAME, ddbClient },
           logicalKeyStoreName: LOGICAL_KEYSTORE_NAME,
-          kmsConfiguration: { identifier: KEY_ID},
+          kmsConfiguration: { identifier: KEY_ID },
           keyManagement: { kmsClient },
         })
       }).to.throw(

modules/branch-keystore-node/test/kms_config.test.ts

@@ -25,7 +25,6 @@ export const WELL_FORMED_MRK_ALIAS_ARN =
   'arn:aws:kms:us-west-2:123456789012:alias/mrk/my-mrk-alias'
 
 describe('Test KmsKeyConfig class', () => {
-
   it('Precondition: config must be a string or object', () => {
     for (const config of [null, undefined, 0]) {
       expect(() => supplySrkKmsConfig(config as any)).to.throw(
@@ -35,10 +34,10 @@ describe('Test KmsKeyConfig class', () => {
   })
   it('Precondition: ARN must be a string', () => {
     for (const arn of [null, undefined, 0, {}]) {
-      expect(() => supplySrkKmsConfig({identifier: arn} as any)).to.throw(
+      expect(() => supplySrkKmsConfig({ identifier: arn } as any)).to.throw(
         'ARN must be a string'
       )
-      expect(() => supplySrkKmsConfig({mrkIdentifier: arn} as any)).to.throw(
+      expect(() => supplySrkKmsConfig({ mrkIdentifier: arn } as any)).to.throw(
         'ARN must be a string'
       )
     }

modules/caching-materials-manager-node/src/caching_materials_manager_node.ts

@@ -70,4 +70,4 @@ export class NodeCachingMaterialsManager
 //= aws-encryption-sdk-specification/framework/aws-kms/aws-kms-hierarchical-keyring.md#appendix-a-cache-entry-identifier-formulas
 //# When accessing the underlying cryptographic materials cache,
 //# the hierarchical keyring MUST use the formulas specified in this appendix
-//# in order to compute the [cache entry identifier](../cryptographic-materials-cache.md#cache-identifier).
+//# in order to compute the [cache entry identifier](../cryptographic-materials-cache.md#cache-identifier).

modules/kms-keyring-node/src/kms_hkeyring_node_helpers.ts

@@ -86,14 +86,14 @@ export function getCacheEntryId(
   // get branch key id as a byte array
   const branchKeyIdAsBytes = stringToUtf8Bytes(branchKeyId)
 
-  var entryInfo
+  let entryInfo
   //= aws-encryption-sdk-specification/framework/aws-kms/aws-kms-hierarchical-keyring.md#resource-suffix
   //# The aforementioned 4 definitions ([Resource Identifier](#resource-identifier),
   //# [Scope Identifier](#scope-identifier), [Partition ID](#partition-id-1), and
   //# [Resource Suffix](#resource-suffix)) MUST be appended together with the null byte, 0x00,
   //# and the SHA384 of the result should be taken as the final cache identifier.
 
-  if (!!versionAsBytes) {
+  if (versionAsBytes) {
     //= aws-encryption-sdk-specification/framework/aws-kms/aws-kms-hierarchical-keyring.md#decryption-materials
     //# When the hierarchical keyring receives an OnDecrypt request,
     //# it MUST calculate the cache entry identifier as the

modules/kms-keyring-node/test/fixtures.ts

@@ -1,9 +1,7 @@
 // Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
 
-import {
-  BranchKeyStoreNode,
-} from '@aws-crypto/branch-keystore-node'
+import { BranchKeyStoreNode } from '@aws-crypto/branch-keystore-node'
 import {
   AlgorithmSuiteIdentifier,
   EncryptionContext,
@@ -26,7 +24,7 @@ export const TEST_ESDK_ALG_SUITE = new NodeAlgorithmSuite(
 )
 export const TTL = 1 * 60000 * 10
 export const KEYSTORE = new BranchKeyStoreNode({
-  storage: {ddbTableName: DDB_TABLE_NAME},
+  storage: { ddbTableName: DDB_TABLE_NAME },
   logicalKeyStoreName: LOGICAL_KEYSTORE_NAME,
   kmsConfiguration: { identifier: KEY_ARN },
 })

modules/kms-keyring-node/test/kms_hkeyring_node.constructor.test.ts

@@ -1,9 +1,7 @@
 // Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
 
-import {
-  BranchKeyStoreNode,
-} from '@aws-crypto/branch-keystore-node'
+import { BranchKeyStoreNode } from '@aws-crypto/branch-keystore-node'
 import {
   DDB_TABLE_NAME,
   LOGICAL_KEYSTORE_NAME,
@@ -26,7 +24,7 @@ const branchKeyId = BRANCH_KEY_ID
 const cacheLimitTtl = TTL
 const maxCacheSize = 1000
 const keyStore = new BranchKeyStoreNode({
-  storage: {ddbTableName: DDB_TABLE_NAME},
+  storage: { ddbTableName: DDB_TABLE_NAME },
   logicalKeyStoreName: LOGICAL_KEYSTORE_NAME,
   kmsConfiguration: { identifier: KEY_ARN },
 })

modules/kms-keyring-node/test/kms_hkeyring_node.edk-order.test.ts

@@ -35,7 +35,10 @@ import {
   testOnDecryptError,
   testOnEncrypt,
 } from './kms_hkeyring_node.test'
-import { BranchKeyStoreNode, KeyStoreInfoOutput } from '@aws-crypto/branch-keystore-node'
+import {
+  BranchKeyStoreNode,
+  KeyStoreInfoOutput,
+} from '@aws-crypto/branch-keystore-node'
 chai.use(chaiAsPromised)
 
 // an edk that can't even be destructured according to any alg suite
@@ -146,14 +149,14 @@ describe('KmsHierarchicalKeyRingNode: decrypt EDK order', () => {
       }
     })
 
-    keyStore.getKeyStoreInfo.callsFake(function(): KeyStoreInfoOutput {
+    keyStore.getKeyStoreInfo.callsFake(function (): KeyStoreInfoOutput {
       return {
-        keystoreId: "keyStoreId",
-        keystoreTableName: "keystoreTableName",
-        logicalKeyStoreName: "logicalKeyStoreName",
+        keystoreId: 'keyStoreId',
+        keystoreTableName: 'keystoreTableName',
+        logicalKeyStoreName: 'logicalKeyStoreName',
         grantTokens: [],
         // This is not used by any tests
-        kmsConfiguration: null as any
+        kmsConfiguration: null as any,
       }
     })
   })

modules/kms-keyring-node/test/kms_hkeyring_node.ondecrypt.test.ts

@@ -34,7 +34,10 @@ import { expect } from 'chai'
 import Sinon from 'sinon'
 import { KMSClient } from '@aws-sdk/client-kms'
 import { DynamoDBClient } from '@aws-sdk/client-dynamodb'
-import { BranchKeyStoreNode, KeyStoreInfoOutput } from '@aws-crypto/branch-keystore-node'
+import {
+  BranchKeyStoreNode,
+  KeyStoreInfoOutput,
+} from '@aws-crypto/branch-keystore-node'
 
 const branchKeyIdA = BRANCH_KEY_ID_A
 const branchKeyIdB = BRANCH_KEY_ID_B
@@ -130,14 +133,14 @@ describe('KmsHierarchicalKeyRingNode: onDecrypt', () => {
       }
     })
 
-    keyStore.getKeyStoreInfo.callsFake(function(): KeyStoreInfoOutput {
+    keyStore.getKeyStoreInfo.callsFake(function (): KeyStoreInfoOutput {
       return {
-        keystoreId: "keyStoreId",
-        keystoreTableName: "keystoreTableName",
-        logicalKeyStoreName: "logicalKeyStoreName",
+        keystoreId: 'keyStoreId',
+        keystoreTableName: 'keystoreTableName',
+        logicalKeyStoreName: 'logicalKeyStoreName',
         grantTokens: [],
         // This is not used by any tests
-        kmsConfiguration: null as any
+        kmsConfiguration: null as any,
       }
     })
   })
@@ -595,7 +598,7 @@ describe('KmsHierarchicalKeyRingNode: onDecrypt', () => {
 
     it('CMC evictions occur due to capacity', async () => {
       const maxCacheSize = 1
-      
+
       const hkr = new KmsHierarchicalKeyRingNode({
         branchKeyIdSupplier,
         keyStore,

modules/kms-keyring-node/test/kms_hkeyring_node.onencrypt.test.ts

@@ -28,7 +28,10 @@ import {
   testOnEncrypt,
   testOnEncryptError,
 } from './kms_hkeyring_node.test'
-import { BranchKeyStoreNode, KeyStoreInfoOutput } from '@aws-crypto/branch-keystore-node'
+import {
+  BranchKeyStoreNode,
+  KeyStoreInfoOutput,
+} from '@aws-crypto/branch-keystore-node'
 chai.use(chaiAsPromised)
 
 const branchKeyIdA = BRANCH_KEY_ID_A
@@ -85,14 +88,14 @@ describe('KmsHierarchicalKeyRingNode: onEncrypt', () => {
       }
     })
 
-    keyStore.getKeyStoreInfo.callsFake(function(): KeyStoreInfoOutput {
+    keyStore.getKeyStoreInfo.callsFake(function (): KeyStoreInfoOutput {
       return {
-        keystoreId: "keyStoreId",
-        keystoreTableName: "keystoreTableName",
-        logicalKeyStoreName: "logicalKeyStoreName",
+        keystoreId: 'keyStoreId',
+        keystoreTableName: 'keystoreTableName',
+        logicalKeyStoreName: 'logicalKeyStoreName',
         grantTokens: [],
         // This is not used by any tests
-        kmsConfiguration: null as any
+        kmsConfiguration: null as any,
       }
     })
   })