Skip to content

Readme example uses deprecated functions #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ewanmellor opened this issue Nov 18, 2021 · 5 comments
Closed

Readme example uses deprecated functions #419

ewanmellor opened this issue Nov 18, 2021 · 5 comments

Comments

@ewanmellor
Copy link

Problem:

The example code in the Getting Started section of the readme uses AwsCrypto.encryptString and AwsCrypto.decryptString, which are deprecated.
@josecorella josecorella mentioned this issue Nov 23, 2021
Merged
1 task
@josecorella
Copy link
Contributor

Hi @ewanmellor 👋!

Thank you for bringing this to our attention. We have opened a PR, #423 updating the README with the latest methods.

Best,

@josecorella
Copy link
Contributor

PR has been merged in 😁

@scottkennedy
Copy link

You replaced crypto.decryptString(prov, ciphertext); with crypto.decryptData(prov, ciphertext);, which as far as I can tell, was also deprecated.

@ewanmellor
Copy link
Author

@scottkennedy Not in 2021 it wasn't.

@scottkennedy
Copy link

Sorry, didn't realize the age of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@scottkennedy @ewanmellor @josecorella