Skip to content

Chore: Audit Dependencies #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
texastony opened this issue Dec 8, 2023 · 1 comment
Closed

Chore: Audit Dependencies #1892

texastony opened this issue Dec 8, 2023 · 1 comment

Comments

@texastony
Copy link
Contributor

texastony commented Dec 8, 2023

Problem:

A number of dependencies were added as optional test dependencies that are actually transitive compile and runtime dependencies.

<dependency>
<groupId>software.amazon.smithy.dafny</groupId>
<artifactId>conversion</artifactId>
<version>0.1</version>
<optional>true</optional>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.dafny</groupId>
<artifactId>DafnyRuntime</artifactId>
<version>4.2.0</version>
<optional>true</optional>
<scope>test</scope>
</dependency>

Additionally, if the ESDK-Java only depends on BC for ASN1 serialization, BC now offers an ASN1 utils library that should be smaller than the cryptographic package currently depended on.

Solution:

  1. Remove the Dafny related dependencies that are already added to the compile and run class paths.

  2. Try the BC utils package.

@imabhichow
Copy link
Contributor

imabhichow commented Feb 2, 2024

  1. We removed the Dafny-related dependencies that were already in the compile and runtime class paths.
  2. There are still a few ASN1 classes that we use in ESDK-Java that have not been included in the bcutils-jdk18on package. In addition, ESDK-Java also utilizes the org.bouncycastle.util.encoders.Base64 class, which has not been included in the BC Utils package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants