Skip to content

Use the jdk18on variant of Bouncy Castle #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skagedal opened this issue Mar 22, 2023 · 3 comments
Closed

Use the jdk18on variant of Bouncy Castle #1472

skagedal opened this issue Mar 22, 2023 · 3 comments
Labels
pending release Code is merged but has not been pushed to Maven.

Comments

@skagedal
Copy link

The Bouncy Castle lib comes in different variants depending on JDK version. Currently, AWS encryption SDK includes a dependency on org.bouncycastle:bcprov-ext-jdk15on, which is to be read as "JDK 1.5 and forward", not "JDK 15 and forward".

This artifact however seems to have stopped getting releases; the latest version 1.72 does not exist for the jdk15on variant. Instead, there is a jdk18on variant. This should be safe to depend on, since Java 8 (a.k.a Java 1.8) is already a requirement for the AWS encryption SDK.

Our project recently ran into confusing build conflicts that we were unable to resolve without excluding the transitive dependency. This is a difficult problem to really solve, but it seems to me that defaulting on the jdk18on variant would be a better option.

@kessplas
Copy link

Hey @skagedal, thanks for reaching out. We have addressed this issue in #1572. Please stand by for a minor version release.

@skagedal
Copy link
Author

Nice!

@kessplas kessplas added the pending release Code is merged but has not been pushed to Maven. label Aug 3, 2023
@lavaleri
Copy link
Contributor

This update is now available in our 2.4.1 release. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending release Code is merged but has not been pushed to Maven.
Projects
None yet
Development

No branches or pull requests

3 participants