chore: address all pylint issues aside from TODO references

Author: mattsb42-aws

setup.py

@@ -23,7 +23,7 @@ def get_version():
 def get_requirements():
     """Reads the requirements file."""
     requirements = read("requirements.txt")
-    return [r for r in requirements.strip().splitlines()]
+    return requirements.strip().splitlines()
 
 
 setup(

src/dynamodb_encryption_sdk/encrypted/item.py

@@ -171,7 +171,7 @@ def decrypt_dynamodb_item(item, crypto_config):
     :rtype: dict
     """
     unique_actions = set([crypto_config.attribute_actions.default_action.name])
-    unique_actions.update(set([action.name for action in crypto_config.attribute_actions.attribute_actions.values()]))
+    unique_actions.update({action.name for action in crypto_config.attribute_actions.attribute_actions.values()})
 
     if crypto_config.attribute_actions.take_no_actions:
         # If we explicitly have been told not to do anything to this item, just copy it.

src/dynamodb_encryption_sdk/encrypted/resource.py

@@ -41,7 +41,7 @@
 
 @attr.s(init=False)
 class EncryptedTablesCollectionManager(object):
-    # pylint: disable=too-few-public-methods
+    # pylint: disable=too-few-public-methods,too-many-instance-attributes
     """Tables collection manager that provides :class:`EncryptedTable` objects.
 
     https://boto3.readthedocs.io/en/latest/reference/services/dynamodb.html#DynamoDB.ServiceResource.tables
@@ -119,7 +119,7 @@ def _transform_table(self, method, **kwargs):
 
 @attr.s(init=False)
 class EncryptedResource(object):
-    # pylint: disable=too-few-public-methods
+    # pylint: disable=too-few-public-methods,too-many-instance-attributes
     """High-level helper class to provide a familiar interface to encrypted tables.
 
     >>> import boto3

src/dynamodb_encryption_sdk/encrypted/table.py

@@ -42,7 +42,7 @@
 
 @attr.s(init=False)
 class EncryptedTable(object):
-    # pylint: disable=too-few-public-methods
+    # pylint: disable=too-few-public-methods,too-many-instance-attributes
     """High-level helper class to provide a familiar interface to encrypted tables.
 
     >>> import boto3

src/dynamodb_encryption_sdk/identifiers.py

@@ -35,12 +35,12 @@ def __gt__(self, other):
     def __lt__(self, other):
         # type: (CryptoAction) -> bool
         """Define CryptoAction equality."""
-        return self.value < other.value
+        return self.value < other.value  # pylint: disable=comparison-with-callable
 
     def __eq__(self, other):
         # type: (CryptoAction) -> bool
         """Define CryptoAction equality."""
-        return self.value == other.value
+        return self.value == other.value  # pylint: disable=comparison-with-callable
 
 
 class EncryptionKeyType(Enum):

src/dynamodb_encryption_sdk/internal/crypto/authentication.py

@@ -56,7 +56,8 @@ def sign_item(encrypted_item, signing_key, crypto_config):
             attribute_actions=crypto_config.attribute_actions,
         ),
     )
-    return {Tag.BINARY.dynamodb_tag: signature}
+    # for some reason pylint can't follow the Enum member attributes
+    return {Tag.BINARY.dynamodb_tag: signature}  # pylint: disable=no-member
 
 
 def verify_item_signature(signature_attribute, encrypted_item, verification_key, crypto_config):
@@ -68,7 +69,8 @@ def verify_item_signature(signature_attribute, encrypted_item, verification_key,
     :param DelegatedKey verification_key: DelegatedKey to use to calculate the signature
     :param CryptoConfig crypto_config: Cryptographic configuration
     """
-    signature = signature_attribute[Tag.BINARY.dynamodb_tag]
+    # for some reason pylint can't follow the Enum member attributes
+    signature = signature_attribute[Tag.BINARY.dynamodb_tag]  # pylint: disable=no-member
     verification_key.verify(
         algorithm=verification_key.algorithm,
         signature=signature,
@@ -98,10 +100,11 @@ def _string_to_sign(item, table_name, attribute_actions):
 
         data_to_sign.extend(_hash_data(hasher=hasher, data=key.encode(TEXT_ENCODING)))
 
+        # for some reason pylint can't follow the Enum member attributes
         if action is CryptoAction.SIGN_ONLY:
-            data_to_sign.extend(SignatureValues.PLAINTEXT.sha256)
+            data_to_sign.extend(SignatureValues.PLAINTEXT.sha256)  # pylint: disable=no-member
         else:
-            data_to_sign.extend(SignatureValues.ENCRYPTED.sha256)
+            data_to_sign.extend(SignatureValues.ENCRYPTED.sha256)  # pylint: disable=no-member
 
         data_to_sign.extend(_hash_data(hasher=hasher, data=serialize_attribute(item[key])))
     return bytes(data_to_sign)

src/dynamodb_encryption_sdk/internal/crypto/encryption.py

@@ -47,7 +47,8 @@ def encrypt_attribute(attribute_name, attribute, encryption_key, algorithm):
     encrypted_attribute = encryption_key.encrypt(
         algorithm=algorithm, name=attribute_name, plaintext=serialized_attribute
     )
-    return {Tag.BINARY.dynamodb_tag: encrypted_attribute}
+    # for some reason pylint can't follow the Enum member attributes
+    return {Tag.BINARY.dynamodb_tag: encrypted_attribute}  # pylint: disable=no-member
 
 
 def decrypt_attribute(attribute_name, attribute, decryption_key, algorithm):
@@ -61,7 +62,8 @@ def decrypt_attribute(attribute_name, attribute, decryption_key, algorithm):
     :returns: Plaintext DynamoDB attribute
     :rtype: dict
     """
-    encrypted_attribute = attribute[Tag.BINARY.dynamodb_tag]
+    # for some reason pylint can't follow the Enum member attributes
+    encrypted_attribute = attribute[Tag.BINARY.dynamodb_tag]  # pylint: disable=no-member
     decrypted_attribute = decryption_key.decrypt(
         algorithm=algorithm, name=attribute_name, ciphertext=encrypted_attribute
     )

src/dynamodb_encryption_sdk/internal/crypto/jce_bridge/authentication.py

@@ -139,7 +139,7 @@ def load_key(self, key, key_type, key_encoding):
             raise ValueError("Key type must be symmetric and encoding must be raw.")
 
         if len(key) * 8 < MinimumKeySizes.HMAC.value:
-            _LOGGER.warning("HMAC keys smaller than %d bits are unsafe" % MinimumKeySizes.HMAC.value)
+            _LOGGER.warning("HMAC keys smaller than %d bits are unsafe", MinimumKeySizes.HMAC.value)
 
         return key
 

src/dynamodb_encryption_sdk/internal/crypto/jce_bridge/primitives.py

@@ -121,8 +121,7 @@ class SimplePadding(JavaPadding):
     java_name = attr.ib(validator=attr.validators.instance_of(six.string_types))
     padding = attr.ib(validator=callable_validator)
 
-    def __init__(self, java_name, padding):  # type: Text  # type: Callable  # noqa=D107
-        # type: (...) -> None
+    def __init__(self, java_name, padding):  # type: (Text, Callable) -> None  # noqa=D107
         # Workaround pending resolution of attrs/mypy interaction.
         # https://github.com/python/mypy/issues/2088
         # https://github.com/python-attrs/attrs/issues/215
@@ -148,8 +147,7 @@ class BlockSizePadding(JavaPadding):
     java_name = attr.ib(validator=attr.validators.instance_of(six.string_types))
     padding = attr.ib(validator=callable_validator)
 
-    def __init__(self, java_name, padding):  # type: Text  # type: Callable  # noqa=D107
-        # type: (...) -> None
+    def __init__(self, java_name, padding):  # type: (Text, Callable) -> None  # noqa=D107
         # Workaround pending resolution of attrs/mypy interaction.
         # https://github.com/python/mypy/issues/2088
         # https://github.com/python-attrs/attrs/issues/215
@@ -227,8 +225,7 @@ class JavaMode(object):
     java_name = attr.ib(validator=attr.validators.instance_of(six.string_types))
     mode = attr.ib(validator=callable_validator)
 
-    def __init__(self, java_name, mode):  # type: Text  # type: Callable  # noqa=D107
-        # type: (...) -> None
+    def __init__(self, java_name, mode):  # type: (Text, Callable) -> None  # noqa=D107
         # Workaround pending resolution of attrs/mypy interaction.
         # https://github.com/python/mypy/issues/2088
         # https://github.com/python-attrs/attrs/issues/215
@@ -256,8 +253,7 @@ class JavaEncryptionAlgorithm(object):
     java_name = attr.ib(validator=attr.validators.instance_of(six.string_types))
     cipher = attr.ib()
 
-    def __init__(self, java_name, cipher):  # type: Text  # type: Callable  # noqa=D107
-        # type: (...) -> None
+    def __init__(self, java_name, cipher):  # type: (Text, Callable) -> None  # noqa=D107
         # Workaround pending resolution of attrs/mypy interaction.
         # https://github.com/python/mypy/issues/2088
         # https://github.com/python-attrs/attrs/issues/215
@@ -455,7 +451,7 @@ def load_rsa_key(key, key_type, key_encoding):
     loaded_key = loader(**kwargs)
 
     if loaded_key.key_size < MinimumKeySizes.RSA.value:
-        _LOGGER.warning("RSA keys smaller than %d bits are unsafe" % MinimumKeySizes.RSA.value)
+        _LOGGER.warning("RSA keys smaller than %d bits are unsafe", MinimumKeySizes.RSA.value)
 
     return loaded_key
 

src/dynamodb_encryption_sdk/internal/dynamodb_types.py

@@ -4,6 +4,7 @@
     No guarantee is provided on the modules and APIs within this
     namespace staying consistent. Directly reference at your own risk.
 """
+# constant naming for types so pylint: disable=invalid-name
 try:  # Python 3.5.0 and 3.5.1 have incompatible typing modules
     from typing import Any, AnyStr, ByteString, Dict, List, Text
 

src/dynamodb_encryption_sdk/internal/formatting/deserialize/attribute.py

@@ -65,6 +65,8 @@ def _transform_binary_value(value):
 
     def _deserialize_binary(stream):
         # type: (io.BytesIO) -> Dict[Text, bytes]
+        # pylint: disable=no-member
+        # for some reason pylint can't follow the Enum member attributes
         """Deserializes a binary object.
 
         :param stream: Stream containing serialized object
@@ -85,6 +87,8 @@ def _transform_string_value(value):
 
     def _deserialize_string(stream):
         # type: (io.BytesIO) -> Dict[Text, dynamodb_types.STRING]
+        # pylint: disable=no-member
+        # for some reason pylint can't follow the Enum member attributes
         """Deserializes a string object.
 
         :param stream: Stream containing serialized object
@@ -107,6 +111,8 @@ def _transform_number_value(value):
 
     def _deserialize_number(stream):
         # type: (io.BytesIO) -> Dict[Text, dynamodb_types.STRING]
+        # pylint: disable=no-member
+        # for some reason pylint can't follow the Enum member attributes
         """Deserializes a number object.
 
         :param stream: Stream containing serialized object
@@ -120,6 +126,8 @@ def _deserialize_number(stream):
 
     def _deserialize_boolean(stream):
         # type: (io.BytesIO) -> Dict[Text, dynamodb_types.BOOLEAN]
+        # pylint: disable=no-member
+        # for some reason pylint can't follow the Enum member attributes
         """Deserializes a boolean object.
 
         :param stream: Stream containing serialized object
@@ -131,6 +139,8 @@ def _deserialize_boolean(stream):
 
     def _deserialize_null(stream):  # we want a consistent API but don't use stream, so pylint: disable=unused-argument
         # type: (io.BytesIO) -> Dict[Text, dynamodb_types.BOOLEAN]
+        # pylint: disable=no-member
+        # for some reason pylint can't follow the Enum member attributes
         """Deserializes a null object.
 
         :param stream: Stream containing serialized object
@@ -152,6 +162,8 @@ def _deserialize_set(stream, member_transform):
 
     def _deserialize_binary_set(stream):
         # type: (io.BytesIO) -> Dict[Text, dynamodb_types.SET[dynamodb_types.BINARY]]
+        # pylint: disable=no-member
+        # for some reason pylint can't follow the Enum member attributes
         """Deserializes a binary set object.
 
         :param stream: Stream containing serialized object
@@ -162,6 +174,8 @@ def _deserialize_binary_set(stream):
 
     def _deserialize_string_set(stream):
         # type: (io.BytesIO) -> Dict[Text, dynamodb_types.SET[dynamodb_types.STRING]]
+        # pylint: disable=no-member
+        # for some reason pylint can't follow the Enum member attributes
         """Deserializes a string set object.
 
         :param stream: Stream containing serialized object
@@ -172,6 +186,8 @@ def _deserialize_string_set(stream):
 
     def _deserialize_number_set(stream):
         # type: (io.BytesIO) -> Dict[Text, dynamodb_types.SET[dynamodb_types.STRING]]
+        # pylint: disable=no-member
+        # for some reason pylint can't follow the Enum member attributes
         """Deserializes a number set object.
 
         :param stream: Stream containing serialized object
@@ -182,6 +198,8 @@ def _deserialize_number_set(stream):
 
     def _deserialize_list(stream):
         # type: (io.BytesIO) -> Dict[Text, dynamodb_types.LIST]
+        # pylint: disable=no-member
+        # for some reason pylint can't follow the Enum member attributes
         """Deserializes a list object.
 
         :param stream: Stream containing serialized object
@@ -199,19 +217,20 @@ def _deserialize_map(stream):
         :type stream: io.BytesIO
         :rtype: dict
         """
+        # for some reason pylint can't follow the Enum member attributes
         member_count = decode_length(stream)
         members = {}  # type: dynamodb_types.MAP
         for _ in range(member_count):
             key = _deserialize(stream)
-            if Tag.STRING.dynamodb_tag not in key:
+            if Tag.STRING.dynamodb_tag not in key:  # pylint: disable=no-member
                 raise DeserializationError(
                     'Malformed serialized map: found "{}" as map key.'.format(list(key.keys())[0])
                 )
 
             value = _deserialize(stream)
-            members[key[Tag.STRING.dynamodb_tag]] = value
+            members[key[Tag.STRING.dynamodb_tag]] = value  # pylint: disable=no-member
 
-        return {Tag.MAP.dynamodb_tag: members}
+        return {Tag.MAP.dynamodb_tag: members}  # pylint: disable=no-member
 
     def _deserialize_function(tag):
         # type: (bytes) -> Callable
@@ -221,17 +240,18 @@ def _deserialize_function(tag):
         :type tag: dynamodb_encryption_sdk.internal.identifiers.Tag
         :rtype: callable
         """
+        # for some reason pylint can't follow the Enum member attributes
         deserialize_functions = {
-            Tag.BINARY.tag: _deserialize_binary,
-            Tag.BINARY_SET.tag: _deserialize_binary_set,
-            Tag.NUMBER.tag: _deserialize_number,
-            Tag.NUMBER_SET.tag: _deserialize_number_set,
-            Tag.STRING.tag: _deserialize_string,
-            Tag.STRING_SET.tag: _deserialize_string_set,
-            Tag.BOOLEAN.tag: _deserialize_boolean,
-            Tag.NULL.tag: _deserialize_null,
-            Tag.LIST.tag: _deserialize_list,
-            Tag.MAP.tag: _deserialize_map,
+            Tag.BINARY.tag: _deserialize_binary,  # pylint: disable=no-member
+            Tag.BINARY_SET.tag: _deserialize_binary_set,  # pylint: disable=no-member
+            Tag.NUMBER.tag: _deserialize_number,  # pylint: disable=no-member
+            Tag.NUMBER_SET.tag: _deserialize_number_set,  # pylint: disable=no-member
+            Tag.STRING.tag: _deserialize_string,  # pylint: disable=no-member
+            Tag.STRING_SET.tag: _deserialize_string_set,  # pylint: disable=no-member
+            Tag.BOOLEAN.tag: _deserialize_boolean,  # pylint: disable=no-member
+            Tag.NULL.tag: _deserialize_null,  # pylint: disable=no-member
+            Tag.LIST.tag: _deserialize_list,  # pylint: disable=no-member
+            Tag.MAP.tag: _deserialize_map,  # pylint: disable=no-member
         }
         try:
             return deserialize_functions[tag]

src/dynamodb_encryption_sdk/internal/formatting/material_description.py

@@ -63,7 +63,8 @@ def serialize(material_description):
                 'Invalid name or value in material description: "{name}"="{value}"'.format(name=name, value=value)
             )
 
-    return {Tag.BINARY.dynamodb_tag: bytes(material_description_bytes)}
+    # for some reason pylint can't follow the Enum member attributes
+    return {Tag.BINARY.dynamodb_tag: bytes(material_description_bytes)}  # pylint: disable=no-member
 
 
 def deserialize(serialized_material_description):
@@ -77,7 +78,10 @@ def deserialize(serialized_material_description):
     :raises InvalidMaterialDescriptionVersionError: if unknown version is found
     """
     try:
-        _raw_material_description = serialized_material_description[Tag.BINARY.dynamodb_tag]
+        # for some reason pylint can't follow the Enum member attributes
+        _raw_material_description = serialized_material_description[
+            Tag.BINARY.dynamodb_tag  # pylint: disable=no-member
+        ]
 
         material_description_bytes = io.BytesIO(_raw_material_description)
         total_bytes = len(_raw_material_description)