chore: linting fixes

Author: mattsb42-aws

src/dynamodb_encryption_sdk/structures.py

@@ -223,7 +223,7 @@ class TableIndex(object):
     partition = attr.ib(validator=attr.validators.instance_of(six.string_types))
     sort = attr.ib(validator=attr.validators.optional(attr.validators.instance_of(six.string_types)), default=None)
 
-    def __init__(self, partition, sort=None):
+    def __init__(self, partition, sort=None):  # noqa=D107
         # type: (Text, Optional[Text]) -> None
         # Workaround pending resolution of attrs/mypy interaction.
         # https://github.com/python/mypy/issues/2088

test/acceptance/acceptance_test_utils.py

@@ -159,12 +159,12 @@ def _meta_table_prep(table_name, items_filename):
         table_data = json.load(f)
     request_items = {}
 
-    for table_name, items in table_data.items():
+    for this_table_name, items in table_data.items():
         requests = []
         for item in items:
             _decode_item(item)
             requests.append({"PutRequest": {"Item": item}})
-        request_items[table_name] = requests
+        request_items[this_table_name] = requests
     client.batch_write_item(RequestItems=request_items)
 
 

test/functional/functional_test_utils.py

@@ -178,7 +178,8 @@ class PassThroughCryptographicMaterialsProviderThatRequiresAttributes(Cryptograp
     def __init__(self, passthrough_cmp):
         self._passthrough_cmp = passthrough_cmp
 
-    def _assert_attributes_set(self, encryption_context):
+    @staticmethod
+    def _assert_attributes_set(encryption_context):
         # type: (EncryptionContext) -> None
         if not encryption_context.attributes:
             raise ValueError("Encryption context attributes MUST be set!")
@@ -386,7 +387,7 @@ def diverse_item():
     return copy.deepcopy(base_item)
 
 
-_reserved_attributes = set([attr.value for attr in ReservedAttributes])
+_reserved_attributes = {attr.value for attr in ReservedAttributes}
 
 
 def return_requestitems_as_unprocessed(*args, **kwargs):
@@ -529,7 +530,7 @@ def cycle_batch_writer_check(raw_table, encrypted_table, initial_actions, initia
         for item in items:
             writer.put_item(item)
 
-    ddb_keys = [key for key in TEST_BATCH_KEYS]
+    ddb_keys = TEST_BATCH_KEYS.copy()
     encrypted_items = [raw_table.get_item(Key=key, ConsistentRead=True)["Item"] for key in ddb_keys]
     check_many_encrypted_items(
         actual=encrypted_items, expected=items, attribute_actions=check_attribute_actions, transformer=_nop_transformer
@@ -756,6 +757,7 @@ def client_cycle_batch_items_check_scan_paginator(
     scan the table with encrypted client paginator to get decrypted items,
     then verify that all items appear to have been encrypted correctly.
     """  # noqa=D401
+    # pylint: disable=too-many-locals
     kwargs = {}
     if region_name is not None:
         kwargs["region_name"] = region_name

test/functional/materials/test_raw.py

@@ -24,7 +24,7 @@ def test_no_encryption_key():
     encryption_materials = RawEncryptionMaterials(signing_key=signing_key)
 
     with pytest.raises(AttributeError) as excinfo:
-        encryption_materials.encryption_key
+        encryption_materials.encryption_key  # calls a property, so pylint: disable=pointless-statement
 
     excinfo.match("No encryption key available")
 
@@ -34,6 +34,6 @@ def test_no_decryption_key():
     decryption_materials = RawDecryptionMaterials(verification_key=verification_key)
 
     with pytest.raises(AttributeError) as excinfo:
-        decryption_materials.decryption_key
+        decryption_materials.decryption_key  # calls a property, so pylint: disable=pointless-statement
 
     excinfo.match("No decryption key available")

test/integration/integration_test_utils.py

@@ -54,8 +54,8 @@ def _build_kms_cmp(require_attributes):
     inner_cmp = AwsKmsCryptographicMaterialsProvider(key_id=cmk_arn_value())
     if require_attributes:
         return functional_test_utils.PassThroughCryptographicMaterialsProviderThatRequiresAttributes(inner_cmp)
-    else:
-        return inner_cmp
+
+    return inner_cmp
 
 
 def set_parameterized_kms_cmps(metafunc, require_attributes=True):