chore: Add examples to examine contents of query error list #1251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-aws
reviewed
Aug 7, 2024
...DynamoDbEncryption/src/main/java/software/amazon/cryptography/examples/ScanErrorExample.java
Outdated
Show resolved
Hide resolved
| System.err.println(e); | ||
| System.err.println(e.getMessage()); | ||
| System.err.println(e.getCause()); | ||
| System.err.println(((CollectionOfErrors) e.getCause()).list()); |
There was a problem hiding this comment.
It's interesting to me that the CollectionOfErrors ends up as an indirect cause in Java but thrown directly in C#, do you know why?
| { | ||
| Console.Error.WriteLine("Encryptor Error : " + e.Message); | ||
| } | ||
| catch (AWS.Cryptography.DbEncryptionSDK.DynamoDb.Transforms.CollectionOfErrors e) |
There was a problem hiding this comment.
It's unfortunate that we end up with multiple declarations of CollectionOfErrors in different namespaces, but again that's out of scope for this PR. Might look a bit cleaner to add a using for this though.
...DynamoDbEncryption/src/main/java/software/amazon/cryptography/examples/ScanErrorExample.java
Show resolved
Hide resolved
...DynamoDbEncryption/src/main/java/software/amazon/cryptography/examples/ScanErrorExample.java
Outdated
Show resolved
Hide resolved
lucasmcdonald3
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
The CollectionOfErrors behavior is unfortunate, but the examples are good.
Tracking underlying behavior in https://sim.amazon.com/issues/CrypTool-5349
seebees
pushed a commit
that referenced
this pull request
Aug 12, 2024
## [3.6.1](v3.6.0...v3.6.1) (2024-08-12) ### Fixes * allow multi-tenant queries with allow_plaintext ([#1240](#1240)) ([1487d7e](1487d7e)) * **TestVectors:** define StartUpObject in csproj ([#1231](#1231)) ([2f97bf3](2f97bf3)) ### Maintenance * Add examples to examine contents of query error list ([#1251](#1251)) ([b5705ee](b5705ee)) * **CI:** add smithy diff checker GHA ([#1226](#1226)) ([86406f5](86406f5)) * **deps:** bump actions/setup-dotnet from 3 to 4 in /.github/workflows ([#1191](#1191)) ([c3b736e](c3b736e)) * **deps:** bump aws-actions/configure-aws-credentials ([#1190](#1190)) ([becbd0a](becbd0a)) * **deps:** bump com.amazonaws:aws-java-sdk-dynamodb ([#1230](#1230)) ([3aa25d0](3aa25d0)) * **deps:** bump dafny-lang/setup-dafny-action in /.github/workflows ([#1200](#1200)) ([5284f0b](5284f0b)) * **deps:** bump software.amazon.awssdk:bom ([#1227](#1227)) ([abd1727](abd1727)) * **deps:** bump software.amazon.awssdk:bom ([#1229](#1229)) ([bf3e1c3](bf3e1c3)) * **deps:** bump software.amazon.awssdk:core ([#1228](#1228)) ([9c67729](9c67729)) * do not add beacons when FORCE_PLAINTEXT_WRITE is used. ([#1232](#1232)) ([23c8a18](23c8a18)) * include bad item keys in query errors ([#1244](#1244)) ([07bba8b](07bba8b)) * update version to snapshot ([#1225](#1225)) ([c817b5b](c817b5b))
Merged
seebees
pushed a commit
that referenced
this pull request
Aug 12, 2024
## [3.6.1](v3.6.0...v3.6.1) (2024-08-12) ### Fixes * allow multi-tenant queries with allow_plaintext ([#1240](#1240)) ([1487d7e](1487d7e)) * **TestVectors:** define StartUpObject in csproj ([#1231](#1231)) ([2f97bf3](2f97bf3)) ### Maintenance * Add examples to examine contents of query error list ([#1251](#1251)) ([b5705ee](b5705ee)) * **CI:** add smithy diff checker GHA ([#1226](#1226)) ([86406f5](86406f5)) * **deps:** bump actions/setup-dotnet from 3 to 4 in /.github/workflows ([#1191](#1191)) ([c3b736e](c3b736e)) * **deps:** bump aws-actions/configure-aws-credentials ([#1190](#1190)) ([becbd0a](becbd0a)) * **deps:** bump com.amazonaws:aws-java-sdk-dynamodb ([#1230](#1230)) ([3aa25d0](3aa25d0)) * **deps:** bump dafny-lang/setup-dafny-action in /.github/workflows ([#1200](#1200)) ([5284f0b](5284f0b)) * **deps:** bump software.amazon.awssdk:bom ([#1227](#1227)) ([abd1727](abd1727)) * **deps:** bump software.amazon.awssdk:bom ([#1229](#1229)) ([bf3e1c3](bf3e1c3)) * **deps:** bump software.amazon.awssdk:core ([#1228](#1228)) ([9c67729](9c67729)) * do not add beacons when FORCE_PLAINTEXT_WRITE is used. ([#1232](#1232)) ([23c8a18](23c8a18)) * include bad item keys in query errors ([#1244](#1244)) ([07bba8b](07bba8b)) * update version to snapshot ([#1225](#1225)) ([c817b5b](c817b5b))
seebees
added a commit
that referenced
this pull request
Aug 12, 2024
## [3.6.1](v3.6.0...v3.6.1) (2024-08-12) ### Fixes * allow multi-tenant queries with allow_plaintext ([#1240](#1240)) ([1487d7e](1487d7e)) * **TestVectors:** define StartUpObject in csproj ([#1231](#1231)) ([2f97bf3](2f97bf3)) ### Maintenance * Add examples to examine contents of query error list ([#1251](#1251)) ([b5705ee](b5705ee)) * **CI:** add smithy diff checker GHA ([#1226](#1226)) ([86406f5](86406f5)) * **deps:** bump actions/setup-dotnet from 3 to 4 in /.github/workflows ([#1191](#1191)) ([c3b736e](c3b736e)) * **deps:** bump aws-actions/configure-aws-credentials ([#1190](#1190)) ([becbd0a](becbd0a)) * **deps:** bump com.amazonaws:aws-java-sdk-dynamodb ([#1230](#1230)) ([3aa25d0](3aa25d0)) * **deps:** bump dafny-lang/setup-dafny-action in /.github/workflows ([#1200](#1200)) ([5284f0b](5284f0b)) * **deps:** bump software.amazon.awssdk:bom ([#1227](#1227)) ([abd1727](abd1727)) * **deps:** bump software.amazon.awssdk:bom ([#1229](#1229)) ([bf3e1c3](bf3e1c3)) * **deps:** bump software.amazon.awssdk:core ([#1228](#1228)) ([9c67729](9c67729)) * do not add beacons when FORCE_PLAINTEXT_WRITE is used. ([#1232](#1232)) ([23c8a18](23c8a18)) * include bad item keys in query errors ([#1244](#1244)) ([07bba8b](07bba8b)) * update version to snapshot ([#1225](#1225)) ([c817b5b](c817b5b))
seebees
pushed a commit
that referenced
this pull request
Aug 12, 2024
## [3.6.1](v3.6.0...v3.6.1) (2024-08-12) ### Fixes * allow multi-tenant queries with allow_plaintext ([#1240](#1240)) ([1487d7e](1487d7e)) * **TestVectors:** define StartUpObject in csproj ([#1231](#1231)) ([2f97bf3](2f97bf3)) ### Maintenance * Add examples to examine contents of query error list ([#1251](#1251)) ([b5705ee](b5705ee)) * **CI:** add smithy diff checker GHA ([#1226](#1226)) ([86406f5](86406f5)) * **deps:** bump actions/setup-dotnet from 3 to 4 in /.github/workflows ([#1191](#1191)) ([c3b736e](c3b736e)) * **deps:** bump aws-actions/configure-aws-credentials ([#1190](#1190)) ([becbd0a](becbd0a)) * **deps:** bump com.amazonaws:aws-java-sdk-dynamodb ([#1230](#1230)) ([3aa25d0](3aa25d0)) * **deps:** bump dafny-lang/setup-dafny-action in /.github/workflows ([#1200](#1200)) ([5284f0b](5284f0b)) * **deps:** bump software.amazon.awssdk:bom ([#1227](#1227)) ([abd1727](abd1727)) * **deps:** bump software.amazon.awssdk:bom ([#1229](#1229)) ([bf3e1c3](bf3e1c3)) * **deps:** bump software.amazon.awssdk:core ([#1228](#1228)) ([9c67729](9c67729)) * do not add beacons when FORCE_PLAINTEXT_WRITE is used. ([#1232](#1232)) ([23c8a18](23c8a18)) * include bad item keys in query errors ([#1244](#1244)) ([07bba8b](07bba8b)) * update version to snapshot ([#1225](#1225)) ([c817b5b](c817b5b))
seebees
added a commit
that referenced
this pull request
Aug 13, 2024
## [3.6.1](v3.6.0...v3.6.1) (2024-08-12) ### Fixes * allow multi-tenant queries with allow_plaintext ([#1240](#1240)) ([1487d7e](1487d7e)) * **TestVectors:** define StartUpObject in csproj ([#1231](#1231)) ([2f97bf3](2f97bf3)) ### Maintenance * Add examples to examine contents of query error list ([#1251](#1251)) ([b5705ee](b5705ee)) * **CI:** add smithy diff checker GHA ([#1226](#1226)) ([86406f5](86406f5)) * **deps:** bump actions/setup-dotnet from 3 to 4 in /.github/workflows ([#1191](#1191)) ([c3b736e](c3b736e)) * **deps:** bump aws-actions/configure-aws-credentials ([#1190](#1190)) ([becbd0a](becbd0a)) * **deps:** bump com.amazonaws:aws-java-sdk-dynamodb ([#1230](#1230)) ([3aa25d0](3aa25d0)) * **deps:** bump dafny-lang/setup-dafny-action in /.github/workflows ([#1200](#1200)) ([5284f0b](5284f0b)) * **deps:** bump software.amazon.awssdk:bom ([#1227](#1227)) ([abd1727](abd1727)) * **deps:** bump software.amazon.awssdk:bom ([#1229](#1229)) ([bf3e1c3](bf3e1c3)) * **deps:** bump software.amazon.awssdk:core ([#1228](#1228)) ([9c67729](9c67729)) * do not add beacons when FORCE_PLAINTEXT_WRITE is used. ([#1232](#1232)) ([23c8a18](23c8a18)) * include bad item keys in query errors ([#1244](#1244)) ([07bba8b](07bba8b)) * update version to snapshot ([#1225](#1225)) ([c817b5b](c817b5b)) --------- Co-authored-by: semantic-release-bot <[email protected]>
seebees
added a commit
that referenced
this pull request
Aug 14, 2024
## [3.6.1](v3.6.0...v3.6.1) (2024-08-12) ### Fixes * allow multi-tenant queries with allow_plaintext ([#1240](#1240)) ([1487d7e](1487d7e)) * **TestVectors:** define StartUpObject in csproj ([#1231](#1231)) ([2f97bf3](2f97bf3)) * update error message ([#1270](#1270)) ([7157e4d](7157e4d)) ### Maintenance * Add examples to examine contents of query error list ([#1251](#1251)) ([b5705ee](b5705ee)) * **CI:** add smithy diff checker GHA ([#1226](#1226)) ([86406f5](86406f5)) * **deps:** bump actions/setup-dotnet from 3 to 4 in /.github/workflows ([#1191](#1191)) ([c3b736e](c3b736e)) * **deps:** bump aws-actions/configure-aws-credentials ([#1190](#1190)) ([becbd0a](becbd0a)) * **deps:** bump com.amazonaws:aws-java-sdk-dynamodb ([#1230](#1230)) ([3aa25d0](3aa25d0)) * **deps:** bump dafny-lang/setup-dafny-action in /.github/workflows ([#1200](#1200)) ([5284f0b](5284f0b)) * **deps:** bump software.amazon.awssdk:bom ([#1227](#1227)) ([abd1727](abd1727)) * **deps:** bump software.amazon.awssdk:bom ([#1229](#1229)) ([bf3e1c3](bf3e1c3)) * **deps:** bump software.amazon.awssdk:core ([#1228](#1228)) ([9c67729](9c67729)) * do not add beacons when FORCE_PLAINTEXT_WRITE is used. ([#1232](#1232)) ([23c8a18](23c8a18)) * include bad item keys in query errors ([#1244](#1244)) ([07bba8b](07bba8b)) * **release:** 3.6.1 ([#1266](#1266)) ([64374e2](64374e2)), closes [#1240](#1240) [#1231](#1231) [#1251](#1251) [#1226](#1226) [#1191](#1191) [#1190](#1190) [#1230](#1230) [#1200](#1200) [#1227](#1227) [#1229](#1229) [#1228](#1228) [#1232](#1232) [#1244](#1244) [#1225](#1225) * update version to snapshot ([#1225](#1225)) ([c817b5b](c817b5b))
seebees
added a commit
that referenced
this pull request
Aug 14, 2024
## [3.6.1](v3.6.0...v3.6.1) (2024-08-12) ### Fixes * allow multi-tenant queries with allow_plaintext ([#1240](#1240)) ([1487d7e](1487d7e)) * **TestVectors:** define StartUpObject in csproj ([#1231](#1231)) ([2f97bf3](2f97bf3)) * update error message ([#1270](#1270)) ([7157e4d](7157e4d)) ### Maintenance * Add examples to examine contents of query error list ([#1251](#1251)) ([b5705ee](b5705ee)) * **CI:** add smithy diff checker GHA ([#1226](#1226)) ([86406f5](86406f5)) * **deps:** bump actions/setup-dotnet from 3 to 4 in /.github/workflows ([#1191](#1191)) ([c3b736e](c3b736e)) * **deps:** bump aws-actions/configure-aws-credentials ([#1190](#1190)) ([becbd0a](becbd0a)) * **deps:** bump com.amazonaws:aws-java-sdk-dynamodb ([#1230](#1230)) ([3aa25d0](3aa25d0)) * **deps:** bump dafny-lang/setup-dafny-action in /.github/workflows ([#1200](#1200)) ([5284f0b](5284f0b)) * **deps:** bump software.amazon.awssdk:bom ([#1227](#1227)) ([abd1727](abd1727)) * **deps:** bump software.amazon.awssdk:bom ([#1229](#1229)) ([bf3e1c3](bf3e1c3)) * **deps:** bump software.amazon.awssdk:core ([#1228](#1228)) ([9c67729](9c67729)) * do not add beacons when FORCE_PLAINTEXT_WRITE is used. ([#1232](#1232)) ([23c8a18](23c8a18)) * include bad item keys in query errors ([#1244](#1244)) ([07bba8b](07bba8b)) * **release:** 3.6.1 ([#1266](#1266)) ([64374e2](64374e2)), closes [#1240](#1240) [#1231](#1231) [#1251](#1251) [#1226](#1226) [#1191](#1191) [#1190](#1190) [#1230](#1230) [#1200](#1200) [#1227](#1227) [#1229](#1229) [#1228](#1228) [#1232](#1232) [#1244](#1244) [#1225](#1225) * update version to snapshot ([#1225](#1225)) ([c817b5b](c817b5b)) * lint * remove recursive reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.