Skip to content

Commit c320fe5

Browse files
committed
address feedback
1 parent fc6c9a9 commit c320fe5

File tree

6 files changed

+783
-589
lines changed

6 files changed

+783
-589
lines changed

Examples/runtimes/java/DynamoDbEncryption/src/main/java/software/amazon/cryptography/examples/keyring/KmsEcdhKeyringExample.java

+210-108
Large diffs are not rendered by default.

Examples/runtimes/java/DynamoDbEncryption/src/main/java/software/amazon/cryptography/examples/keyring/RawEcdhKeyringExample.java

+202-194
Large diffs are not rendered by default.

Examples/runtimes/java/DynamoDbEncryption/src/test/java/software/amazon/cryptography/examples/keyring/TestKmsEcdhKeyringExample.java

+4-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,10 @@ public class TestKmsEcdhKeyringExample {
1212

1313
@Test
1414
public void TestKmsEcdhKeyringExampleStatic() {
15-
// You may provide your own ECC public keys at EXAMPLE_ECC_PUBLIC_KEY_SENDER_FILENAME
16-
// and EXAMPLE_ECC_PUBLIC_KEY_RECIPIENT_FILENAME.
15+
// You may provide your own ECC public keys at
16+
// - EXAMPLE_ECC_PUBLIC_KEY_SENDER_FILENAME
17+
// - EXAMPLE_ECC_PUBLIC_KEY_RECIPIENT_FILENAME.
18+
// If you provide these, the keys MUST be on curve P256
1719
// This must be the public key for the ECC key represented at eccKeyArn
1820
// If this file is not present, this will write a UTF-8 encoded PEM file for you.
1921
if (shouldGetNewPublicKeys()) {

Examples/runtimes/java/DynamoDbEncryption/src/test/java/software/amazon/cryptography/examples/keyring/TestRawEcdhKeyringExample.java

+3
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ public void TestStaticRawEcdhKeyringExample() {
1313
// You may provide your own ECC Key pairs in the files located at
1414
// - EXAMPLE_ECC_PRIVATE_KEY_FILENAME_SENDER
1515
// - EXAMPLE_ECC_PUBLIC_KEY_FILENAME_RECIPIENT
16+
// If you provide this, the keys MUST be on curve P256
1617
// If these files are not present, this will generate a pair for you.
1718
// For this example we will use the curve P256.
1819
if (RawEcdhKeyringExample.shouldGenerateNewEccKeyPairs()) {
@@ -31,6 +32,7 @@ public void TestStaticRawEcdhKeyringExample() {
3132
public void TestEphemeralRawEcdhKeyringExample() {
3233
// You may provide your own ECC Public Key in the files located at
3334
// - EXAMPLE_ECC_PUBLIC_KEY_FILENAME_RECIPIENT
35+
// If you provide this, the keys MUST be on curve P256
3436
// If these files are not present, this will generate a pair for you.
3537
// For this example we will use the curve P256.
3638
if (RawEcdhKeyringExample.shouldGenerateNewEccKeyPairs()) {
@@ -50,6 +52,7 @@ public void TestDiscoveryRawEcdhKeyringExample() {
5052
// You may provide your own ECC Public Key in the files located at
5153
// - EXAMPLE_ECC_PUBLIC_KEY_FILENAME_RECIPIENT
5254
// - EXAMPLE_ECC_PRIVATE_KEY_FILENAME_RECIPIENT
55+
// If you provide this, the keys MUST be on curve P256
5356
// If these files are not present, this will generate a pair for you.
5457
// For this example we will use the curve P256.
5558
if (RawEcdhKeyringExample.shouldGenerateNewEccKeyPairs()) {

0 commit comments

Comments
 (0)