feedback

Author: ajewellamz

DynamoDbEncryption/dafny/DynamoDbEncryptionTransforms/src/DdbMiddlewareConfig.dfy

@@ -110,7 +110,7 @@ module DdbMiddlewareConfig {
         "";
     var sort :=
       if config.sortKeyName.Some? && config.sortKeyName.value in item then
-        "\n" + config.sortKeyName.value + " = " + AttrToString(item[config.sortKeyName.value])
+        "; " + config.sortKeyName.value + " = " + AttrToString(item[config.sortKeyName.value])
       else
         "";
 

Examples/runtimes/java/DynamoDbEncryption/src/main/java/software/amazon/cryptography/examples/ScanErrorExample.java

@@ -20,9 +20,9 @@
 
 /*
   This example sets up DynamoDb Encryption for the AWS SDK client
-  and uses the low level PutItem and GetItem DDB APIs to demonstrate
-  putting a client-side encrypted item into DynamoDb
-  and then retrieving and decrypting that item from DynamoDb. 
+  and uses the low level Scan operation to demonstrate
+  retrieving the error messages from the returned CollectionOfErrors
+  when some of the Scan results do not decrypt successfully.
 
   Running this example requires access to the DDB Table whose name
   is provided in CLI arguments.
@@ -155,12 +155,13 @@ public static void ScanError(String kmsKeyId, String ddbTableName) {
 
     try {
       final ScanResponse scanResponse = ddb.scan(scanRequest);
+      assert false;
     } catch (Exception e) {
-      System.err.println("Other Error : ");
-      System.err.println(e);
       System.err.println(e.getMessage());
       System.err.println(e.getCause());
-      System.err.println(((CollectionOfErrors) e.getCause()).list());
+      for (RuntimeException err : ((CollectionOfErrors) e.getCause()).list()) {
+        System.err.println("   " + err.getMessage());
+      }
     }
   }
 

Examples/runtimes/net/src/ScanErrorExample.cs

@@ -10,9 +10,9 @@
 
 /*
   This example sets up DynamoDb Encryption for the AWS SDK client
-  and uses the low level PutItem and GetItem DDB APIs to demonstrate
-  putting a client-side encrypted item into DynamoDb
-  and then retrieving and decrypting that item from DynamoDb.
+  and uses the low level Scan operation to demonstrate
+  retrieving the error messages from the returned CollectionOfErrors
+  when some of the Scan results do not decrypt successfully.
 
   Running this example requires access to the DDB Table whose name
   is provided in CLI arguments.
@@ -123,10 +123,7 @@ public static async Task ScanError()
         try
         {
             var scanResponse = await ddb.ScanAsync(scanRequest);
-        }
-        catch (DynamoDbEncryptionException e)
-        {
-            Console.Error.WriteLine("Encryptor Error : " + e.Message);
+            Debug.Assert(false);
         }
         catch (AWS.Cryptography.DbEncryptionSDK.DynamoDb.Transforms.CollectionOfErrors e)
         {
@@ -139,8 +136,7 @@ public static async Task ScanError()
         }
         catch (Exception e)
         {
-            Console.Error.WriteLine("Other Error : ");
-            Console.Error.WriteLine(e);
+            Debug.Assert(false);
         }
     }
 }