fix(opensearchservice): imported domain's domainendpoint is a url not an endpoint (#18027)

imported Domain's domainEndpoint should be a endpoint and not a url.
Fixes [#18017](#18017)

BREAKING CHANGE: imported domain property `domainEndpoint` used to contain `https://` prefix, now the prefix is dropped and it returns the same value as a `domainEndpoint` on a created domain

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Author: joejegan

packages/@aws-cdk/aws-elasticsearch/lib/domain.ts

@@ -1218,7 +1218,7 @@ export class Domain extends DomainBase implements IDomain, ec2.IConnectable {
     return new class extends DomainBase {
       public readonly domainArn = domainArn;
       public readonly domainName = domainName;
-      public readonly domainEndpoint = domainEndpoint;
+      public readonly domainEndpoint = domainEndpoint.replace(/^https?:\/\//, '');
 
       constructor() { super(scope, id); }
     };

packages/@aws-cdk/aws-elasticsearch/test/domain.test.ts

@@ -928,26 +928,30 @@ describe('import', () => {
 
   test('static fromDomainEndpoint(endpoint) allows importing an external/existing domain', () => {
     const domainName = 'test-domain-2w2x2u3tifly';
-    const domainEndpoint = `https://${domainName}-jcjotrt6f7otem4sqcwbch3c4u.testregion.es.amazonaws.com`;
+    const domainEndpointWithoutHttps = `${domainName}-jcjotrt6f7otem4sqcwbch3c4u.testregion.es.amazonaws.com`;
+    const domainEndpoint = `https://${domainEndpointWithoutHttps}`;
     const imported = Domain.fromDomainEndpoint(stack, 'Domain', domainEndpoint);
 
     expect(imported.domainName).toEqual(domainName);
     expect(imported.domainArn).toMatch(RegExp(`es:testregion:1234:domain/${domainName}$`));
+    expect(imported.domainEndpoint).toEqual(domainEndpointWithoutHttps);
 
     expect(stack).not.toHaveResource('AWS::Elasticsearch::Domain');
   });
 
   test('static fromDomainAttributes(attributes) allows importing an external/existing domain', () => {
     const domainName = 'test-domain-2w2x2u3tifly';
     const domainArn = `arn:aws:es:testregion:1234:domain/${domainName}`;
-    const domainEndpoint = `https://${domainName}-jcjotrt6f7otem4sqcwbch3c4u.testregion.es.amazonaws.com`;
+    const domainEndpointWithoutHttps = `${domainName}-jcjotrt6f7otem4sqcwbch3c4u.testregion.es.amazonaws.com`;
+    const domainEndpoint = `https://${domainEndpointWithoutHttps}`;
     const imported = Domain.fromDomainAttributes(stack, 'Domain', {
       domainArn,
       domainEndpoint,
     });
 
     expect(imported.domainName).toEqual(domainName);
     expect(imported.domainArn).toEqual(domainArn);
+    expect(imported.domainEndpoint).toEqual(domainEndpointWithoutHttps);
 
     expect(stack).not.toHaveResource('AWS::Elasticsearch::Domain');
   });

packages/@aws-cdk/aws-opensearchservice/lib/domain.ts

@@ -1148,7 +1148,7 @@ export class Domain extends DomainBase implements IDomain, ec2.IConnectable {
       public readonly domainArn = domainArn;
       public readonly domainName = domainName;
       public readonly domainId = domainName;
-      public readonly domainEndpoint = domainEndpoint;
+      public readonly domainEndpoint = domainEndpoint.replace(/^https?:\/\//, '');
 
       constructor() { super(scope, id); }
     };

packages/@aws-cdk/aws-opensearchservice/test/domain.test.ts

@@ -930,26 +930,30 @@ describe('import', () => {
 
   test('static fromDomainEndpoint(endpoint) allows importing an external/existing domain', () => {
     const domainName = 'test-domain-2w2x2u3tifly';
-    const domainEndpoint = `https://${domainName}-jcjotrt6f7otem4sqcwbch3c4u.testregion.es.amazonaws.com`;
+    const domainEndpointWithoutHttps = `${domainName}-jcjotrt6f7otem4sqcwbch3c4u.testregion.es.amazonaws.com`;
+    const domainEndpoint = `https://${domainEndpointWithoutHttps}`;
     const imported = Domain.fromDomainEndpoint(stack, 'Domain', domainEndpoint);
 
     expect(imported.domainName).toEqual(domainName);
     expect(imported.domainArn).toMatch(RegExp(`es:testregion:1234:domain/${domainName}$`));
+    expect(imported.domainEndpoint).toEqual(domainEndpointWithoutHttps);
 
     expect(stack).not.toHaveResource('AWS::OpenSearchService::Domain');
   });
 
   test('static fromDomainAttributes(attributes) allows importing an external/existing domain', () => {
     const domainName = 'test-domain-2w2x2u3tifly';
     const domainArn = `arn:aws:es:testregion:1234:domain/${domainName}`;
-    const domainEndpoint = `https://${domainName}-jcjotrt6f7otem4sqcwbch3c4u.testregion.es.amazonaws.com`;
+    const domainEndpointWithoutHttps = `${domainName}-jcjotrt6f7otem4sqcwbch3c4u.testregion.es.amazonaws.com`;
+    const domainEndpoint = `https://${domainEndpointWithoutHttps}`;
     const imported = Domain.fromDomainAttributes(stack, 'Domain', {
       domainArn,
       domainEndpoint,
     });
 
     expect(imported.domainName).toEqual(domainName);
     expect(imported.domainArn).toEqual(domainArn);
+    expect(imported.domainEndpoint).toEqual(domainEndpointWithoutHttps);
 
     expect(stack).not.toHaveResource('AWS::OpenSearchService::Domain');
   });