Skip to content

Commit f7d4f41

Browse files
authored
chore(ci): use SHA as reference for integration test workflow instead of branch. (#29787)
### Reason for this change It is better to use an immutable commit reference for workflows that require approval, since the branch's head commit can change between the time of approval and workflow run execution. ### Description of changes Updated the `ref` parameter to use the SHA from the pull_request event instead of the ref. ### Description of how you validated changes ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 0b429fb commit f7d4f41

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/request-cli-integ-test.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
with:
3939
# Needs to run with PROJEN_GITHUB_TOKEN because we need permissions to force push the branch
4040
token: ${{ secrets.PROJEN_GITHUB_TOKEN }}
41-
ref: ${{ github.event.pull_request.head.ref }}
41+
ref: ${{ github.event.pull_request.head.sha }}
4242
repository: ${{ github.event.pull_request.head.repo.full_name }}
4343
- name: Submit to test-pipeline
4444
run: |

0 commit comments

Comments
 (0)