Skip to content

Commit dff2798

Browse files
authored
fix(ec2-alpha): update default config for Subnet's assignIpv6AddressOnCreation (#34116)
### Issue # (if applicable) N/A ### Reason for this change The `Subnet.assignIpv6AddressOnCreation` attribute was being set in the L1, despite it not being necessary to set. This may cause issues with backwards migrations from V1 subnets to V2, since there will be this attribute difference across both. ### Description of changes ```ts const subnet = new CfnSubnet(this, 'Subnet', { ... assignIpv6AddressOnCreation: props.assignIpv6AddressOnCreation /* ?? false */, mapPublicIpOnLaunch: props.mapPublicIpOnLaunch /* ?? undefined */ // this one was just a redundant nit } ``` ### Describe any new or updated permissions being added N/A ### Description of how you validated changes `yarn test && yarn integ-runner --update-on-failed --dry-run` (dry run since it's a very minor change, and some of the integ tests for IPv6 and IPAM are finnicky) ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent cd3208c commit dff2798

File tree

116 files changed

+1014
-36383
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

116 files changed

+1014
-36383
lines changed

packages/@aws-cdk/aws-ec2-alpha/lib/subnet-v2.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -295,8 +295,8 @@ export class SubnetV2 extends Resource implements ISubnetV2 {
295295
cidrBlock: ipv4CidrBlock,
296296
ipv6CidrBlock: ipv6CidrBlock,
297297
availabilityZone: props.availabilityZone,
298-
assignIpv6AddressOnCreation: props.assignIpv6AddressOnCreation ?? false,
299-
mapPublicIpOnLaunch: props.mapPublicIpOnLaunch ?? undefined,
298+
assignIpv6AddressOnCreation: props.assignIpv6AddressOnCreation,
299+
mapPublicIpOnLaunch: props.mapPublicIpOnLaunch,
300300
});
301301

302302
this.node.defaultChild = subnet;

packages/@aws-cdk/aws-ec2-alpha/test/integ.byoip-ipv6.js.snapshot/cdk.out

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk/aws-ec2-alpha/test/integ.byoip-ipv6.js.snapshot/integ.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk/aws-ec2-alpha/test/integ.byoip-ipv6.js.snapshot/integtestmodelDefaultTestDeployAssertCF40BD53.assets.json

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk/aws-ec2-alpha/test/integ.byoip-ipv6.js.snapshot/manifest.json

Lines changed: 40 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)