Skip to content

Commit d942324

Browse files
authored
fix(integ-runner): array arguments aren't recognizing multiple options (#21763)
I don't know why I was specifying `nargs: 1` for array arguments. This tells yargs to only accept a single argument. You can no provide multiple options, i.e. ``` yarn integ --regions us-east-1 us-east-2 ``` re #20384 ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent daf885f commit d942324

File tree

1 file changed

+2
-2
lines changed
  • packages/@aws-cdk/integ-runner/lib

1 file changed

+2
-2
lines changed

packages/@aws-cdk/integ-runner/lib/cli.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ async function main() {
2222
.option('dry-run', { type: 'boolean', default: false, desc: 'do not actually deploy the stack. just update the snapshot (not recommended!)' })
2323
.option('update-on-failed', { type: 'boolean', default: false, desc: 'rerun integration tests and update snapshots for failed tests.' })
2424
.option('force', { type: 'boolean', default: false, desc: 'Rerun all integration tests even if tests are passing' })
25-
.option('parallel-regions', { type: 'array', desc: 'Tests are run in parallel across these regions. To prevent tests from running in parallel, provide only a single region', nargs: 1, default: [] })
25+
.option('parallel-regions', { type: 'array', desc: 'Tests are run in parallel across these regions. To prevent tests from running in parallel, provide only a single region', default: [] })
2626
.options('directory', { type: 'string', default: 'test', desc: 'starting directory to discover integration tests. Tests will be discovered recursively from this directory' })
27-
.options('profiles', { type: 'array', desc: 'list of AWS profiles to use. Tests will be run in parallel across each profile+regions', nargs: 1, default: [] })
27+
.options('profiles', { type: 'array', desc: 'list of AWS profiles to use. Tests will be run in parallel across each profile+regions', default: [] })
2828
.options('max-workers', { type: 'number', desc: 'The max number of workerpool workers to use when running integration tests in parallel', default: 16 })
2929
.options('exclude', { type: 'boolean', desc: 'Run all tests in the directory, except the specified TESTs', default: false })
3030
.options('from-file', { type: 'string', desc: 'Read TEST names from a file (one TEST per line)' })

0 commit comments

Comments
 (0)