Skip to content

Commit d681b12

Browse files
authored
chore(release): 2.167.1 (#32140)
See CHANGELOG
2 parents 677e108 + 36fd449 commit d681b12

File tree

5 files changed

+368
-4
lines changed

5 files changed

+368
-4
lines changed

CHANGELOG.v2.alpha.md

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
44

5+
## [2.167.1-alpha.0](https://github.com/aws/aws-cdk/compare/v2.167.0-alpha.0...v2.167.1-alpha.0) (2024-11-14)
6+
57
## [2.167.0-alpha.0](https://github.com/aws/aws-cdk/compare/v2.166.0-alpha.0...v2.167.0-alpha.0) (2024-11-13)
68

79

CHANGELOG.v2.md

+8
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,14 @@
22

33
All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
44

5+
## [2.167.1](https://github.com/aws/aws-cdk/compare/v2.167.0...v2.167.1) (2024-11-14)
6+
7+
8+
### Bug Fixes
9+
10+
* **cli:** failure to get credentials when session token is not set ([#32134](https://github.com/aws/aws-cdk/issues/32134)) ([425efbc](https://github.com/aws/aws-cdk/commit/425efbc3625d4512b83225dcb1d1c155d13b4b9e)), closes [#32120](https://github.com/aws/aws-cdk/issues/32120)
11+
* **cli:** region specified in `~/.aws/credentials` is ignored ([#32133](https://github.com/aws/aws-cdk/issues/32133)) ([9859f33](https://github.com/aws/aws-cdk/commit/9859f33a11fb385419c611945bd9bb171b458dad)), closes [#32130](https://github.com/aws/aws-cdk/issues/32130)
12+
513
## [2.167.0](https://github.com/aws/aws-cdk/compare/v2.166.0...v2.167.0) (2024-11-13)
614

715

packages/aws-cdk/lib/api/aws-auth/awscli-compatible.ts

+25-2
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,25 @@ export class AwsCliCompatible {
149149
*/
150150
async function getRegionFromIni(profile: string): Promise<string | undefined> {
151151
const sharedFiles = await loadSharedConfigFiles({ ignoreCache: true });
152-
return sharedFiles?.configFile?.[profile]?.region || sharedFiles?.configFile?.default?.region;
152+
153+
// Priority:
154+
//
155+
// credentials come before config because aws-cli v1 behaves like that.
156+
//
157+
// 1. profile-region-in-credentials
158+
// 2. profile-region-in-config
159+
// 3. default-region-in-credentials
160+
// 4. default-region-in-config
161+
162+
return getRegionFromIniFile(profile, sharedFiles.credentialsFile)
163+
?? getRegionFromIniFile(profile, sharedFiles.configFile)
164+
?? getRegionFromIniFile('default', sharedFiles.credentialsFile)
165+
?? getRegionFromIniFile('default', sharedFiles.configFile);
166+
167+
}
168+
169+
function getRegionFromIniFile(profile: string, data?: any) {
170+
return data?.[profile]?.region;
153171
}
154172

155173
function tryGetCACert(bundlePath?: string) {
@@ -182,11 +200,16 @@ function caBundlePathFromEnvironment(): string | undefined {
182200
function shouldPrioritizeEnv() {
183201
const id = process.env.AWS_ACCESS_KEY_ID || process.env.AMAZON_ACCESS_KEY_ID;
184202
const key = process.env.AWS_SECRET_ACCESS_KEY || process.env.AMAZON_SECRET_ACCESS_KEY;
185-
process.env.AWS_SESSION_TOKEN = process.env.AWS_SESSION_TOKEN || process.env.AMAZON_SESSION_TOKEN;
186203

187204
if (!!id && !!key) {
188205
process.env.AWS_ACCESS_KEY_ID = id;
189206
process.env.AWS_SECRET_ACCESS_KEY = key;
207+
208+
const sessionToken = process.env.AWS_SESSION_TOKEN ?? process.env.AMAZON_SESSION_TOKEN;
209+
if (sessionToken) {
210+
process.env.AWS_SESSION_TOKEN = sessionToken;
211+
}
212+
190213
return true;
191214
}
192215

0 commit comments

Comments
 (0)