Skip to content

Commit d513554

Browse files
authored
chore: require cli integ test when changing/adding a feature flag. (#34584)
A feature flag has the potential to impact the behavior of all CDK apps, including those defined as part our [CLI integration test package](https://github.com/aws/aws-cdk-cli/tree/main/packages/%40aws-cdk-testing/cli-integ). For example: #34556 This PR made it so deploying CDK apps with a lambda function now also requires permissions to create log groups. This is not a breaking change for the CDK, but it did broke in our pipeline because of some permission limitations we impose on it. It could have been caught in the test pipeline. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent d8e6c09 commit d513554

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

.github/workflows/request-cli-integ-test.yml

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,7 @@ jobs:
2424
base_sha: ${{ github.event.pull_request.base.sha }}
2525
files_yaml: |
2626
cli:
27-
- packages/aws-cdk/bin/**
28-
- packages/aws-cdk/lib/**
29-
- packages/aws-cdk/test/**
30-
- packages/@aws-cdk/cloudformation-diff/lib/**
31-
- packages/@aws-cdk/cloudformation-diff/test/**
32-
- packages/@aws-cdk-testing/cli-integ/bin/**
33-
- packages/@aws-cdk-testing/cli-integ/entrypoints/**
34-
- packages/@aws-cdk-testing/cli-integ/lib/**
35-
- packages/@aws-cdk-testing/cli-integ/resources/**
36-
- packages/@aws-cdk-testing/cli-integ/test/**
37-
- packages/@aws-cdk-testing/cli-integ/tests/**
27+
- packages/aws-cdk-lib/cx-api/lib/features.ts
3828
submit-to-test-pipeline:
3929
environment: test-pipeline
4030
needs: cli-changes

0 commit comments

Comments
 (0)