Skip to content

Commit cea654b

Browse files
authored
chore(eks): DefaultVersion of EksOptimizedImage from 1.14 to 1.24 (#23384)
I found this by accident. It is a parameter that is not too well maintained. The following document confirms that AWS has 1.24 AMI available. https://docs.aws.amazon.com/eks/latest/userguide/eks-optimized-ami.html The following is my personal opinion. If necessary, this PR will respond. 1. we have checked the script in the comments for this parameter. I didn't see much need for it as it simply rewrites it as per the arguments (this is a commit), and the fact that it hasn't been updated since 1.14 makes it look like it hasn't been run from some CI or test. https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/aws-eks/scripts/kube_bump.sh 2. it seems to me that this parameter `LATEST_KUBERNETES_VERSION` could be managed by `eks.KubernetesVersion`, since the two are independent and updates are assumed to have been missed ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Construct Runtime Dependencies: * [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 49ee184 commit cea654b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/@aws-cdk/aws-eks/lib/cluster.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2274,7 +2274,7 @@ export class EksOptimizedImage implements ec2.IMachineImage {
22742274
}
22752275

22762276
// MAINTAINERS: use ./scripts/kube_bump.sh to update LATEST_KUBERNETES_VERSION
2277-
const LATEST_KUBERNETES_VERSION = '1.14';
2277+
const LATEST_KUBERNETES_VERSION = '1.24';
22782278

22792279
/**
22802280
* Whether the worker nodes should support GPU or just standard instances

packages/@aws-cdk/aws-eks/test/cluster.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1566,7 +1566,7 @@ describe('cluster', () => {
15661566
test('EksOptimizedImage() with no nodeType always uses STANDARD with LATEST_KUBERNETES_VERSION', () => {
15671567
// GIVEN
15681568
const { app, stack } = testFixtureNoVpc();
1569-
const LATEST_KUBERNETES_VERSION = '1.14';
1569+
const LATEST_KUBERNETES_VERSION = '1.24';
15701570

15711571
// WHEN
15721572
new eks.EksOptimizedImage().getImage(stack);

0 commit comments

Comments
 (0)