Skip to content

Commit cc204ca

Browse files
authored
feat(route53): HostedZone's default period at the end should be optional (#25379)
new flag `addTrailingDot` The addTrailingDot option provides users with the choice to add a trailing dot (.) to the given domain name. In DNS, appending a dot at the end of a domain name indicates that the domain name is a fully qualified domain name (FQDN). This function returns the value as is if the domain name is already an FQDN or has a trailing dot, and otherwise treats it as having a trailing dot. The existing specification was rejecting domain names with trailing dots, but this modification makes it unnecessary, so the validation check has been removed. Closes #22406 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 684754b commit cc204ca

File tree

13 files changed

+209
-83
lines changed

13 files changed

+209
-83
lines changed

Diff for: packages/@aws-cdk-testing/framework-integ/test/aws-route53/test/integ.route53.js.snapshot/aws-cdk-route53-integ.assets.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
{
2-
"version": "20.0.0",
2+
"version": "31.0.0",
33
"files": {
4-
"00cd063646d893e6ee34f7fb3e022ab4f3c0de2c0388548e226905f45a0caec2": {
4+
"f9c954c8023429cbccaf7169883a3b5bb6ecd00c97f9931179eb65a405f68dd4": {
55
"source": {
66
"path": "aws-cdk-route53-integ.template.json",
77
"packaging": "file"
88
},
99
"destinations": {
1010
"current_account-current_region": {
1111
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
12-
"objectKey": "00cd063646d893e6ee34f7fb3e022ab4f3c0de2c0388548e226905f45a0caec2.json",
12+
"objectKey": "f9c954c8023429cbccaf7169883a3b5bb6ecd00c97f9931179eb65a405f68dd4.json",
1313
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
1414
}
1515
}

Diff for: packages/@aws-cdk-testing/framework-integ/test/aws-route53/test/integ.route53.js.snapshot/aws-cdk-route53-integ.template.json

+6
Original file line numberDiff line numberDiff line change
@@ -274,6 +274,12 @@
274274
"Name": "sub.cdk.test."
275275
}
276276
},
277+
"PublicZoneWithDotAE1455DD": {
278+
"Type": "AWS::Route53::HostedZone",
279+
"Properties": {
280+
"Name": "cdk.test"
281+
}
282+
},
277283
"CNAMEC70A2D52": {
278284
"Type": "AWS::Route53::RecordSet",
279285
"Properties": {
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"version":"20.0.0"}
1+
{"version":"31.0.0"}

Diff for: packages/@aws-cdk-testing/framework-integ/test/aws-route53/test/integ.route53.js.snapshot/integ.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "20.0.0",
2+
"version": "31.0.0",
33
"testCases": {
44
"integ.route53": {
55
"stacks": [

Diff for: packages/@aws-cdk-testing/framework-integ/test/aws-route53/test/integ.route53.js.snapshot/manifest.json

+14-8
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
11
{
2-
"version": "20.0.0",
2+
"version": "31.0.0",
33
"artifacts": {
4-
"Tree": {
5-
"type": "cdk:tree",
6-
"properties": {
7-
"file": "tree.json"
8-
}
9-
},
104
"aws-cdk-route53-integ.assets": {
115
"type": "cdk:asset-manifest",
126
"properties": {
@@ -23,7 +17,7 @@
2317
"validateOnSynth": false,
2418
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-deploy-role-${AWS::AccountId}-${AWS::Region}",
2519
"cloudFormationExecutionRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-cfn-exec-role-${AWS::AccountId}-${AWS::Region}",
26-
"stackTemplateAssetObjectUrl": "s3://cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}/00cd063646d893e6ee34f7fb3e022ab4f3c0de2c0388548e226905f45a0caec2.json",
20+
"stackTemplateAssetObjectUrl": "s3://cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}/f9c954c8023429cbccaf7169883a3b5bb6ecd00c97f9931179eb65a405f68dd4.json",
2721
"requiresBootstrapStackVersion": 6,
2822
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version",
2923
"additionalDependencies": [
@@ -147,6 +141,12 @@
147141
"data": "PublicSubZoneDBD26A0A"
148142
}
149143
],
144+
"/aws-cdk-route53-integ/PublicZoneWithDot/Resource": [
145+
{
146+
"type": "aws:cdk:logicalId",
147+
"data": "PublicZoneWithDotAE1455DD"
148+
}
149+
],
150150
"/aws-cdk-route53-integ/CNAME/Resource": [
151151
{
152152
"type": "aws:cdk:logicalId",
@@ -197,6 +197,12 @@
197197
]
198198
},
199199
"displayName": "aws-cdk-route53-integ"
200+
},
201+
"Tree": {
202+
"type": "cdk:tree",
203+
"properties": {
204+
"file": "tree.json"
205+
}
200206
}
201207
}
202208
}

0 commit comments

Comments
 (0)