Skip to content

Commit c4fd9fd

Browse files
authored
revert(ecs): add validation checks to memory cpu combinations of FARGATE compatible task definitions (#34155)
Reverts #33608 This is a breaking change because `cpu` property allows input like `1vcpu` although it's not documented in the public CFN documentation. This would mean that the reverted PR will cause regression on CDK app that looks like below ``` const taskDefinition = new TaskDefinition(this, 'MyFargateTaskDef', { compatibility: Compatibility.FARGATE, family: "update-service-test-fargate-taskdef-small-cpu", memoryMiB: "2gb", cpu: "1 vcpu", networkMode: NetworkMode.AWS_VPC }); ```
1 parent 54e8222 commit c4fd9fd

25 files changed

+42
-1200
lines changed

packages/@aws-cdk-testing/framework-integ/test/aws-ecs/test/integ.fargate-task-def.js.snapshot/FargateTaskDefinitionDefaultTestDeployAssertD76B1D35.assets.json

Lines changed: 0 additions & 19 deletions
This file was deleted.

packages/@aws-cdk-testing/framework-integ/test/aws-ecs/test/integ.fargate-task-def.js.snapshot/FargateTaskDefinitionDefaultTestDeployAssertD76B1D35.template.json

Lines changed: 0 additions & 36 deletions
This file was deleted.

packages/@aws-cdk-testing/framework-integ/test/aws-ecs/test/integ.fargate-task-def.js.snapshot/aws-ecs-fargate-task-def.assets.json

Lines changed: 0 additions & 19 deletions
This file was deleted.

packages/@aws-cdk-testing/framework-integ/test/aws-ecs/test/integ.fargate-task-def.js.snapshot/aws-ecs-fargate-task-def.template.json

Lines changed: 0 additions & 87 deletions
This file was deleted.

packages/@aws-cdk-testing/framework-integ/test/aws-ecs/test/integ.fargate-task-def.js.snapshot/cdk.out

Lines changed: 0 additions & 1 deletion
This file was deleted.

packages/@aws-cdk-testing/framework-integ/test/aws-ecs/test/integ.fargate-task-def.js.snapshot/integ.json

Lines changed: 0 additions & 12 deletions
This file was deleted.

packages/@aws-cdk-testing/framework-integ/test/aws-ecs/test/integ.fargate-task-def.js.snapshot/manifest.json

Lines changed: 0 additions & 145 deletions
This file was deleted.

0 commit comments

Comments
 (0)