chore(prlint): remove needs-review label on approved prs (#25506)

I figure that approved PRs should also lose the `needs-review` label, since they will still exist in the open PR list for a while and pollute the pool of actual prs needing review. I could've bundled this in to `maintainerRequestsChanges` but I figured it makes more sense to be explicit about the different rules we have for the `needs-review` label.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Author: kaizencc

tools/@aws-cdk/prlint/lint.ts

@@ -99,7 +99,6 @@ interface Test {
  * Represents a set of tests and the conditions under which those rules exempt.
  */
 interface ValidateRuleSetOptions {
-
   /**
    * The function to test for exemption from the rules in testRuleSet.
    */
@@ -151,7 +150,6 @@ class ValidationCollector {
  * Props used to perform linting against the pull request.
  */
 export interface PullRequestLinterProps {
-
   /**
    * GitHub client scoped to pull requests. Imported via @actions/github.
    */
@@ -345,6 +343,10 @@ export class PullRequestLinter {
         && review.user?.login !== 'aws-cdk-automation'
         && review.state === 'CHANGES_REQUESTED'
     );
+    const maintainerApproved = reviews.data.some(
+      review => review.author_association === 'MEMBER'
+        && review.state === 'APPROVED'
+    );
     const prLinterFailed = reviews.data.find((review) => review.user?.login === 'aws-cdk-automation' && review.state !== 'DISMISSED') as Review;
     const userRequestsExemption = pr.labels.some(label => (label.name === Exemption.REQUEST_EXEMPTION || label.name === Exemption.REQUEST_CLARIFICATION));
     console.log('evaluation: ', JSON.stringify({
@@ -364,6 +366,8 @@ export class PullRequestLinter {
         || maintainerRequestedChanges
         // or the PR linter failed and the user didn't request an exemption
         || (prLinterFailed && !userRequestsExemption)
+        // or a maintainer has already approved the PR
+        || maintainerApproved
     ) {
       if (pr.labels.some(label => label.name === 'pr/needs-review')) {
         console.log(`removing labels from pr ${pr.number}`);

tools/@aws-cdk/prlint/test/lint.test.ts

@@ -647,6 +647,39 @@ describe('integration tests required on features', () => {
       expect(mockAddLabel.mock.calls).toEqual([]);
     });
 
+    test('does not need a review if member has approved', async () => {
+      // GIVEN
+      mockListReviews.mockImplementation(() => {
+        return {
+          data: [
+            { id: 1111122223, user: { login: 'someuser' }, author_association: 'MEMBER', state: 'APPROVED' },
+          ]
+        }
+      });
+      (pr as any).labels = [
+        {
+          name: 'pr/needs-review',
+        }
+      ];
+
+      // WHEN
+      const prLinter = configureMock(pr);
+      await prLinter.validateStatusEvent(pr as any, {
+        sha: SHA,
+        context: linter.CODE_BUILD_CONTEXT,
+        state: 'success',
+      } as any);
+
+      // THEN
+      expect(mockRemoveLabel.mock.calls[0][0]).toEqual({
+        "issue_number": 1234,
+        "name": "pr/needs-review",
+        "owner": "aws",
+        "repo": "aws-cdk",
+      });
+      expect(mockAddLabel.mock.calls).toEqual([]);
+    });
+
     test('review happens even if linter fails', async () => {
       // GIVEN
       mockListReviews.mockImplementation(() => {