chore: fix ci=true integ tests (#21000)

`beforeEach()`/`afterEach()` do not work because of the crazy way we're doing parallelism in the CLI integ tests.

Remove the mechanism, explain that it does not work.

Also turn `warning()` logging into `stdout` so it doesn't fail builds on Azure.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Author: rix0rrr

packages/aws-cdk-lib/package.json

@@ -560,6 +560,7 @@
     "./aws-ram": "./aws-ram/index.js",
     "./aws-rds": "./aws-rds/index.js",
     "./aws-redshift": "./aws-redshift/index.js",
+    "./aws-redshiftserverless": "./aws-redshiftserverless/index.js",
     "./aws-refactorspaces": "./aws-refactorspaces/index.js",
     "./aws-rekognition": "./aws-rekognition/index.js",
     "./aws-resiliencehub": "./aws-resiliencehub/index.js",

packages/aws-cdk/CONTRIBUTING.md

@@ -89,6 +89,20 @@ You can also run just these tests by executing:
 yarn integ-cli-no-regression
 ```
 
+##### Warning
+
+Since the tests take a long time to run, we run them in parallel in order to minimize running time. Jest does not have
+good support for parallelism, the only thing that exists is `test.concurrent()` and it has a couple of limitations:
+
+- It's not possible to only run a subset of tests, all tests will execute (the reason for this is that it will start all
+  tests in parallel, but only `await` your selected subset specified with the `-t TESTNAME` option. However, all tests
+  are running and Node will not exit until they're all finished).
+- It's not possible to use `beforeEach()` and `afterEach()`.
+
+Because of the first limitation, concurrency is only enabled on the build server (via the `JEST_TEST_CONCURRENT`
+environment variable), not locally. Note: tests using `beforeEach()` will appear to work locally, but will fail on the
+build server! Don't use it!
+
 #### Regression
 
 Validate that previously tested functionality still works in light of recent changes to the CLI. This is done by fetching the functional tests of the previous published release, and running them against the new CLI code.

packages/aws-cdk/lib/logging.ts

@@ -5,12 +5,16 @@ import * as chalk from 'chalk';
 type StyleFn = (str: string) => string;
 const { stdout, stderr } = process;
 
-const logger = (stream: Writable, styles?: StyleFn[]) => (fmt: string, ...args: any[]) => {
+type WritableFactory = () => Writable;
+
+const logger = (stream: Writable | WritableFactory, styles?: StyleFn[]) => (fmt: string, ...args: any[]) => {
   let str = util.format(fmt, ...args);
   if (styles && styles.length) {
     str = styles.reduce((a, style) => style(a), str);
   }
-  stream.write(str + '\n');
+
+  const realStream = typeof stream === 'function' ? stream() : stream;
+  realStream.write(str + '\n');
 };
 
 export enum LogLevel {
@@ -39,15 +43,15 @@ export function increaseVerbosity() {
 }
 
 const stream = () => CI ? stdout : stderr;
-const _debug = (fmt: string, ...args: any) => logger(stream(), [chalk.gray])(fmt, ...args);
+const _debug = logger(stream, [chalk.gray]);
 
 export const trace = (fmt: string, ...args: any) => logLevel >= LogLevel.TRACE && _debug(fmt, ...args);
 export const debug = (fmt: string, ...args: any[]) => logLevel >= LogLevel.DEBUG && _debug(fmt, ...args);
 export const error = logger(stderr, [chalk.red]);
-export const warning = logger(stderr, [chalk.yellow]);
-export const success = (fmt: string, ...args: any) => logger(stream(), [chalk.green])(fmt, ...args);
-export const highlight = (fmt: string, ...args: any) => logger(stream(), [chalk.bold])(fmt, ...args);
-export const print = (fmt: string, ...args: any) => logger(stream())(fmt, ...args);
+export const warning = logger(stream, [chalk.yellow]);
+export const success = logger(stream, [chalk.green]);
+export const highlight = logger(stream, [chalk.bold]);
+export const print = logger(stream);
 export const data = logger(stdout);
 
 export type LoggerFunction = (fmt: string, ...args: any[]) => void;

packages/aws-cdk/test/integ/cli/cli.integtest.ts

@@ -18,16 +18,17 @@ describe('ci', () => {
     expect(diffOutput).not.toEqual('');
   }));
   describe('ci=true', () => {
-    beforeEach(() => {
-      process.env.CI = 'true';
-    });
-    afterEach(() => {
-      process.env.CI = undefined;
-    });
     integTest('output to stdout', withDefaultFixture(async (fixture) => {
-      const deployOutput = await fixture.cdkDeploy('test-2', { captureStderr: true, onlyStderr: true });
-      const diffOutput = await fixture.cdk(['diff', fixture.fullStackName('test-2')], { captureStderr: true, onlyStderr: true });
-      const destroyOutput = await fixture.cdkDestroy('test-2', { captureStderr: true, onlyStderr: true });
+
+      const execOptions = {
+        captureStderr: true,
+        onlyStderr: true,
+        modEnv: { CI: 'true' },
+      };
+
+      const deployOutput = await fixture.cdkDeploy('test-2', execOptions);
+      const diffOutput = await fixture.cdk(['diff', fixture.fullStackName('test-2')], execOptions);
+      const destroyOutput = await fixture.cdkDestroy('test-2', execOptions);
       expect(deployOutput).toEqual('');
       expect(destroyOutput).toEqual('');
       expect(diffOutput).toEqual('');