Skip to content

Commit b0e0353

Browse files
chore(step-function-tasks): add comment that aws-sdk integration pattern is not impacted by sdk upgrade (#29795)
### Reason for this change For upgrading sdkv2 to sdkv3, I have confirmed that the [pattern](https://docs.aws.amazon.com/step-functions/latest/dg/supported-services-awssdk.html) used by step function task is not impacted by the migration and will remain the same. Adding a comment to add historical context for anyone revisiting this package for another sdk upgrade. ### Description of changes Just added comments. No code changes. ### Description of how you validated changes No tests added for comments ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 73f281c commit b0e0353

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/aws-sdk/call-aws-service.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,9 @@ export class CallAwsService extends sfn.TaskStateBase {
118118
service = service.toLowerCase();
119119
}
120120

121+
// The pattern here is: "arn:aws:states:::aws-sdk:serviceName:apiAction.[serviceIntegrationPattern]"
122+
// See here: https://docs.aws.amazon.com/step-functions/latest/dg/supported-services-awssdk.html
123+
// This does not change with sdk upgrades, TT:P125388388
121124
return {
122125
Resource: integrationResourceArn(
123126
'aws-sdk',

0 commit comments

Comments
 (0)