Skip to content

Commit aff7ff4

Browse files
authored
chore: serverAccessLogsUseBucketPolicy flag was released in 2.60.0 (#25435)
The current file says it was released on 2.59.0, but that is incorrect. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 366e2e8 commit aff7ff4

File tree

3 files changed

+39
-39
lines changed

3 files changed

+39
-39
lines changed

packages/@aws-cdk/cx-api/FEATURE_FLAGS.md

+18-18
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ Flags come in three types:
4242
| [@aws-cdk/aws-ecs:disableExplicitDeploymentControllerForCircuitBreaker](#aws-cdkaws-ecsdisableexplicitdeploymentcontrollerforcircuitbreaker) | Avoid setting the "ECS" deployment controller when adding a circuit breaker | 2.51.0 | (fix) |
4343
| [@aws-cdk/aws-events:eventsTargetQueueSameAccount](#aws-cdkaws-eventseventstargetqueuesameaccount) | Event Rules may only push to encrypted SQS queues in the same account | 2.51.0 | (fix) |
4444
| [@aws-cdk/aws-iam:standardizedServicePrincipals](#aws-cdkaws-iamstandardizedserviceprincipals) | Use standardized (global) service principals everywhere | 2.51.0 | (fix) |
45-
| [@aws-cdk/aws-s3:serverAccessLogsUseBucketPolicy](#aws-cdkaws-s3serveraccesslogsusebucketpolicy) | Use S3 Bucket Policy instead of ACLs for Server Access Logging | 2.59.0 | (fix) |
4645
| [@aws-cdk/aws-iam:importedRoleStackSafeDefaultPolicyName](#aws-cdkaws-iamimportedrolestacksafedefaultpolicyname) | Enable this feature to by default create default policy names for imported roles that depend on the stack the role is in. | 2.60.0 | (fix) |
46+
| [@aws-cdk/aws-s3:serverAccessLogsUseBucketPolicy](#aws-cdkaws-s3serveraccesslogsusebucketpolicy) | Use S3 Bucket Policy instead of ACLs for Server Access Logging | 2.60.0 | (fix) |
4747
| [@aws-cdk/customresources:installLatestAwsSdkDefault](#aws-cdkcustomresourcesinstalllatestawssdkdefault) | Whether to install the latest SDK by default in AwsCustomResource | 2.60.0 | (default) |
4848
| [@aws-cdk/aws-codedeploy:removeAlarmsFromDeploymentGroup](#aws-cdkaws-codedeployremovealarmsfromdeploymentgroup) | Remove CloudWatch alarms from deployment group | 2.65.0 | (fix) |
4949
| [@aws-cdk/aws-rds:databaseProxyUniqueResourceName](#aws-cdkaws-rdsdatabaseproxyuniqueresourcename) | Use unique resource name for Database Proxy | 2.65.0 | (fix) |
@@ -780,35 +780,35 @@ This flag disables use of that exceptions database and always uses the global se
780780
| 2.51.0 | `false` | `true` |
781781

782782

783-
### @aws-cdk/aws-s3:serverAccessLogsUseBucketPolicy
784-
785-
*Use S3 Bucket Policy instead of ACLs for Server Access Logging* (fix)
783+
### @aws-cdk/aws-iam:importedRoleStackSafeDefaultPolicyName
786784

787-
Enable this feature flag to use S3 Bucket Policy for granting permission fo Server Access Logging
788-
rather than using the canned `LogDeliveryWrite` ACL. ACLs do not work when Object Ownership is
789-
enabled on the bucket.
785+
*Enable this feature to by default create default policy names for imported roles that depend on the stack the role is in.* (fix)
790786

791-
This flag uses a Bucket Policy statement to allow Server Access Log delivery, following best
792-
practices for S3.
787+
Without this, importing the same role in multiple places could lead to the permissions given for one version of the imported role
788+
to overwrite permissions given to the role at a different place where it was imported. This was due to all imported instances
789+
of a role using the same default policy name.
793790

794-
@see https://docs.aws.amazon.com/AmazonS3/latest/userguide/enable-server-access-logging.html
791+
This new implementation creates default policy names based on the constructs node path in their stack.
795792

796793

797794
| Since | Default | Recommended |
798795
| ----- | ----- | ----- |
799796
| (not in v1) | | |
800-
| 2.59.0 | `false` | `true` |
797+
| 2.60.0 | `false` | `true` |
801798

802799

803-
### @aws-cdk/aws-iam:importedRoleStackSafeDefaultPolicyName
800+
### @aws-cdk/aws-s3:serverAccessLogsUseBucketPolicy
804801

805-
*Enable this feature to by default create default policy names for imported roles that depend on the stack the role is in.* (fix)
802+
*Use S3 Bucket Policy instead of ACLs for Server Access Logging* (fix)
806803

807-
Without this, importing the same role in multiple places could lead to the permissions given for one version of the imported role
808-
to overwrite permissions given to the role at a different place where it was imported. This was due to all imported instances
809-
of a role using the same default policy name.
804+
Enable this feature flag to use S3 Bucket Policy for granting permission fo Server Access Logging
805+
rather than using the canned `LogDeliveryWrite` ACL. ACLs do not work when Object Ownership is
806+
enabled on the bucket.
810807

811-
This new implementation creates default policy names based on the constructs node path in their stack.
808+
This flag uses a Bucket Policy statement to allow Server Access Log delivery, following best
809+
practices for S3.
810+
811+
@see https://docs.aws.amazon.com/AmazonS3/latest/userguide/enable-server-access-logging.html
812812

813813

814814
| Since | Default | Recommended |
@@ -907,7 +907,7 @@ according to the OS of the machine image.
907907
*SecretTargetAttachments uses the ResourcePolicy of the attached Secret.* (fix)
908908

909909
Enable this feature flag to make SecretTargetAttachments use the ResourcePolicy of the attached Secret.
910-
SecretTargetAttachments are created to connect a Secret to a target resource.
910+
SecretTargetAttachments are created to connect a Secret to a target resource.
911911
In CDK code, they behave like regular Secret and can be used as a stand-in in most situations.
912912
Previously, adding to the ResourcePolicy of a SecretTargetAttachment did attempt to create a separate ResourcePolicy for the same Secret.
913913
However Secrets can only have a single ResourcePolicy, causing the CloudFormation deployment to fail.

packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md

+18-18
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ Flags come in three types:
4242
| [@aws-cdk/aws-ecs:disableExplicitDeploymentControllerForCircuitBreaker](#aws-cdkaws-ecsdisableexplicitdeploymentcontrollerforcircuitbreaker) | Avoid setting the "ECS" deployment controller when adding a circuit breaker | 2.51.0 | (fix) |
4343
| [@aws-cdk/aws-events:eventsTargetQueueSameAccount](#aws-cdkaws-eventseventstargetqueuesameaccount) | Event Rules may only push to encrypted SQS queues in the same account | 2.51.0 | (fix) |
4444
| [@aws-cdk/aws-iam:standardizedServicePrincipals](#aws-cdkaws-iamstandardizedserviceprincipals) | Use standardized (global) service principals everywhere | 2.51.0 | (fix) |
45-
| [@aws-cdk/aws-s3:serverAccessLogsUseBucketPolicy](#aws-cdkaws-s3serveraccesslogsusebucketpolicy) | Use S3 Bucket Policy instead of ACLs for Server Access Logging | 2.59.0 | (fix) |
4645
| [@aws-cdk/aws-iam:importedRoleStackSafeDefaultPolicyName](#aws-cdkaws-iamimportedrolestacksafedefaultpolicyname) | Enable this feature to by default create default policy names for imported roles that depend on the stack the role is in. | 2.60.0 | (fix) |
46+
| [@aws-cdk/aws-s3:serverAccessLogsUseBucketPolicy](#aws-cdkaws-s3serveraccesslogsusebucketpolicy) | Use S3 Bucket Policy instead of ACLs for Server Access Logging | 2.60.0 | (fix) |
4747
| [@aws-cdk/customresources:installLatestAwsSdkDefault](#aws-cdkcustomresourcesinstalllatestawssdkdefault) | Whether to install the latest SDK by default in AwsCustomResource | 2.60.0 | (default) |
4848
| [@aws-cdk/aws-codedeploy:removeAlarmsFromDeploymentGroup](#aws-cdkaws-codedeployremovealarmsfromdeploymentgroup) | Remove CloudWatch alarms from deployment group | 2.65.0 | (fix) |
4949
| [@aws-cdk/aws-rds:databaseProxyUniqueResourceName](#aws-cdkaws-rdsdatabaseproxyuniqueresourcename) | Use unique resource name for Database Proxy | 2.65.0 | (fix) |
@@ -780,35 +780,35 @@ This flag disables use of that exceptions database and always uses the global se
780780
| 2.51.0 | `false` | `true` |
781781

782782

783-
### @aws-cdk/aws-s3:serverAccessLogsUseBucketPolicy
784-
785-
*Use S3 Bucket Policy instead of ACLs for Server Access Logging* (fix)
783+
### @aws-cdk/aws-iam:importedRoleStackSafeDefaultPolicyName
786784

787-
Enable this feature flag to use S3 Bucket Policy for granting permission fo Server Access Logging
788-
rather than using the canned `LogDeliveryWrite` ACL. ACLs do not work when Object Ownership is
789-
enabled on the bucket.
785+
*Enable this feature to by default create default policy names for imported roles that depend on the stack the role is in.* (fix)
790786

791-
This flag uses a Bucket Policy statement to allow Server Access Log delivery, following best
792-
practices for S3.
787+
Without this, importing the same role in multiple places could lead to the permissions given for one version of the imported role
788+
to overwrite permissions given to the role at a different place where it was imported. This was due to all imported instances
789+
of a role using the same default policy name.
793790

794-
@see https://docs.aws.amazon.com/AmazonS3/latest/userguide/enable-server-access-logging.html
791+
This new implementation creates default policy names based on the constructs node path in their stack.
795792

796793

797794
| Since | Default | Recommended |
798795
| ----- | ----- | ----- |
799796
| (not in v1) | | |
800-
| 2.59.0 | `false` | `true` |
797+
| 2.60.0 | `false` | `true` |
801798

802799

803-
### @aws-cdk/aws-iam:importedRoleStackSafeDefaultPolicyName
800+
### @aws-cdk/aws-s3:serverAccessLogsUseBucketPolicy
804801

805-
*Enable this feature to by default create default policy names for imported roles that depend on the stack the role is in.* (fix)
802+
*Use S3 Bucket Policy instead of ACLs for Server Access Logging* (fix)
806803

807-
Without this, importing the same role in multiple places could lead to the permissions given for one version of the imported role
808-
to overwrite permissions given to the role at a different place where it was imported. This was due to all imported instances
809-
of a role using the same default policy name.
804+
Enable this feature flag to use S3 Bucket Policy for granting permission fo Server Access Logging
805+
rather than using the canned `LogDeliveryWrite` ACL. ACLs do not work when Object Ownership is
806+
enabled on the bucket.
810807

811-
This new implementation creates default policy names based on the constructs node path in their stack.
808+
This flag uses a Bucket Policy statement to allow Server Access Log delivery, following best
809+
practices for S3.
810+
811+
@see https://docs.aws.amazon.com/AmazonS3/latest/userguide/enable-server-access-logging.html
812812

813813

814814
| Since | Default | Recommended |
@@ -907,7 +907,7 @@ according to the OS of the machine image.
907907
*SecretTargetAttachments uses the ResourcePolicy of the attached Secret.* (fix)
908908

909909
Enable this feature flag to make SecretTargetAttachments use the ResourcePolicy of the attached Secret.
910-
SecretTargetAttachments are created to connect a Secret to a target resource.
910+
SecretTargetAttachments are created to connect a Secret to a target resource.
911911
In CDK code, they behave like regular Secret and can be used as a stand-in in most situations.
912912
Previously, adding to the ResourcePolicy of a SecretTargetAttachment did attempt to create a separate ResourcePolicy for the same Secret.
913913
However Secrets can only have a single ResourcePolicy, causing the CloudFormation deployment to fail.

packages/aws-cdk-lib/cx-api/lib/features.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -601,7 +601,7 @@ export const FLAGS: Record<string, FlagInfo> = {
601601
602602
@see https://docs.aws.amazon.com/AmazonS3/latest/userguide/enable-server-access-logging.html
603603
`,
604-
introducedIn: { v2: '2.59.0' },
604+
introducedIn: { v2: '2.60.0' },
605605
recommendedValue: true,
606606
},
607607

@@ -700,7 +700,7 @@ export const FLAGS: Record<string, FlagInfo> = {
700700
summary: 'SecretTargetAttachments uses the ResourcePolicy of the attached Secret.',
701701
detailsMd: `
702702
Enable this feature flag to make SecretTargetAttachments use the ResourcePolicy of the attached Secret.
703-
SecretTargetAttachments are created to connect a Secret to a target resource.
703+
SecretTargetAttachments are created to connect a Secret to a target resource.
704704
In CDK code, they behave like regular Secret and can be used as a stand-in in most situations.
705705
Previously, adding to the ResourcePolicy of a SecretTargetAttachment did attempt to create a separate ResourcePolicy for the same Secret.
706706
However Secrets can only have a single ResourcePolicy, causing the CloudFormation deployment to fail.
@@ -773,7 +773,7 @@ export const FLAGS: Record<string, FlagInfo> = {
773773
can set the \`restrictDefaultSecurityGroup: false\`.
774774
`,
775775
},
776-
776+
777777
//////////////////////////////////////////////////////////////////////
778778
[APIGATEWAY_REQUEST_VALIDATOR_UNIQUE_ID]: {
779779
type: FlagType.BugFix,

0 commit comments

Comments
 (0)