Skip to content

Commit a1ad28b

Browse files
authored
chore(logs): remove hardcoded account id and region from snapshot (#27621)
In #26498, I injected specific account id and region in integration test snapshot by mistake. This PR replaces them with variables by taking snapshot correctly. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 0e81c19 commit a1ad28b

File tree

7 files changed

+35
-39
lines changed

7 files changed

+35
-39
lines changed

packages/@aws-cdk-testing/framework-integ/test/aws-logs/test/integ.subscriptionfilter.js.snapshot/aws-cdk-subscriptionfilter-integ.assets.json

+4-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-logs/test/integ.subscriptionfilter.js.snapshot/cdk.out

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-logs/test/integ.subscriptionfilter.js.snapshot/integ.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-logs/test/integ.subscriptionfilter.js.snapshot/integtestDefaultTestDeployAssert24D5C536.assets.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-logs/test/integ.subscriptionfilter.js.snapshot/manifest.json

+8-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-logs/test/integ.subscriptionfilter.js.snapshot/tree.json

+19-19
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-logs/test/integ.subscriptionfilter.ts

+1-6
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,7 @@ class SubscriptionFilterIntegStack extends Stack {
2525
}
2626

2727
const app = new App();
28-
const testCase = new SubscriptionFilterIntegStack(app, 'aws-cdk-subscriptionfilter-integ', {
29-
env: {
30-
account: process.env.CDK_INTEG_ACCOUNT || process.env.CDK_DEFAULT_ACCOUNT,
31-
region: process.env.CDK_INTEG_REGION || process.env.CDK_DEFAULT_REGION,
32-
},
33-
});
28+
const testCase = new SubscriptionFilterIntegStack(app, 'aws-cdk-subscriptionfilter-integ');
3429

3530
new IntegTest(app, 'integ-test', {
3631
testCases: [testCase],

0 commit comments

Comments
 (0)